[Plugin] TIG-Smart_offset

TIG

undefined methodsuitable?' for TIG::Smart_offsetter:ModuleError Loading File TIG-Smart_offset.rb
undefined method suitable?' for TIG::Smart_offsetter:Module
but worked to a degree, the new border and face are separate and I can't seem to get them to merge with the original face?

john
Strange there is a method called that ?
It checks selection for suitability and affects how the menu, toolbar and context-menu items display/enabled...
Are you on MAC ?
Was there a line number with that error ?
I'm about to issue v1.1 to resolve Pilou's tolerance issue...
I'll swap some code around to see if making that method earlier fixes it for you...
Let me know whatever you can...
If it's still an issue a sample SKP might help...

TIG

Here's v1.1 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
It's been made more robust.
It now works on Pilou's problem shapes!

driven

Hi Tig,
I'll try the new one but something really odd is going on, and yes I'm on a mac.
2012-12-21 01.06.32 am.png
I used SU to instal, and had line numbers then, so I removed it from 'plugins' to do again, but
this has been uninstalled, moved to trash, emptied trash, restarted computer, but it still there and it works, as well as it did, although sketchup can't find the file.... it's crazy, I don't have hidden files either.

I'll over write with the new
john

driven

found it, a new 'finder. replacement doesn't update instantly... bin that
ok no errors. menu cmd works, context cmd work, toolbar cmd dosen't do anything

It works if I split if the validation proc
cmd2=UI::Command.new('TIG.Smart_offset'){self.dialog()} cmd2.small_icon=File.join(dir, 'TIG-Smart_offset.png') cmd2.large_icon=File.join(dir, 'TIG-Smart_offset.png') toolbar=UI::Toolbar.new('TIG.Smart_offset') toolbar.add_item(cmd2)

john

Mistro11

You have no idea how many times I got frustrated doing an offset and have to get in there and clean up the shape. Thanks TIG!

jeff hammond

i'm all greyed out (on two separate computers with different OS & different versions of sketchup on them).. will investigate more tomorrow

(skindigo toolbar as reference to what the blue/blacks should look like)

notareal

Merry Christmas to you too!

Jim

in cmd.set_validation_proc (and other places) you want to give the full scope of the suitable? method since it is being called from SketchUp outside the scope of your module.

Also, combine the MF_ bits.


cmd=UI;;Command.new('TIG.Smart_offset'){self.dialog()}
if TIG;;Smart_offsetter.suitable?()
MF_ENABLED
else
MF_DISABLED | MF_GRAYED
end

cotty

Nice gift! Thank you and Merry Christmas! (Are we allowed to use it before 24.12.?)

pilou

Yeeeeeeees! Works like a charm now!
You are the Ruby's king!

And lucky because I can't more test your tricky plugin before the next year!

TIG

@jim said:

in cmd.set_validation_proc (and other places) you want to give the full scope of the suitable? method since it is being called from SketchUp outside the scope of your module.

Also, combine the MF_ bits.


> cmd=UI;;Command.new('TIG.Smart_offset'){self.dialog()}
> if TIG;;Smart_offsetter.suitable?()
> MF_ENABLED
> else
> MF_DISABLED | MF_GRAYED
> end
>

Thanks, knew it was obvious... This only affected MACs though ???
This was collecting dust on a virtual dust, until Pilou reminded me that I'd written it, so sometimes things get 'forgotten'...

TIG

Here's v1.2 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
Further robustness in enabling/disabling/graying and suitable? tests [thanks to Jim!].
Seems to be especially for MACs

Jim

@tig said:

This only affected MACs though ???

I am not sure - it was just a guess and I don't have a Mac. Did you try it?

TIG

I don't have a MAC either.
Driven's reported issue was on a MAC and Jeff had other issues on a MAC too...
Hopefully this recent v1.2 [...20121221b.rbz !] will address the suitable? check and MF_ issues with the menus/toolbar...
It still works fine on a PC, but then v1.1 did too

elmer

Nice Christmas gift Tig, thanks a lot, it works perfectly on my Mac.

alvis

Thanx TIG

guanjin

@tig said:

Here's v1.2 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
Further robustness in enabling/disabling/graying and suitable? tests [thanks to Jim!].
Seems to be especially for MACs

TIG: Merry Christmas

jeff hammond

@tig said:

Here's v1.2 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
Further robustness in enabling/disabling/graying and suitable? tests [thanks to Jim!].
Seems to be especially for MACs

Hi Tig
i'm still getting the same greyed out problem.
is there anything i can type in the console or ?? to help figure out what the problem is?
thanks

TIG

Is there no difference at all - if you have nothing preselected, or one edge preselected, or one face preselected, or lots of things [including some edges] preselected ?
The menu/toolbar are only enabled if there's at least one face in the current selection.
The context-menu only appears if there's at least one face in the current selection.

Copy/paste+<enter> these into the Ruby Console and report the results:

with nothing preselected TIG::Smart_offsetter.suitable?()
with one edge preselected TIG::Smart_offsetter.suitable?()
with one face preselected TIG::Smart_offsetter.suitable?()
with lots of things [including some edges] preselected TIG::Smart_offsetter.suitable?()

with one edge preselected TIG::Smart_offsetter.dialog()
with one face preselected TIG::Smart_offsetter.dialog()

jeff hammond

oops
it actually is working now..
it's just the toolbar that remains greyed out at all times but the menu item becomes available once an appropriate selection has been made..

(which, for me personally, is fine.. i more likely than not wont want the toolbar anyway.. i think id use it with a modifier key added to my offset shortcut)