[Plugin] Roof.rb

Dave R · 4 Mar 2011, 13:29

Thanks TIG. I'll do that when I get home and check it. I expect it'll be just fine though.

TIG · 4 Mar 2011, 13:35

Why inexplicable?

Because I can't explain [explicate] it !

My original code was encrypted [a simple encryption, as used by Didier Bur too].
If that loads after Artisan then it has no menu BUT works from the Ruby Console [files load in alphanumeric order].
If you renamed it so it loaded before Artisan then it was fine... BUT then Artisan didn't load at all
I used a decrypted version that worked fine with Artisan, so I was unaware of the problem...
My own version had some minor coding tweaks BUT nothing I can see that should make it behave any differently to the encrypted one... There are almost 4,000 lines of code so I don't want to trawl all of them to find the possible culprit... there are no error messages to help and 'Roof' and 'Artisan' now work fine together with this version anyway...

This new 'unencrypted' & tweaked version works fine now - I recommend everyone to change to it...

Rich O Brien · 4 Mar 2011, 14:14

Nice explication

My comedic timing must be a little off today...

Gus R · 4 Mar 2011, 14:48

Thanks very much for the update TIG.

SketchUpNoobie · 4 Mar 2011, 14:50

Yep. The update seems to be working fine. Thanks.

Whaat · 4 Mar 2011, 16:57

Thanks for updating the plugin, Tig. If you can figure out the problem, let me know. Maybe there is something I can change to fix this. I also have no idea what would cause this.

CAntonis · 4 Mar 2011, 18:57

Thank U TIG!
This plugin will be appreciated as every thing else you created!
BRAVO!!!!

tbd · 29 Mar 2011, 23:12

@tig said:

If that loads after Artisan then it has no menu BUT works from the Ruby Console [files load in alphanumeric order].
If you renamed it so it loaded before Artisan then it was fine... BUT then Artisan didn't load at all

after some debugging at 2am I found the problem - scrambled scripts and pack eval encrypted scripts both return (eval) for FILE , so when tested with file_loaded? the one that gets loaded second it will not execute the block after (usually menu creation code)

workaround: use file_loaded("your_filename") or file_loaded("reverse URI")
eg file_loaded("roof.rb") or file_loaded("ro.plugins.drop")

utiler · 29 Mar 2011, 23:45

Thanks TIG, much appreciated!!

TIG · 30 Mar 2011, 07:57

@unknownuser said:

@tig said:

If that loads after Artisan then it has no menu BUT works from the Ruby Console [files load in alphanumeric order].
If you renamed it so it loaded before Artisan then it was fine... BUT then Artisan didn't load at all

after some debugging at 2am I found the problem - scrambled scripts and pack eval encrypted scripts both return (eval) for FILE , so when tested with file_loaded? the one that gets loaded second it will not execute the block after (usually menu creation code)

workaround: use file_loaded("your_filename") or file_loaded("reverse URI")
eg file_loaded("roof.rb") or file_loaded("ro.plugins.drop")

Thanks for the info...OR we could just separate the menu code from the scrambled part so that it's not eval'd...

CAntonis · 30 Mar 2011, 13:01

Thank U very much TIG. You made a great plugin even greater!

Antonis

jim smith · 30 Mar 2011, 16:11

Thanks for the update TIG

Gus R · 30 Mar 2011, 17:55

Not to be a pest but something isn't right. The "eaves soffit size" is resulting in erroneous dimensions on opposing sides. For instance I input and eaves soffit size of 24" all around but I wind up with 1'-9 3/16" on one side and 2'-2 1/2" on another. Another conflict perhaps or am I imagining things. Did this with a "new" skp as well. Any ideas? Thanks.

TIG · 30 Mar 2011, 18:01

@gus r said:

:arrow: Not to be a pest but something isn't right. The "eaves soffit size" is resulting in erroneous dimensions on opposing sides. For instance I input and eaves soffit size of 24" all around but I wind up with 1'-9 3/16" on one side and 2'-2 1/2" on another. Another conflict perhaps or am I imagining things. Did this with a "new" skp as well. Any ideas? Thanks.

I assume this is with 'gable-roof' ?
The other tools all offset equally anyway ?
I can't reproduce any error...
On a hipped-roof the overhang is always equal too ?
Can you post a SKP that will give you the error [or PM it]...
I can't break it

Gus R · 30 Mar 2011, 18:12

@tig said:

@gus r said:

:arrow: Not to be a pest but something isn't right. The "eaves soffit size" is resulting in erroneous dimensions on opposing sides. For instance I input and eaves soffit size of 24" all around but I wind up with 1'-9 3/16" on one side and 2'-2 1/2" on another. Another conflict perhaps or am I imagining things. Did this with a "new" skp as well. Any ideas? Thanks.

I assume this is with 'gable-roof' ?
The other tools all offset equally anyway ?
I can't reproduce any error...
On a hipped-roof the overhang is always equal too ?
Can you post a SKP that will give you the error [or PM it]...
I can't break it

TIG OK, here's a skp file that I just created. Looks like the gable roof comes out good but the hip and mansard result in the same overhang dimensions. This is all using default setting on the ruby.rb.

roof ruby test.skp

TIG · 30 Mar 2011, 20:06

I can reproduce the problem using your example SKP.
Currently I am a complete loss to say why this might be happening...
I'll sleep on it and come back to you...

Gus R · 30 Mar 2011, 20:16

@tig said:

I can reproduce the problem using your example SKP.
Currently I am a complete loss to say why this might be happening...
I'll sleep on it and come back to you...

Thanks. I have a workaround which is using the old roof.rb in the tools directory. Got a house rendering job in today (first one in a while) which is why I just noticed this.

TIG · 30 Mar 2011, 21:48

@gus r said:

@tig said:

I can reproduce the problem using your example SKP.
Currently I am a complete loss to say why this might be happening...
I'll sleep on it and come back to you...

Thanks. I have a workaround which is using the old roof.rb in the tools directory. Got a house rendering job in today (first one in a while) which is why I just noticed this.

What version of 'old' Roof do you have that works OK ?
The 'new' version shouldn't differ [but clearly does ]

Gus R · 30 Mar 2011, 22:45

@tig said:

What version of 'old' Roof do you have that works OK ?
The 'new' version shouldn't differ [but clearly does ]
Right now 3.0. Which I put in the tools directory because it conflicts with Artisan. The one that isn't working correctly is your latest, 3.1, which I put away after I noticed the problem.

TIG · 31 Mar 2011, 07:36

Gus R

What makes that more puzzling is that v3.0 [encrypted] should be no different to v3.1 decrypted ?
The code hasn't be changed I just unscrambled it - but there IS clearly an effect...
I'll do more investigating...