[Plugin] ToolbarEditor (1.1.2) – updated 08.06.2014

Aerilius

I don't get this and I can't see anything obvious around line 243. Also I don't use a any system calls.

It could be related to SketchUp's skp protocol [1,2,3].
Does this still occur with version 1.0.4, and if so, does it now show a different line?

TIG

line250

var message = messageQueue.shift();
    if (!message) { ready = true; return; }
    // Lock the status variable before sending the message.
    // (because window.location is synchronous in IE and finishes before this
    // function finishes.)
    ready = false;
    var id = message[0],
        url = message[1],
        data = message[2];
    fillMessageField(id, data);

line260
IF 'id' OR more likely 'data' is somehow 'wrong' you get the error ? NULL ?

Aerilius

If data or id could be wrong, no Ruby callback would happen. If url were wrong, IE would navigate to a not existing site. Nothing that gives such an error.

CadFather

only thing is i can't find any underlying pattern - unpredictable so far but i'll keep an eye on it (i'll have a go tonight with the new version. thanks!

also - i made a batch file to import export the registry settings but also i'm getting strange behaviour (when exporting) - will report more on this as it's great if one can save and share the same toolbar layout. overall it's getting better with each version, and the positions are kept more consistently.. great stuff!

Aerilius

By the way, how many toolbars did you have roughly?
The information that I found says that there could be another url length limit around 500 (officially urls in IE can be 2083 characters long). This should not anymore an issue in ToolbarEditor 1.0.4.

With this test in the Ruby Console we could confirm whether this caused the error:

count=0;w=UI;;WebDialog.new;w.set_html("<html></html>");w.add_action_callback("a"){|d,p| count=p.length if p.length>count};w.show{ w.execute_script("var s='';for(var i=0;i<3000;i++){ s+='b';window.location.href='skp;a@'+s;}") }

It then envokes an Internet Explorer error (I get "Could not complete the operation due to error 800700a").
When I then enter " count" into the Ruby console, I get 2077.
Do you get the same error that you got previously ("The data area passed to a system call is too small")?

CadFather

only had two - will run the check later on though just in case

lionk

@aerilius said:

Hi lionk,
can you try ToolbarEditor 1.0.4? It should now remember toolbar names and display Chinese correctly.

yes, toolbar names are remembered correctly!
but Chinese display not so well, still some encoding error if restart sketchup.
e.g.
工具栏

正常

if input"具" and restart SU,ToolbarEditor will never open again.

btw, i think it need to limit toolbar name if someone input nothing(the toolbar wont show), too many words or punctuation.

lionk

the toolbar icon can't remove sometimes. i don't know how it happen...
do duplicated icons permit to add?

lionk

unicode characters in the registry is right all the time.
ruby can parse it but html or js not.is the value UTF8?

Aerilius

I could not reproduce the problem with the same toolbar names (工具栏, 正常, 具) after restarting SketchUp and opening the toolbar editor. I will continue try.

I updated the webdialog with improvements for higher dpi settings.

cmeed

This looks great but I'm missing icons? any ideas.....

@rickw said:

Has anyone else had problems with not all commands being available? I'm also missing a lot of icons that exist on other toolbars.

cheers
c

MISSING ICONS.jpg

Dave R

Do you have those icons on the existing original toolbars?

cmeed

Yes I do, they are all there.

Aerilius

Can you right-click on the missing icons and get the image file path? Maybe some commands return an unusual file path?

Or it is a timing issue, maybe Fredo uses layz-loading techniques, or his tools take longer to load?

cmeed

im not sure how to do what you asked. right clicking the icons - in the toolbar? (nothing)
right clicking in toolbarEditor? (nothing in the menu that come up that looked familiar)

some of fredos icons work. is it possible to compare and find the answer?

MISSING ICONS2.jpg

lionk

@aerilius said:

I could not reproduce the problem with the same toolbar names (工具栏, 正常, 具) after restarting SketchUp and opening the toolbar editor. I will continue try.

I updated the webdialog with improvements for higher dpi settings.

hi Aerilius,
maybe fredo6's methord can solve the UTF8 issue. fredo6's plugins show Chinese very well.

ely862me

What about these ones ?
toolbar editor plugin.jpg
toolbar editor plugin b.jpg

After choosing yes I get this :

toolbar editor plugin a.jpg

Aerilius

Are you sure you use the latest version?

ely862me

I installed it from the scf plugin store and I thought it was the last version but it was not, now it works !

Thank you !

TIG

@ely862me said:

I installed it from the scf plugin store and I thought it was the last version but it was not, now it works !
Andreas updated this toolset twice on the same day, so the second version was not automatically picked up... v1.0.6 will be added to the 'SketchUcation Plugin Store' shortly...