[Plugin] TIG-Smart_offset

driven

found it, a new 'finder. replacement doesn't update instantly... bin that
ok no errors. menu cmd works, context cmd work, toolbar cmd dosen't do anything

It works if I split if the validation proc
cmd2=UI::Command.new('TIG.Smart_offset'){self.dialog()} cmd2.small_icon=File.join(dir, 'TIG-Smart_offset.png') cmd2.large_icon=File.join(dir, 'TIG-Smart_offset.png') toolbar=UI::Toolbar.new('TIG.Smart_offset') toolbar.add_item(cmd2)

john

Mistro11

You have no idea how many times I got frustrated doing an offset and have to get in there and clean up the shape. Thanks TIG!

jeff hammond

i'm all greyed out (on two separate computers with different OS & different versions of sketchup on them).. will investigate more tomorrow

(skindigo toolbar as reference to what the blue/blacks should look like)

notareal

Merry Christmas to you too!

Jim

in cmd.set_validation_proc (and other places) you want to give the full scope of the suitable? method since it is being called from SketchUp outside the scope of your module.

Also, combine the MF_ bits.


cmd=UI;;Command.new('TIG.Smart_offset'){self.dialog()}
if TIG;;Smart_offsetter.suitable?()
MF_ENABLED
else
MF_DISABLED | MF_GRAYED
end

cotty

Nice gift! Thank you and Merry Christmas! (Are we allowed to use it before 24.12.?)

pilou

Yeeeeeeees! Works like a charm now!
You are the Ruby's king!

And lucky because I can't more test your tricky plugin before the next year!

TIG

@jim said:

in cmd.set_validation_proc (and other places) you want to give the full scope of the suitable? method since it is being called from SketchUp outside the scope of your module.

Also, combine the MF_ bits.


> cmd=UI;;Command.new('TIG.Smart_offset'){self.dialog()}
> if TIG;;Smart_offsetter.suitable?()
> MF_ENABLED
> else
> MF_DISABLED | MF_GRAYED
> end
>

Thanks, knew it was obvious... This only affected MACs though ???
This was collecting dust on a virtual dust, until Pilou reminded me that I'd written it, so sometimes things get 'forgotten'...

TIG

Here's v1.2 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
Further robustness in enabling/disabling/graying and suitable? tests [thanks to Jim!].
Seems to be especially for MACs

Jim

@tig said:

This only affected MACs though ???

I am not sure - it was just a guess and I don't have a Mac. Did you try it?

TIG

I don't have a MAC either.
Driven's reported issue was on a MAC and Jeff had other issues on a MAC too...
Hopefully this recent v1.2 [...20121221b.rbz !] will address the suitable? check and MF_ issues with the menus/toolbar...
It still works fine on a PC, but then v1.1 did too

elmer

Nice Christmas gift Tig, thanks a lot, it works perfectly on my Mac.

alvis

Thanx TIG

guanjin

@tig said:

Here's v1.2 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
Further robustness in enabling/disabling/graying and suitable? tests [thanks to Jim!].
Seems to be especially for MACs

TIG: Merry Christmas

jeff hammond

@tig said:

Here's v1.2 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
Further robustness in enabling/disabling/graying and suitable? tests [thanks to Jim!].
Seems to be especially for MACs

Hi Tig
i'm still getting the same greyed out problem.
is there anything i can type in the console or ?? to help figure out what the problem is?
thanks

TIG

Is there no difference at all - if you have nothing preselected, or one edge preselected, or one face preselected, or lots of things [including some edges] preselected ?
The menu/toolbar are only enabled if there's at least one face in the current selection.
The context-menu only appears if there's at least one face in the current selection.

Copy/paste+<enter> these into the Ruby Console and report the results:

with nothing preselected TIG::Smart_offsetter.suitable?()
with one edge preselected TIG::Smart_offsetter.suitable?()
with one face preselected TIG::Smart_offsetter.suitable?()
with lots of things [including some edges] preselected TIG::Smart_offsetter.suitable?()

with one edge preselected TIG::Smart_offsetter.dialog()
with one face preselected TIG::Smart_offsetter.dialog()

jeff hammond

oops
it actually is working now..
it's just the toolbar that remains greyed out at all times but the menu item becomes available once an appropriate selection has been made..

(which, for me personally, is fine.. i more likely than not wont want the toolbar anyway.. i think id use it with a modifier key added to my offset shortcut)

jeff hammond

here are these results.. (since you took the time to write them.. i better take the time to report )

@tig said:

Copy/paste+<enter> these into the Ruby Console and report the results:

with nothing preselected TIG::Smart_offsetter.suitable?()
false

with one edge preselected TIG::Smart_offsetter.suitable?()
false

with one face preselected TIG::Smart_offsetter.suitable?()
true

with lots of things [including some edges] preselected TIG::Smart_offsetter.suitable?()
true (drew two squares and selected all)

with one edge preselected TIG::Smart_offsetter.dialog()
warning- PreSelect Face[s !]
ruby - nil

with one face preselected TIG::Smart_offsetter.dialog()
(works as expected)

jeff hammond

uh.. not sure what the deal is but..

upon entering all of that stuff in the console, the toolbar is now working

[edit] but then.. i quit sketchup then relaunched and the toolbar is greyed out again regardless of selection.. the menu item is working though

Chris Fullmer

voodoo. definitely voodoo at work here.