[Plugin] CleanUp

thomthom · 18 Mar 2010, 09:46

I tried to lock such faces with positioned materials but the script erases lines in locked groups, too!

That's interesting. Another thing to note down.

thomthom · 23 Apr 2010, 21:41

Armed with more info from Simone Nicolo I now have a better method for detecting coplanar faces - the same method Sketchup use. I think it's 100% reliable. No more messing about with tolerances.

Highly recommended update!

thomthom · 23 Apr 2010, 21:57

@thomthom said:

Armed with more info from Simone Nicolo I now have a better method for detecting coplanar faces - the same method Sketchup use. I think it's 100% reliable. No more messing about with tolerances.

Highly recommended update!

Turns out it's not 100%. In one of my test model it still left some edges that could be erased.

Updated with some minor UI fixes.

EscapeArtist · 23 Apr 2010, 21:58

"The selected attachment does not exist anymore"

Error when clicking for download.

thomthom · 23 Apr 2010, 22:06

@escapeartist said:

"The selected attachment does not exist anymore"

Error when clicking for download.

You probably tried to download just as I uploaded a quick patch.

CadFather · 23 Apr 2010, 22:09

Thanks Thom, this is good.

EscapeArtist · 24 Apr 2010, 03:00

@thomthom said:

You probably tried to download just as I uploaded a quick patch.

Ah, timing is everything. Works just fine. Thanks!

MtnTrails · 24 Apr 2010, 05:46

Thank you, Thom! Works just like I'd hoped. What a great time saver!

Gaieus · 24 Apr 2010, 07:52

Hi Thom,

Thanks for the update. I'll definitely try it out (I managed to forget about two coplanar faces with differently positioned but the same texture again and screwed up my model - no big hassle though just a "doh" moment again...)

thomthom · 24 Apr 2010, 09:57

@gaieus said:

Hi Thom,

Thanks for the update. I'll definitely try it out (I managed to forget about two coplanar faces with differently positioned but the same texture again and screwed up my model - no big hassle though just a "doh" moment again...)

Ah yes - I'm still not sure how to account for that. But it is possible ... somehow...

Rich O Brien · 24 Apr 2010, 10:03

Hi Thom,

Thanks for the update, one of my favourite plugins.
Doesnt say much about my modelling ability!

thomthom · 24 Apr 2010, 15:10

Important update in 1.2.2
Sorry for all these updates recently.
I think I found the root of why the last update wasn't 100%.

It now erases edges as they are processes, instead of in bulk later. This is because each face's plane equations must be re-evaluated after it's been merged. This might lead to slightly longer processing time - but I now hope that it truly is 100% watertight.

EarthMover · 24 Apr 2010, 18:39

Thanks for the update. I use this puppy all the time!

Jim · 25 Apr 2010, 14:07

Thanks - it is doing better job of removing edges. I am willing to trade a little extra time for a cleaner model.

I did get a reference to a deleted Edge error on this model (.stl import.) I haven't investigated the cause, but I've attached it in case you're curious.

Error: #<TypeError: reference to deleted Edge> C:\Program Files\Google\Google SketchUp 7\Plugins\tt_cleanup.rb:283:infaces'`

My fix:
283: next unless e.valid? and e.is_a?(Sketchup::Edge)

But is doesn't explain the cause.

moai.skp

thomthom · 25 Apr 2010, 15:09

hm.. that is odd. I wonder why that happens. thanks for posting the model.

thomthom · 25 Apr 2010, 17:14

Updated to account for the issue reported by Jim.

Though I still don't understand why I ever get a reference to a deleted edge...

TIG · 25 Apr 2010, 20:14

Trap unexpected deleted edges with edge.erase! if edge.valid? type of code ?

thomthom · 25 Apr 2010, 20:55

Yes - but what puzzles me is why the code comes across deleted references at all. After reviewing my code I can't work out why. I am iterating an array copy of the entities collection. And I only iterate the array once.

thomthom · 26 Apr 2010, 21:51

Gaieus: This update is for you. Made it investigate the UV's before merging.
Not that it is very strict, the UV values for either vertex of the edge has to be identical for each face connected to it before it merges. This means there might be cases where it visually looks like they should merge, but doesn't. They should merge is you position a material on one face and use the dropper to paint other adjacent faces.
To turn of this feature just enable the Ignore UV's.

Note that this is pretty fresh code that hasn't been tested well. (Only very quickly.) So please investigate the model after using the tool and report any unexpected behaviour. (Please most sample model as that will make debugging much easier.)

Ern · 27 Apr 2010, 01:30

Very handy,