[Plugin] Layers Panel 1.2.1

jiminy-billy-bob · 2 Nov 2013, 23:43

Nope, no new file, just updated ones. And restarting SU does not solve this...

Rich O Brien · 2 Nov 2013, 23:46

YEs, I restarted 6 times and still error occured.

I needed to remove and install fresh.

But there is something funky going on with Layers Panel for me for a while. It needs gets listed as needing an update in My Plugins and I could never figure out why.

Great plugin BTW. I ain't knocking it just doing some investigation while I have some time

TIG · 3 Nov 2013, 00:12

If you manually remove all of the plugin's subfolder-of-support files and the lone loader .rb... then re-auto-install it is there still the error ?

If so something is wrong in the files/archives - the error message tells you that some js code is adrift ??

Your newly install script needs to tidy up after itself IF there are file changes...

As a 'trusted author'... Are you really sure that you are properly making the two files needed for inclusion in the PluginStore database - the RBZ for the page and then the 'second-format' needed for the in-SketchUp dialog etc ??
What ZIP program are you using to make the ZIP you are renaming as RBZ ?
Are you using definitely v8 to process the RBZ into the 'second-format' and NOT v2013 ? OR if it has to be made in v2013 are you remembering to do a Save_as to v8, to keep it compatible with earlier versions...

I suspect this might be the core issue - i.e. archives from an author who fails to provide the dialog-version in the required v8 compatible format ! The server-side database built-in version-checker for the 'second-format' ought to trap this, so it is disallowed... but it might be failing ??
Gábor
Comments need asap - an author should NOT be able to upload incorrectly versioned 'second-format' archives to the PluginStore - they must all be v8.

Please all reread the Author's Guide sticky in the special forum if you are in any doubt as to what you must do...

jiminy-billy-bob · 3 Nov 2013, 00:20

@tig said:

If you manually remove all of the plugin's subfolder-of-support files and the lone loader .rb... then re-auto-install it is there still the error ?

Nope, no error after a clean install.

@tig said:

js code is adrift ??

In this case it's JS, but some time ago I had the same issue with the main CSS file.

@tig said:

Your newly install script needs to tidy up after itself IF there are file changes...

How can I detect it has been updated ?

@tig said:

As a 'trusted author'... Are you really sure that you are properly making the two files needed for inclusion in the PluginStore database - the RBZ for the page and then the 'second-format' needed for the in-SketchUp dialog etc ??

Yes

@tig said:

What ZIP program are you using to make the ZIP you are renaming as RBZ ?

Windows Explorer

@tig said:

Are you using definitely v8 to process the RBZ into the 'second-format' and NOT v2013 ?

Yes

TIG · 3 Nov 2013, 00:34

You don't need to detect if a file has been updated.
All files in the RBZ or second-format are extract and overwrite any preexisting files.

The problem comes if you have some files from an older version that are not included in the newest installation.
Now they a left behind in the subfolder and might still load if you globally 'require' or 'load' files, or the html etc is still referring to them [you might have removed them but the user hasn't] - iin that case adjust the current code too.

If you know that some files are obsolete then your loader rb file' code needs to check for their existence - make an array of their subfolder_location/names: then use:
File.exist?(obsolete_file)
If it does then
File.delete(obsolete_file)
AND increment a counter.
If the counter!=0 then you need to popup a message that old-legacy files have been deleted and SketchUp needs to restart to complete the new installation. Otherwise the older files code is still loaded and will often break your new installation OR SketchUp itself...

Bob James · 3 Nov 2013, 00:36

I had the same problem(s). Turns out that the new version is called jb_layers_panel and jb_layers_panel.rb whereas the previous version did not have the "jb".
I unloaded the new version, deleted the old version, and restarted SU.
SU immediately crashed
Restarted SU and loaded in a model.
Worked okay except

The saved options where not in effect.
Still got the unexpected ')' error and had to click four times "yes" before it went away. When I did that the saved options took effect.

I tried it the other way around: loaded SU (no error), then opened a model. The Layers Panel filled out but the options were wrong and I got the error message and had to click yes four times to make it go away.

It clearly has something to do with the options.

I could implement all of the new functions.

I can resize the dialog, but "Added a dark bar at the top to minimize/maximize the dialog" is not there

Bob James · 3 Nov 2013, 00:43

If you click Ctrl-Z while in the panel you get the same error

TIG · 3 Nov 2013, 00:50

In that case == BIG mess up.

If you have 'layer_panel' as your plugin name and others have installed it before then issuing a new version called 'jbb_layer_panel' is regarded as another tool.
ALL of the legacy files for the old version continue to load their old code in tandem with you new version - causing inevitable clashes when similar module/methods are called...
When you decide to rename a plugin it cannot be entered into lightly.
Your new version must find and delete all earlier versions that are using the older name, these will NOT get overwritten by an auto-install and load and mess things up...
Also consider that an .rb file in the Plugins folder might have been 'managed' or 'uninstalled' so you need to look for say layer_panel.rb and layer_panel.rb! and layer_panel.rbx files in case they exist !!!
The files in the 'layer_panel' subfolder need deleting and then the folder removing, you cannot [easily] delete a folder that currently contains files...

If this is the cause of this issue I suggest you immediately 'unpublish' the plugin and we agree a strategy for a new version to correct the legacy issue files/folder, and advise current users to at least disable ALL versions they have installed.

Bob James · 3 Nov 2013, 00:51

@unknownuser said:

Added different color for groups

Thank you! But the difference in the light grays is not very discernible.

If you move a group with all the layers showing, after moving the layers are no longer showing, but the arrow is still down. You have to click on the down arrow (which opens up the layers) and then click the arrow again to collapse the layers.

Bob James · 3 Nov 2013, 00:58

Aha!! I found the "dark bar": I thought it was just part of the outline.

A little wider might help. It's okay once you know it, but not too obvious to begin with.

Please accept these comments as critique of a GREAT plugin, not criticism.

jiminy-billy-bob · 3 Nov 2013, 01:07

There are no obsolete files. And the plugin already takes care of the old versions with different names. What can remain are the old folders, but that's not a problem since no rb file access these folders. It's been a while since that, and nobody never had any issue.

Bob , you actually have a different issue than Rich. I'll look into that.

Bob James · 3 Nov 2013, 01:16

The folder version called "layers_panel" was downloaded on 14 Oct 2013.
I also had a "jbb_layers_panel" folder with the same download date.

The "layers_panel" version started out:

%(#FF0040)[#-----------------------------------------------------------------------------
require 'sketchup.rb'
require 'jbb_layers_panel/Win32API.so'
#-----------------------------------------------------------------------------

Sketchup.send_action(CMD_RUBY_CONSOLE)

module JBB_LayersPanel]

and the rb was dated 9 Sep 2013

In the "jbb_layers_panel" version the rb is dated 16 Sep 2013
UPDATE
As jiminy said, in both cases the rb was called "layers_panel.rb". It was only the folder names that were different

I'm verysorry if my ignorance caused a problem

huckrorick · 3 Nov 2013, 04:57

I downloaded version .7
As soon as I clicked on the Layer Panel I get an error message. (see attachment)
When I try to add a layer with Layer Panel it doesn't respond.
When I add with the Layers window I get an error message.
What am I doing wrong?

TIG · 3 Nov 2013, 10:05

@jbb

I notice that your html files do not define 'scripts' in the 'header' but at the end of the 'body'... is this an issue?
Also your main html file doesn't include:
<script src="./js/jquery.min.js"></script>
Is this likely to cause an issue ?
After all the error relates to JQuery...

jiminy-billy-bob · 3 Nov 2013, 11:44

Maybe you mods/admins guys could move these posts to a new thread in the devs forum ?

@bob james said:

As jiminy said, in both cases the rb was called "layers_panel.rb". It was only the folder names that were different

Let's sum it up.

Alpha version until 0.02, May 15th 2013 :

Plugins/Layers Panel.rb
Plugins/Layers Panel/...

From Alpha version 0.03 to Beta version 0.3.1, Sept 9th 2013 :

Plugins/layers_panel.rb
Plugins/layers_panel/...

Since Beta version 0.3.2, Sept 16th 2013 : (For compatibility with the Extension Warhouse)

Plugins/jbb_layers_panel.rb
Plugins/jbb_layers_panel/...

When this one loads, it automatically deletes Layers Panel.rb and layers_panel.rb
"J" being loaded before "L", the two old files never get loaded before they are deleted.

Ok so, I can reproduce the issue by reverting back to 0.6 and trying to update through the PS or the default rbz installer inside SU. Both fail to update the "js" folder, in both SU8 and SU13. Therefore, some new JS files don't get added, and we get the JS error.
This. Is. Weird.
Actually, the "css" folder is not updated either...
The two sub-folders of Plugins/jbb_layers_panel/

Here is version 0.6 if you want to test :
Layers Panel 0.6 beta (Obsolete)

@tig said:

I notice that your html files do not define 'scripts' in the 'header' but at the end of the 'body'... is this an issue?
Also your main html file doesn't include:
<script src="./js/jquery.min.js"></script>
Is this likely to cause an issue ?
After all the error relates to JQuery...

No, the fact that the scripts are at the bottom shouldn't cause any issue. It certainly didn't in the past.
0.7 doesn't include jquery.min.js because it includes jquery.js, which is not added due to the "js" folder not being updated...

jiminy-billy-bob · 3 Nov 2013, 16:05

There is no issue when updated while Layers Panel is disabled (Through the Sketchucation Extension Manager, or SU's preferences window)
So I guess the problematic files are not replaced because Windows sees them as used.
What is even weirder is that some pre-non-existent files are not added.

jiminy-billy-bob · 3 Nov 2013, 16:05

@huckrorick said:

I downloaded version .7
As soon as I clicked on the Layer Panel I get an error message. (see attachment)
When I try to add a layer with Layer Panel it doesn't respond.
When I add with the Layers window I get an error message.
What am I doing wrong?

You need a clean install of the plugin.
Go to C:\Program Files (x86)\Google\Google SketchUp 8\Plugins\, and delete the file jbb_layers_panel.rb, and the folder jbb_layers_panel.
Then you can reinstall it normally.

EDIT : See the post below, you can just disable the extension before updating.

huckrorick · 3 Nov 2013, 18:00

deleting the folder and file, then installing worked fine.
Very nice the way the program is working now.
thanks.

monmonred · 7 Nov 2013, 20:49

i have a few more ideas for your plugin. please don't think i'm being demanding, you see i just found your plugin really helpful. anyway, these are my ideas. i don't know if they are really doable as far as rubyscript and your time/effort goes.

linked layers. (since you gave the idea of being photoshop-like) 2 or more layers can be linked and even if just one of them is selected and the hid/show is toggled (by clicking a button or the hot key)simultaneously they are shown/hid. multiple linking may be done. with this, you do not only have the capability to group folders and hide/show them by hiding or showing the eye icon (or the possible hotkey) you can also get the hide/show to work with ungrouped/unfoldered layers!
single-clicking/hover changes on a layer. this gives the function of hovering over a layer name to not change the mouse pointer to a pointer for typing. also when you click the layer name, what happens is you get to select the layer and you do not have to aim precisely at a point in the layer strip to have the layer selected. however, a double-click on the layer strip still renames the layer:)
font size change. i noticed the original layers panel can hold a longer list of layers as it has a smaller font size. is it possible to get your layers panel closer to that too so it would be easier to view the list without scrolling for those who tend to make 50+ layers?

anyway, i enjoy plugin and it helps so much, when i start earning after i graduate, i promise i'll donate for this plugin's awesomeness! thanks again, you are very helpful, jiminy!

jiminy-billy-bob · 7 Nov 2013, 21:21

Thanks for the kind words It's always nice to hear

@monmonred said:

linked layers. (since you gave the idea of being photoshop-like) 2 or more layers can be linked and even if just one of them is selected and the hid/show is toggled (by clicking a button or the hot key)simultaneously they are shown/hid.

It's not the way linking works in PS (at least not in CS6), but why not. But I always thought it was the whole point of being able to group layers.
Added to my todo list.

@monmonred said:

single-clicking/hover changes on a layer. this gives the function of hovering over a layer name to not change the mouse pointer to a pointer for typing. also when you click the layer name, what happens is you get to select the layer and you do not have to aim precisely at a point in the layer strip to have the layer selected. however, a double-click on the layer strip still renames the layer:)

I'll look into this. I can think of a couple of issues, but there are probably workarounds.

@monmonred said:

font size change. i noticed the original layers panel can hold a longer list of layers as it has a smaller font size. is it possible to get your layers panel closer to that too so it would be easier to view the list without scrolling for those who tend to make 50+ layers?

Actually, the height is driven by the input field size, I can't seem to find a way to make it smaller. It seems CSS-support of IE doesn't allow this. Maybe if someone finds a way to do this...