[Plugin] DrawHelix14

TIG

Yes you must enter an "Integer" number
So cut your volume at the end of the process

Make 3 turns and cut at the middle

It's easily fixed by adjusting the code in the .rb file... on line #23 [edit with Notepad.exe or equivalent plain-text editor - NOT a wrodprocessor]
change
values = [300.mm, 300.mm, 100.mm, 5, 24]
into
values = [300.mm, 300.mm, 100.mm, 5.0, 24]
then save.
Now you can enter decimal values like 1.5 ...
The original code froze it as an 'integer' [default=5] and therefore prevented 'partial turn' values being entered... BUT since the rest of the code doesn't rely on it being an 'integer' there's no problems with making it a 'float'...
I already had that tweaked in the previous version in my installation...

pilou

Better and more generalist indeed
And always amazing as just 2 signs can change something!

We are few things in the univers, all is inside decimals

By Francesco de Comité

pilou

@ TIG
I am in V6
Curious
I have an old version Draw Helix 13
make your 5.0 changment inside : works fine

I load the new DrawHelix14
nothing is drawing (same result with your changment)
I have this in the Ruby console

Error; #<ArgumentError; wrong number of arguments(2 for 1)>
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;68;in `start_operation'
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;68;in `drawhelix'
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;78
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;78;in `call'

simon le bon

@tig said:

It's easily fixed by adjusting the code in the .rb file... on line #23 [edit with Notepad.exe or equivalent plain-text editor - NOT a wrodprocessor]
change
values = [300.mm, 300.mm, 100.mm, 5, 24]
into
values = [300.mm, 300.mm, 100.mm, 5.0, 24]
then save.
Now you can enter decimal values like 1.5 ...

I'm very proud to annouce that this

.0

added, is my very first rubby scripting (and may be also the last )
And then Oh! the problems begin

1)With or without this new code, I discover that DrawHelix14 doesn't work with my Su6
2)DrawHelix14 works fine with my Su7 but the new code (

.0

) doesn't work! (if a decimal value is entered, no helix is drawn_ if an Integer value is entered: works fine)
3)If I come back in Su6 to DawHelix13_fr and add the (

.0

)code, this time the helix is drawn.

4.5 rotations

Ouf! Hard time for new developper

simon

derei

can't you filter that ? the script to catch the vcb value and remove the leading zero in incompatible version of SU ?

TIG

@unknownuser said:

@ TIG
I am in V6
Curious
I have an old version Draw Helix 13
make your 5.0 changment inside : works fine

I load the new DrawHelix14
nothing is drawing (same result with your changment)
I have this in the Ruby console

Error; #<ArgumentError; wrong number of arguments(2 for 1)>
> C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;68;in `start_operation'
> C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;68;in `drawhelix'
> C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;78
> C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;78;in `call'

Line #65
if Sketchup.version_number.to_i < 7
changed to
if Sketchup.version.to_i < 7
will work in SUp v6 too !
Simple typo by Jim meant that you always got a version number in the tens of thousands and not a simple 6, 7 or 8 etc so it would always be > 7 and then try to start_operation with an extra argument and break the tool

pilou

Cool to see that is the same problem

PS It's the same for the New Double Line!
Don't work inside the V6
When press Enter walls are not drawn !

same error message in the Ruby console

Error; #<ArgumentError; wrong number of arguments(2 for 1)>
C;/Program Files/Google/Google SketchUp 6/Plugins/dline2.rb;157;in `start_operation'
C;/Program Files/Google/Google SketchUp 6/Plugins/dline2.rb;157;in `onReturn'
C;/Program Files/Google/Google SketchUp 6/Plugins/dline2.rb;157

pilou

Works now for the Draw Helix 14 in the V6
but now it's your modification 5.0 who don't works in the Draw Helix 14 ! (V6)
I have that

values = [300.mm, 300.mm, 100.mm, 5.0, 24]

Error; #<ArgumentError; invalid value for Integer; "5.5">
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;31;in `inputbox'
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;31;in `drawhelix'
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;78
C;/Program Files/Google/Google SketchUp 6/Plugins/drawhelix14.rb;78;in `call'

TIG

OK looks like float and string clash ?
I assume the edited line #23 is clearly values = [300.mm, 300.mm, 100.mm, 5.0, 24] with no string delimter "" or '' around anything...
Perhaps your JLF::DrawHelix Registry entry is screwed or locked on the last used 'intger' values?
You could delete it...
BUT unless you are confident about messing around within a PC's Registry and risking disaster... then I suggest this safer fix...
Temporarily disable reading the Registry - go to line #24
v = Sketchup.read_default(reg_key, "values")
and add a leading # so it doesn't load at all
#v = Sketchup.read_default(reg_key, "values")
If you get an error also add a temporary line after it
v=nil
Run the tool once and close SUp, then remove that # etc from the .rb and retry - it should now be using the last entered values you used which are 'float'...

Also - in passing I now note that in line #36 there is
angle = 2*3.14159/sections
it would be better as
angle = 360.degrees/sections
as the over approximated value of 'pi' could produce minor inaccuracies otherwise...

Jim

Thanks. I've made the changes and updated the download. The version works on SketchUp 6, 7, and 8 for me.

TIG

Thinking about the earlier registry entry potentially messing integer and float, to be on the safe side you could add this

        unless v.nil?
            values = eval(v)
            values[0] = values[0].to_l
            values[1] = values[1].to_l
            values[2] = values[2].to_l
            values[3] = values[3].to_f
            values[4] = values[4].to_i
        end

so that older values' classes are always correctly set?

Jim

Had the same thought... thanks.

pilou

Ok now that works like a charm in V6!
Bravo!
And sorry for the inconvenience

simon le bon

Ok now that works like a charm in V6!
Bravo!

(it is better if I don't touch even one line of code )

simon

mitcorb

Hi:
I tried to use DrawHelix14 last night in SU7 and on opening the program I got a load error.
Text file copy of the error message:
Error Loading File drawhelix14.rb
C:/Program Files/Google/Google SketchUp 7/Plugins/drawhelix14.rb:1: syntax error
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
^
C:/Program Files/Google/Google SketchUp 7/Plugins/drawhelix14.rb:2: syntax error
<html xmlns="http://www.w3.org/1999/xhtml">
^
C:/Program Files/Google/Google SketchUp 7/Plugins/drawhelix14.rb:3: syntax error
<head>
^
C:/Program Files/Google/Google SketchUp 7/Plugins/drawhelix14.rb:5: syntax error
<title xmlns="http://www.google.com/ns/jotspot">Download Attachment</title>
^
C:/Program Files/Google/Google SketchUp 7/Plugins/drawhelix14.rb:6: syntax error
<style xmlns="http://www.google.com/ns/jotspot">
^
C:/Program Files/Google/Google SketchUp 7/Plugins/drawhelix14.rb:19: syntax error
content: ".";
^
C:/Program Files/Google/Google SketchUp 7/Plugins/drawhelix14.rb:70: syntax error
<body xmlns="http://www.google.com/ns/jotspot">
^
I probably did something wrong. I do have version 1.3

Jim

When you go to download the file, right-click the link and select Save As, or Save Target As.

The file you posted in the error is an html page - probably has the script embedded in it somewhere, but your browser doesn't know what to do with .rb files.

mitcorb

Thanks Jim for your quick reply.
That is what I thought. As many plugins as I have downloaded and given others the same advice as yours, you'd think I would know better.
I think I am divesting myself of good sense daily.

Jim

@mitcorb said:

I think I am divesting myself of good sense daily.

I understand, believe me.

mitcorb

Well, Jim:
I don't know why but I keep getting the HTML file, even on this work computer. Same browser, though--Firefox. I will keep trying.

Dave R

@mitcorb said:

Well, Jim:
I don't know why but I keep getting the HTML file, even on this work computer. Same browser, though--Firefox. I will keep trying.

I tried downloading the rb file today and got this in the file.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="X-UA-Compatible" content="chrome=1" />

<title xmlns="http://www.google.com/ns/jotspot">Download Attachment</title>
<style xmlns="http://www.google.com/ns/jotspot">
          html, body {
            padding; 0;
            margin; 0;
          }
          body {
            font-family; Arial, Verdana, sans-serif;
            font-size; 12px;
            background-color; #fff;
            background-image; none;
            direction; ltr;
          }
          .sites-clear;after {
            content; ".";
            display; block;
            height; 0;
            clear; both;
            visibility; hidden;
          }
          #sites-header {
            background-color; #fff;
            border-bottom; 1px solid #b0bdcc;
            height; 1%;
            padding; 5px 5px 0 0;
            margin-bottom; 10px;
          }
          .sites-account {
            float; right;
            font-size; 12px;
            padding; 4px 8px 5px;
          }
          .sites-account a {
            color; #4e7dbf; /* onebarLinkColor */
          }
          .sites-content-wrapper {
            min-height; 150px;
            margin; 0 5px;
            _height; 150px !important;
            padding; 5px;
          }
          h2 {
            margin; 5px 0 10px;
            font-size; 22px;
          }
          p {
            margin-top; 0px;
          }
          .sites-subfooter {
            font-size; 11px;
            padding; 5px 0 5px;
            text-align; center;
          }
          .sites-subfooter p {
            margin; 0;
            padding; 5px;
          }
          .sites-subfooter p span {
            font-size; 10px;
          }
          #sites-logo {
            margin-bottom; 15px;
          }
        </style>
</head>
<body xmlns="http://www.google.com/ns/jotspot">
<div id="sites-status" class="sites-status" style="display;none;">
<div id="sites-notice" class="sites-notice"> </div>
</div>
<div class="sites-content-wrapper">
<img xmlns="http://www.w3.org/1999/xhtml" src="http://www.gstatic.com/sites/p/544341/system/app/images/logo/logo.gif" id="sites-logo" alt="Google Sites Logo" />
<h2>Download Attachment</h2>
<p xmlns="http://www.w3.org/1999/xhtml">
        Click <a href="/site/jimfoltz/sketchup/my-sketchup-plugins/drawhelix/drawhelix14.rb?attredirects=0">here</a> to download your attachment.
        </p>
</div>
</body>
</html>