[Plugin] Make Fur v.2.1.0(20140323)

[pilou]

@unknownuser said:

This code only checks for FR Sketchup locale.

And when French user uses directly FR Locale "." (modified) whith English SU version seems there is no problem?

[tak2hata]

Hi, All.
I update this to v1.3e.
Thomas,Thank you very very much!
At last, I also understood.
I use your code "decimal_sep = 1.2.to_l.to_s.match(/\d(\D)\d/)[1]".
and model.options["UnitsOptions"]["LengthUnit"] >= 2 then unit is metric.
It not depend to Sketchup locale.

I think that this is perhaps no problem.
please reply when there is a problem.

Thanks

[thomthom]

@tak2hata said:

I use your code "decimal_sep = 1.2.to_l.to_s.match(/\d(\D)\d/)[1]".
and model.options["UnitsOptions"]["LengthUnit"] >= 2 then unit is metric.
It not depend to Sketchup locale.

I think that this is perhaps no problem.
please reply when there is a problem.

I think that should work.

[thomthom]

Oh - you posted update already! I see. I'll try it out then.

[thomthom]

1.3e not working for me.

Error: #<NoMethodError: undefined method[]' for nil:NilClass>
C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:734:in fur_dialog_ini' C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:741:in fur_webdialog'
C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:1414
C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:1413:in call'

[TIG]

With 1.3e I get Error: #<TypeError: no implicit conversion to float from nil> C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:1326:ininitialize'
C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:1326:in new' C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:1326:in s_to_vec'
C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:713:in show_webdialog' C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:658:in call'`
with the 'web-dialog' accept button.
You must be passing an empty argument to a defn ?

[tak2hata]

@thomthom said:

1.3e not working for me.

Error: #<NoMethodError: undefined method[]' for nil:NilClass>
C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:734:in fur_dialog_ini' C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:741:in fur_webdialog'
C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:1414
C:/Program Files (x86)/Google/Google SketchUp 7/Plugins/fur_en.rb:1413:in call'

I think this is LengthFormat or LengthPrecision problem.
So I will change code..

def fur_dialog_ini
	unitoptions = Hash.new
	Sketchup.active_model.options["UnitsOptions"].each{|key ,val| unitoptions[key] = val }
	Sketchup.active_model.options["UnitsOptions"]["LengthFormat"] = 0 if unitoptions["LengthFormat"] != 0
	Sketchup.active_model.options["UnitsOptions"]["LengthPrecision"] = 1 if unitoptions["LengthPrecision"] == 0
	@fur_units_metric = false
	lunit = unitoptions["LengthUnit"]
	@fur_units_metric = true if lunit >= 2
	lprec = Sketchup.active_model.options["UnitsOptions"]["LengthPrecision"]
	@decimal_sep = 1.2.to_l.to_s.match(/\d(\D)\d/)[1]
	@delim = ","
	@delim = ";" if @decimal_sep == ','
	unitoptions.each{|key ,val| Sketchup.active_model.options["UnitsOptions"][key] = val }
end

@tig said:

With 1.3e I get Error: #<TypeError: no implicit conversion to float from nil> C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:1326:ininitialize'
C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:1326:in new' C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:1326:in s_to_vec'
C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:713:in show_webdialog' C:/Program Files/Google/Google SketchUp 7/Plugins/fur_en.rb:658:in call'`
with the 'web-dialog' accept button.
You must be passing an empty argument to a defn ?

Sorry,I will change the code.

[thomthom]

Why are you doing this?

Sketchup.active_model.options["UnitsOptions"].each{|key ,val| unitoptions[key] = val } Sketchup.active_model.options["UnitsOptions"]["LengthFormat"] = 0 if unitoptions["LengthFormat"] != 0 Sketchup.active_model.options["UnitsOptions"]["LengthPrecision"] = 1 if unitoptions["LengthPrecision"] == 0

You're changing the model settings.

[thomthom]

This whole thing makes no sense...

    def fur_dialog_ini
       unitoptions = Hash.new
       Sketchup.active_model.options["UnitsOptions"].each{|key ,val| unitoptions[key] = val }
       Sketchup.active_model.options["UnitsOptions"]["LengthFormat"] = 0 if unitoptions["LengthFormat"] != 0
       Sketchup.active_model.options["UnitsOptions"]["LengthPrecision"] = 1 if unitoptions["LengthPrecision"] == 0
       @fur_units_metric = false
       lunit = unitoptions["LengthUnit"]
       @fur_units_metric = true if lunit >= 2
       lprec = Sketchup.active_model.options["UnitsOptions"]["LengthPrecision"]
       @decimal_sep = 1.2.to_l.to_s.match(/\d(\D)\d/)[1]
       @delim = ","
       @delim = ";" if @decimal_sep == ','
       unitoptions.each{|key ,val| Sketchup.active_model.options["UnitsOptions"][key] = val }
    end

You create an hash to store model UnitOptions, then change them and then restore the original values...?

[thomthom]

From what I could understand, that method could be condensed to:

    
    def fur_dialog_ini
       units = Sketchup.active_model.options["UnitsOptions"]["LengthUnit"]
       @fur_units_metric = (units >= 2) # true if units are 2 or greater
       @decimal_sep = 1.2.to_l.to_s.match(/\d(\D)\d/)[1]
       @delim = (@decimal_sep == ',') ? ";" ; ","
    end

[tak2hata]

Hmmm,
When LengthFormat is Architectural or LengthPrecision = 0,
"1.2.to_l.to_s.match(/\d(\D)\d/)[1]" return error.

Is that problem excluding this?

[thomthom]

Ah, yes. I see the problem. ..hm... this needs some more thinking...

[thomthom]

Ok - turns out that you can't trust the SU methods to extract the decimal separator as model settings affects the length to string formatting. (Should have thought of that. )

Looking at there seems to mostly be just comma or period as decimal separator. At least if you make that assumption it will cover most.

So here is an alternative:

  def get_decimal_separator
    # If this raises an error the decimal separator is not '.'
    '1.2'.to_l
    return '.'
  rescue
    return ','
  end

  def fur_dialog_ini
    @decimal_sep ||= get_decimal_separator
    @delim ||= (@decimal_sep == ',') ? ";" ; ","
  end

This snippet makes some assumptions:
Only comma or period as decimal separator.
If the separator is a period then comma is used as list separator.
If the separator is a comma then ; is used as list separator.

The method is working out the decimal separator is by trial and error.

[jchau2007]

wow... keep it coming. Thanks.

[AcesHigh]

I thought of a very cool thing to do with this plugin... those xmas stuff that you put on Xmas trees, you know?? Well, actually this plugin also makes it easy to do the Xmas tree itself.

I am talking about this thing that goes around the tree

[Rich O Brien]

Is v1.3e working for others?

Nothing happens when i select it?

[EscapeArtist]

I did have some issues as well, didn't check the console though. I had a model I'd saved using the previous "make fur" revision and was attempting to use the plugin, nothing happened - dialogue wouldn't open. I opened a "new" scene (File > New) and then the plugin worked.

[tak2hata]

I update to version 1.3g.
Vector parameter split to 3 parameter each.
and I change preset file.
I think this vesion has problem yet.

For the time being, It going on my sketchup.
But very difficult for me to convert units.
and so tired.

Thanks.

[thomthom]

I appears to work. I'll see if I can get some time to have a better look at your script and see if I can help with the units.

[TIG]

it seems to work OK now BUT the dialog is getting too tall.
Can't you redo the web-dialog code so that some of the boxes are side-by-side - the XYZ ones could be in a line, so making it 3 input boxes wide, but with each a little narrower would be more manageable ?