[Plugin] Free Rotate 4.4

thomthom

[edit - tab works and zooms/cycles through errors but shift+tab does nothing]

hm... ok I made it use the combo of Tab and the constraint modifier key - so it'd be the one you use to lock inference...

EarthMover

Ken, I think you mean the TAB key is working for you? Just not the red axis? TAB works for me on PC - Vista.

jeff hammond

i somewhat found the thread about the problem with tab on mac..

i'm pretty sure fredo had a mac specific thread asking about this but i can't find it.

http://forums.sketchucation.com/viewtopic.php?p=128952#p128952

he was confused because he used 9 as he did with JPP, which works.. but it wasn't working with freescale.
maybe he'll see this thread.

TIG

After a flurry ... a recap...
TAB works with key code 9, 15?, 30??, 48??? - on PC and Mac ??

On the separate issue - I thought I'd trapped for all of the 'exactly axial' axis glitches - obviously NOT
That is fixable...
EDIT: simple typo that broke it - fixed... now waiting for Tab issue to resolve...

jeff hammond

@tig said:

After a flurry ... a recap...
TAB works with key code 9, 15?, 30??, 48??? - on PC and Mac ??

On the separate issue - I thought I'd trapped for all of the 'exactly axial' axis glitches - obviously NOT
That is fixable...

no, tab doesn't work with any of those numbers (on mac)

out of curiosity, i used 121 (for 'y'.. as i don't have anything assigned to that key in SU)
and it did work.. i was able to get into axial_rotate.

TIG

From some research...
TAB is keycode 9 on PC and MAC [or 0x09 hex] - i.e. ASCII.
With some locale keyboards TAB is keycode 15 [Thai?]
TAB is also 0x30 hex which is 48 in some locale keyboards [FR?] - as in [k]VK_Tab...

I'll trap for 9, 15 and 48 for now and reissue v4.1 will the axis glitch fixed...

TIG

Here's v4.1 http://forums.sketchucation.com/viewtopic.php?p=266561#p266561
A typo has been fixed with the Axis on the X_AXIS which glitched unexpectedly.
The 'Tab' press for MAC key code adjusted to 9, 15 and 48 to try and trap all platforms/locales.
Menu 'Windows > Instructor' help added...
[Note: this is [i]not working (yet) - so for now open ../FreeRotate/index.html in your web-browser untill this is fixed...][/i]

jeff hammond

sorry TIG.. tab key still not working in v4.1 on mac.

TIG

@unknownuser said:

sorry TIG.. tab key still not working in v4.1 on mac.

BUM!
ANY Mac user's getting it to work ??
I can't see why not... as it now accepts keycode 9, 15 or 48 as a TAB key press...
Any ideas, 'team' ?

jeff hammond

@tig said:

@unknownuser said:

sorry TIG.. tab key still not working in v4.1 on mac.

BUM!
I can't see why not as it now accepts keycode 9, 15 or 48 as the TAB key press...
Any ideas, 'team' ?

fwiw, i tried 2D tools tab key (which i haven't needed before) and i think it's broken also.

but yeah, i'm thinking it's something other than which # to use.. i've checked a few different scripts which have tab key functionality in them, which work, and they use 9

TIG

Jeff
I know 2D Tools uses the same code - I'll have to fix that when I know for sure what the problem is...

I've attached a short 'keycode' script.keycode.rb Can you put it into your Plugins folder and open a SKP.
In the Ruby Console type keycode and activate the main window and follow the simple instructions.
Press the 'Tab' key and report what keycode it says [on a PC it says '9'].
You can try pressing other non-shortcut 'modifier' keys to get there keycodes too.
As soon as you press a shortcut key it exits...

Thanks for your help.

PS: Change the tool's suffix to .rb.txt after testing so it no longer loads...

jeff hammond

here's a little variety pack

shift-- You Pressed Keycode = 131072
control-- 262144
option/alt-- 524288
command-- 1048576
return(enter)-- 13
Y -- 121
(shift)Y -- 89
I -- 105
down arrow -- 63233
left arrow -- 63234
/ -- 47

tab -- does nothing
?

jeff hammond

hey TIG

i did a little investigating and think i found what's causing the problem..

with keycode.rb, i changed line#9 to
def onKeyUp(key, repeat, flags, view) ..(instead of onKeyDown)
it's now returning 9 when i push the tab key

i was digging through some fredoscale v1 files and found a version where tab was broken on mac then found what it looks like after he fixed it..

broken:

#Handle key down events
def onKeyDown(key, rpt, flags, view)
	key = Traductor.check_key key, flags, false
	
	case key			
	when CONSTRAIN_MODIFIER_KEY		#Shift key Uniform vs. non-uniform
		@shift_down = true
		change_free_uniform()
		return
	when COPY_MODIFIER_KEY			#Ctrl key - Center vs. Opposite
		@ctrl_down = true
		change_from_center()
		return
	when 13
		return
	when 9							#TAB - Ask dimensions
		ask_dimensions() unless @post_validate
		return
	end
	@vcb_return = false

	#Function Key options
	return if check_function_key(key, rpt, flags, view)
	
	#trapping the arrow keys for imposed direction or plane
	unless @dragging
		vecdir = nil
		normal = nil
		[[VK_UP, Z_AXIS], [VK_RIGHT, X_AXIS], [VK_LEFT, Y_AXIS], [VK_DOWN, @NUL_AXIS]].each do |kv|
			if key == kv[0]
				vecdir = kv[1]
				break
			end
		end
		if vecdir && !already_in_box?(vecdir)
			@pk_vecdir = vecdir
			execute_by_mode view
		end	
	end	
end

fixed:

#Handle key up events
def onKeyUp(key, rpt, flags, view)
	key = Traductor.check_key key, flags, true
	
	case key			
	when CONSTRAIN_MODIFIER_KEY
		@shift_down = false
	when COPY_MODIFIER_KEY
		@ctrl_down = false
		onMouseMove 0, @x, @y, view if @x
	when 13
		execute_by_mode view unless @vcb_return
		@vcb_return = false
	when 9							#TAB - Ask dimensions
		ask_dimensions() unless @post_validate
	else
		@from_center = ! @from_center if @ctrl_down
	end	
end

(sorry, i don't know if i copy/pasted too much or too little of that script for it to be helpful ..but hopefully the answer is in there somewhere)

TIG

Please could you try changing your version of FreeRotate.rb.
from the TAB code being under
def **onKeyDown**(key, repeat, flags, view)
to it being under
def **onKeyUp**(key, repeat, flags, view)

if key==9 or key==15 or key==48 ### TAB =9 for PC, MAC 15/48 for some locales ?
      if @tab
        self.make_disk()if @state>2
        if @state==0
          @msg=@msgAXIALPIVOT
        elsif @state==1
          @msg=@msgAXIALAXIS
        else
          @state=2
          @msg=@msgAXIALHANDLE
        end#if
        @tab=false ### axial
      else
        self.make_globe()if @state>2
        if @state==0
          @msg=@msgFREEPIVOT
        elsif @state==1
          @msg=@msgFREEAXIS
        else
          @state=4
          @msg=@msgFREE
        end#if
        @tab=true ### free
      end#if
      view.invalidate if @ip.display? or @ip1.display?
    end#if

It's only in the one line, save and open a SKP...
Retry FreeRotate and see if the TAB key now works on your MAC and you toggle between 'Free' and 'Axial' modes...
Keep the Ruby Console open to see any errors etc...
For some reason TAB 'down' is plain flaky on the Mac - but perhaps TAB 'up' isn't !?
If it then works on the PC too I'll change it around... otherwise I'll do both - one test for PC one for MAC ...
I think we are getting near to a solution here...
Thanks for your help.

I'll issue an updated version soonest...

Then I need to fix ALL tools for MAC with the same issue...

PS: by the way here's a new version of keycode.rb that reports key-pressed and key-released events...keycode.rb

TIG

Here's v4.2 http://forums.sketchucation.com/viewtopic.php?p=266561#p266561
The glitch with 'Tab' [9] on MAC etc trapped by using 'key-up' not 'key-down' check
Don't know why... but it works...

mitcorb

FYI:
At least on my machine, the new zipped versions do not overwrite the original stand alone rb, so I did not see the toolbar icon, and I had two instances of FreeRotate in the Plugins dropdown menu. I simply deleted the original rb file in the SU7 plugins subfolder and restarted the program. The toolbar icon loaded and, I assume the old menu line disappeared.
Maybe this will help someone.

jeff hammond

@tig said:

Here's v4.2 http://forums.sketchucation.com/viewtopic.php?p=266561#p266561
The glitch with 'Tab' [9] on MAC etc trapped by using 'key-up' not 'key-down' check
Don't know why... but it works...

working now on mac..
i'll check 2d tools in a little bit.
thanks a ton.

[ed]- keycode.rb now returns 9 when releasing the tab key.. there's only one other key on my keyboard that exhibits the same behavior (no number on keydown) and that's the delete key 127

thomthom

Tab on OSX doesn't work on keyDown?

jeff hammond

@thomthom said:

Tab on OSX doesn't work on keyDown?

correct.
it appears to do absolutely nothing (in sketchup)

depending on my system prefs, keydown will either activate the VCB regardless of what tool i'm using or cycle through all of my toolbar icons. (ie- i can activate a tool via it's icon without mouse clicking it)

it's as if the system is keeping tab keydown for itself and won't allow it to be re-assigned

d12dozr

TIG, thanks for the plugin

Rich, thanks for the video