[Plugin] 2D Tools
-
I can't get it to crash at all it undoes just fine.
I tried all permutations I could think of - clicking the pairs of edges of the 4 corners in all of the permutations I could think of, deliberately mis-picking and missing an edge, then finding it etc etc.
That's a lot of times, >16 !
Every time it worked fine and undid without a mishap.
Can anyone else test this to see if they can break it ? -
I suppose I can make some kind of GIF or video of crashing. But I think it won't help much as you won't be able to get to the bottom of it?
Would it be better if i can send you the error log?
-
You ought to submit the Bugsplat to SketchUp.
Explain the background and what happens.The error-log is somewhat arcane...
E.G. It might be a clash with another loaded script having a flaky entities observer etc...
Can I suggest you also try this...
Use the SketchUcation Plugins Manager to make a Set of your current set up [blue button], so it's easy to revert later.
Then select all of the listed Plugins, except 2d tools and the shipped-extensions "su_..." ones - which will get reinstalled by SketchUp anyway; and then Disable them [red button].
Restart SketchUp and use 2d tools again to do/undo the fillets - does it still break on undo ???
If not then one of the now disabled plugins is the one doing something bad...
You can revert the Plugins Managers set up by re-applying the saved Set.
Hopefully you now know that a third-party is involved in breaking the fillet tool...
To try and uncover the rogue plugin try disabling about a half of the plugins again and restart, retest the filleting. If the splat recurs then you know the culprit in in the enabled half, try disabling half of those again until you zoom in on the plugin. Alternatively if it doesn't recur try disabling the currently enabled files [sparing 2d tools and su_...] and re-enabling half of what was disabled until you find it that way.
You might be able to reduce the list of plugins to test - e.g. omit testing on all of my own, thomthom's, Fredo's, Whaat's, SDMitch, ChrisFullmer etc, and a few simpler plugins which are all unlikely to cause issues with observers... Concentrate on the unusual / obscurer ones - e.g. those from unusual authors or those with BIM aspirations...If you do find the culprit let us know - also let the author know too.
-
I will try that soon when I get some time on my hands.
Thank you so much TIG.
-
I was actually able to do what you have requested.
It took me a while since I had little more than 90 extensions to go through.
(yeah, probably too many. but that's after brief clean up)found two that are suspected as culprits:
su_trimble_connect
TIG-LayerWatcherI have the version of your LayerWatcher updated in 2015/08/02 which i believe is the most recent.
And the su_trimble_connect is the most recent version as well. (confirmed in EW)I am not 100% sure they are the cause, I will keep testing without those two running.
-
Thanks for the report.
I also had my LayerWatcher installed so I didn't think that could be the problem.
But after more testing I think it is !Now to see if the issue is in the fillet's undo or the LayerWatcher code...
Watch this space... -
phew,
Thanks for your diligence TIG.
if your LayerWatcher is the cause, SketchUp should investigate Trimble connect as well. Because it was causing issue as well.I'll keep an eye on this space.
-
The very fact that LayerWatcher adds an EntitiesObserver onto the model.entities seems to make the Fillet tool crash when there's an Undo [in a chain of more than one fillet operation] either within the tool's operation or later on, even if the undo is not in the model.entities context!
If I have an 'empty' EntitiesObserver that does zilch, the Fillet's Undo will still crash, so it's not because it's doing anything - it just needs to exist to cause the issue !
This is weird.
I made a simple other tools with a similar 'empty' entities observer and this also causes this issue with the Fillet's Undo.
So it's not LayerWatcher's fault per se, but how Fillet's Undo reacts to it !I can't see an immediate fix...
I might have to sleep on it...
PS: Many other tools do similar things to the Fillet, and they will Undo without an issue.
The Fillet tool is slightly unusual in that it makes its arc inside a group and then inserts that into another group of geometry and explodes it, to force a merging of geometry while maintain the arc's curve properties. The original group's definition is deleted. Perhaps this methodology can be reassessed...
-
I can't possible understand everything that you described, but there is no urgency in this. So, I wouldn't mind letting your genius brain do its magic.
I've also noticed upon undo with fillet tool, it adds extra undos in case of fillet radius value change. I do not know if that was an intended behavior, but I find it a bit odd. Maybe that's something that ties with your methodology?
Thank you TIG.
-
Here's v7.0 http://sketchucation.com/pluginstore?pln=2Dtools
It's made into an extension.
The Fillet tool now sidesteps the issues from some 3rd-party plugins EntitiesObservers.
Also general future-proofing. -
Beautiful TIG!
I will try it out as soon as I can!
I thought you were gonna sleep on it
-
Going to sleep now !
-
Here's v7.1 http://sketchucation.com/pluginstore?pln=2Dtools There are several minor coding tweaks to try and work around a reported MAC issue [with my LayerWatcher!]...
Feedback appreciated... -
Here's v7.2 http://sketchucation.com/pluginstore?pln=2Dtools There are several more coding typo fixes to try and work around a reported MAC issue [with my LayerWatcher!]...
Feedback appreciated... -
Here's v7.3 http://sketchucation.com/pluginstore?pln=2Dtools The tool that used to set up the main tools' commands has been recast as a simple class instance, to avoid issues with MACs caused by having a tool activated as SketchUp initially loads...
-
Hi TIG
I've found a new bug with v7.3 of this plugin when running SU 2016...
When creating 2D fillets , the resultant geometry no longer shows as pure arcs, but exploded edges. Have attached a screenshot.
There are no ruby console error messages, and it works fine in SU 2015.
Cheers!
Joel
-
The 2d fillet's creation was changed to avoid problems with the new Observer regime in v2016.
This is the first reported issue.
I just retested it [v7.3 with v2016] very extensively and I got a perfect arc for the fillet every time...
But obviously that change looks like the probable cause of your glitch...
Does it occur every time for you ?
Do you have many other plugins loaded which might have skewed entities observers etc ?
Can you please post a simple SKP, with before and after examples of what you are seeing... -
Hi TIG
I'm not sure how to check if my other plugins conflict with 2D tools, but I've attached a SU 2016 file showing what I get when I try to fillet 2 edges with the plugin. It occurs every time with SU 2016, but works fine with SU 2015 (for me).
Hope this helps!
Cheers,
Joel
-
Very weird. I just opened your SKP file and selected the fillet. It's not exploded and reports as an arc with a radius which it wouldn't do if it was or had been exploded.
Click on the picture.Edit: Even weirder is that I get the same exploded arc when I run the 2D Fillet tool on the other corner. And notice one segment remains highlighted when I click on the others with Select. No modifier key was being held. Entity Info reports edges selected not an arc.
Click. -
Yup that is very weird. But the second image you described is exactly what happens whenever I try to run the fillet tool on SU 2016...one edge remains consistently highlighted and the curve reports as a series of edges...not an arc.
Cheers
J
Advertisement