[Plugin] CleanUp

shannonnovus

For the most part I love this plugin, but I'm having an issue with the "smooth by angle" feature. I'm running SketchUp 2015, with CleanUp3 (3.3.1).

It seems like the CleanUp plugin is "seeing" the lines that it could fix, and claims to be doing so, but isn't actually fixing anything.

Steps to reproduce:

Select the geometry (building outlines that have several line segments that are almost but not quite parallel)
Run CleanUp3, with Smooth Edges by Angle set to 5.0.
It runs, and says "Edges reduced: 1500", and the validity check is showing no problems.
BUT, then I still have the same number of edges in my model (8417) that I had at the beginning. Looking at the outlines in detail, the offending lines are still there.

I've tried both with faces included and faces deleted.

Any ideas?

Thanks,
Shannon

thomthom

@sasasaps said:

Great plug-in! Thanks a lot TT.

Also here for a question, in case anybody got to it already: What would be the recommended settings of the CleanUp plug-in so it doesn't kill the proxy materials??

In my experience it has taken down the "linked" materials used in proxies, someone else had the same trouble?

I'm not sure how the proxy materials are stored. You might want to make CleanUp not ignore attributes for materials - to avoid materials merging unless also the attributes are identical.
Then it could be that some materials used are not applied in the model - then you want to avoid purging materials.

manum876

Hi Thom! You see, I have some trouble loading the plugin, I already uninstalled it a couple of times, and replaced everything with the latest version to no avail. Here's the error log that appears every time I fire up SketchUp. Hope you can help me.
Thanks.

Something when wrong trying to load C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/TT_CleanUp/vendor/error-handler/error_reporter.rb.
Please copy this message and forward it to the developer.
Load error:
Error: #<NameError: undefined local variable or method error' for main:Object> C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/TT_CleanUp/vendor/error-handler/error_reporter.rb:483:in rescue in <top (required)>'
C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/TT_CleanUp/vendor/error-handler/error_reporter.rb:12:in <top (required)>' C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/tt_cleanup/bootstrap.rb:8:in require'
C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/tt_cleanup/bootstrap.rb:8:in <top (required)>' C:/PROGRA~1/SketchUp/SKETCH~1/Tools/extensions.rb:197:in require'
C:/PROGRA~1/SketchUp/SKETCH~1/Tools/extensions.rb:197:in load' C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/tt_cleanup.rb:40:in register_extension'
C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/tt_cleanup.rb:40:in <module:CleanUp>' C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/tt_cleanup.rb:15:in module:Plugins'
C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/tt_cleanup.rb:14:in <module:TT>' C:/Users/UsuarioBMA/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/tt_cleanup.rb:13:in <top (required)>'
C:/PROGRA~1/SketchUp/SKETCH~1/Tools/sketchup.rb:85:in require' C:/PROGRA~1/SketchUp/SKETCH~1/Tools/sketchup.rb:85:in block in require_all'
C:/PROGRA~1/SketchUp/SKETCH~1/Tools/sketchup.rb:85:in each' C:/PROGRA~1/SketchUp/SKETCH~1/Tools/sketchup.rb:85:in require_all'
eval:1:in `<main>'

AirWindSolar

This is probably my most used extension, but there's one option I'd love to see added; removing the terrain layer.
I use the location snapshot on probably 95% of my models for placing ground mounts or having an easy reference to real world objects, but only about 1% of my models actually use the terrain. (For the most part, that's left to the installers to deal with on site.) That can end up being a huge amount of extra data. Currently, I end up having to turn snapshot off, turn terrain on, unlock and delete each imagery section, then delete the layer and turn snapshot back on. Having it happen automatically in an extension I run on every model anyway would save some time and eliminate those times when I just plain forget to do it and leave 2-3 extra MB of unused data in a model of, for example, an apartment complex or shopping center. Foregoing "clean with last settings" and unchecking the option on the rare occasion I actually want the terrain would be a small price to pay.

thomthom

Can you file that feature request in the issue tracker please?
https://bitbucket.org/thomthom/cleanup/issues?status=new%26amp;status=open

plot-paris

Hey Thomthom,

I do not know since when this is an issue. But with big models, the CleanUp porcess doesn't work anymore. Only when I select small portions at a time, does it clean up. If I select too many objects simultaneously, its not doing anything.
Is this a known issue?
Here is such a model. Do you experience the same problem or is it just my system

thomthom

I've not heard of that. What system do you got? SU version, OS and OS version?

plot-paris

SketchUp Pro 2016 (v 16.1.1449)
Windows 10

cotty

I've got a lot of unresolved problems while opening the model, the cleanup afterwards leads to this...

thomthom

@plot-paris said:

SketchUp Pro 2016 (v 16.1.1449)
Windows 10

What version of CleanUp did you have?

thomthom

@cotty said:

I've got a lot of unresolved problems while opening the model, the cleanup afterwards leads to this...

I also saw the model had lots of validation issues.

I found your error report Cotty. It appear to come from face merging - some faces where lost. Typically I see this when a model have small faces which cause tolerance issue in SU. Or some models with imported DWG data which have carried over some small precision issues.

However, when I opened that model and ran only Merge Faces I got no errors.

What settings did you guys use with CleanUp? The different set of options often have great impact on what might trigger a bug/issue.

cotty

I do prefer ultra-clean...

plot-paris

I was relying on the SketchUcation Plugin to keep my stuff up to date. But that obviously didn't work. I just re-installed CleanUp³ and now got the same error message as cotty.

I then used thomthom's trick and did a first run, just Merging Faces and then a second, full cleanup. This worked!

So thanks guys. Now I have a new trick to use, when handling problematic models...

Dave R

Maybe you could add another trick and clean periodically as you go so you don't have a big load of stuff to clean up at the end.

thomthom

@cotty said:

I do prefer ultra-clean...

I recommend to enable Remove Duplicate Face only when you know there is an issue. It's extremely slow and not always reliable.

thomthom

@plot-paris said:

I then used thomthom's trick and did a first run, just Merging Faces and then a second, full cleanup. This worked!

That's strange... and troublesome. It means the issue stems from compound cleanup actions. hmm...

cotty

@thomthom said:

@cotty said:

I do prefer ultra-clean...

I recommend to enable Remove Duplicate Face only when you know there is an issue. It's extremely slow and not always reliable.

Thank you for the tip!

AirWindSolar

@thomthom said:

That's strange... and troublesome. It means the issue stems from compound cleanup actions. hmm...

Possibly the order of the operations? Sounds like removing duplicate faces simplified it enough that whatever was crashing could handle what was left after that specific operation.

One thing I'm noticing is that, for example, the bicycles are 24 separate but apparently identical ~600kb groups. That adds a lot of complexity compared to having a couple dozen instances of a single component. Same thing with several doors, etc. How hard would it be to recognize identical groups/components/items, and replace all of the duplicates with instances of one? (Maybe with some minimum complexity and/or count so it's not making components of every triangle or rectangle that happens to have a single mate somewhere.)

thomthom

@airwindsolar said:

How hard would it be to recognize identical groups/components/items, and replace all of the duplicates with instances of one? (Maybe with some minimum complexity and/or count so it's not making components of every triangle or rectangle that happens to have a single mate somewhere.)

I had a stab at that a few years ago: http://sketchucation.com/forums/viewtopic.php?t=30143
But I never got around to finish it. It quickly becomes non-trivial.

AirWindSolar

Another thought on this one; not sure how hard it would be to calculate without saving, but a before and after file size, or percent reduction of the file size in the info box would be a handy bit of bragging if a user is wondering how much this saved them.