[Plugin] CleanUp

brodie

Here's the model and a screenshot of the settings below.

http://dl.dropbox.com/u/384281/Laser%20Printer.skp

The number and location of faces which are deleted seems to have a certain random nature to it. Running the script, undoing the results, and running the script again a few times resulting in different results each time

-Brodie

Edit: the original model is from here and is free http://archive3d.net/?a=download&id=3dfc187e

printer 2.JPG

thomthom

Ok, looked at the model.

The first thing I got when I opened the model was a warning:

@unknownuser said:

Results of Validity Check.

The plane equation for CFace (51806) is not valid - fixed
The plane equation for CFace (61254) is not valid - fixed
The plane equation for CFace (145402) is not valid - fixed
The plane equation for CFace (146979) is not valid - fixed
The plane equation for CFace (149505) is not valid - fixed
The plane equation for CFace (230859) is not valid - fixed
The plane equation for CFace (297112) is not valid - fixed
The plane equation for CFace (297293) is not valid - fixed
The plane equation for CFace (299305) is not valid - fixed
The plane equation for CFace (311352) is not valid - fixed
The plane equation for CFace (316611) is not valid - fixed
The plane equation for CFace (333176) is not valid - fixed
The plane equation for CFace (333255) is not valid - fixed
The plane equation for CFace (333707) is not valid - fixed
The plane equation for CFace (395589) is not valid - fixed

I did not run the test - SU did that manually.

I then ran CleanUp with these settings:

A key setting might be that I didn't tell it to Ignore Normals. (Not sure - I did not compare with other settings.)

I then got a new validity check (because I'd asked for it. it's common to get error like this when the model already was producing errors.)

@unknownuser said:

Results of Validity Check.

CEdge (62898) and CEdge (1380179) connect the same 2 vertices - fixed
The plane equation for CFace (1044) is not valid - fixed
The plane equation for CFace (1425) is not valid - fixed
The plane equation for CFace (2564) is not valid - fixed
The plane equation for CFace (2604) is not valid - fixed
The plane equation for CFace (2954) is not valid - fixed
The plane equation for CFace (3000) is not valid - fixed
The plane equation for CFace (3827) is not valid - fixed
The plane equation for CFace (5067) is not valid - fixed
The plane equation for CFace (5382) is not valid - fixed
The plane equation for CFace (5702) is not valid - fixed
The plane equation for CFace (7542) is not valid - fixed
The plane equation for CFace (92317) is not valid - fixed
The plane equation for CFace (93266) is not valid - fixed
The plane equation for CFace (108967) is not valid - fixed
The plane equation for CFace (212162) is not valid - fixed
The plane equation for CFace (212355) is not valid - fixed
The plane equation for CFace (213151) is not valid - fixed
The plane equation for CFace (213681) is not valid - fixed
The plane equation for CFace (213868) is not valid - fixed
The plane equation for CFace (246903) is not valid - fixed
The plane equation for CFace (271394) is not valid - fixed
The plane equation for CFace (293150) is not valid - fixed
The plane equation for CFace (293557) is not valid - fixed
The plane equation for CFace (484265) is not valid - fixed
The plane equation for CFace (484587) is not valid - fixed
The plane equation for CFace (491934) is not valid - fixed
The plane equation for CFace (542762) is not valid - fixed
The plane equation for CFace (543339) is not valid - fixed
The plane equation for CFace (549098) is not valid - fixed
The plane equation for CFace (549228) is not valid - fixed
The plane equation for CFace (575761) is not valid - fixed
The plane equation for CFace (576252) is not valid - fixed
The plane equation for CFace (576379) is not valid - fixed
The plane equation for CFace (577820) is not valid - fixed

The printer model dropped from ~100K (!!! ) faces to "merely" 38K faces...

No error messages about lost geometry.

mac1

mosel clean.jpg Would like to suggest one item at a time be "cleaned". The results you get can be a function of the action and its sequence and the model may not be good to start with. I imported the printer to mesh lab ( 3ds) and note the things cleaned on the right side ( it corrected some of the bad faces to start) and the jpg shows the self intersecting faces. Deleting those can be destructive to the model and I did not do that. In the past I have had that problem and have not been able to figure out if it is MeshLab or SU.
Just some thoughts

mac1

clean layer text.jpg
Layer text did not disply wee. Hope this is better.

mp1963

Installed the latest version of Cleanup and I am seeing these errors:

undefined method `hidden?' for #Sketchup::Vertex:0xe3d4fc4

/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1142:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:113:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:119:in each_entity' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each_entity' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:119:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:772:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):110:in call'
(eval):110

The model I am cleaning up is very simple and these errors seem to occur after completing one (sometimes two) previous cleanup operations.

I hope this information is of some use ?

I am also experiencing a lot of Sketchup Pro crashes, without any crash reports being generated.

I am using Sketchup Pro 8.0.11751 on Mac OS X 10.7.2. Hardware is a iMac 2.93Ghz Core 2 Duo with 8Gb of DDR3 RAM.

Thanks for the excellent plugin.

Kind regards,

Marek

thomthom

That is a very strange error!
Somehow it iterates over a Vertex entity - I cannot see any reason for that...

Can you post the model? Or send it to me privately if you don't want to publicly share?
Also, I need to know the exact settings you used. (A screenshot of the settings window)

And I assume you;re using the latest CleanUp? 3.1.9?
And the exact version of TT_Lib2?

mp1963

Have sent you a PM about this

thomthom

I looked at the model. Could not reproduce it. But I used a PC. Will have to try on my Mac.
Exactly what version of SketchUp do you have? And TT_Lib2?

(btw - I did see that there where many small details - where edges where less than 1mm - which can cause issues with SU. But I'm not sure if that would cause such an error as the one you see...)

mp1963

Specifications of software and hardware...

I am using Sketchup Pro 8.0.11751 on Mac OS X 10.7.2. Hardware is a iMac 2.93Ghz Core 2 Duo with 8Gb of DDR3 RAM. Video card is an Nvidia GT130.

TT_Lib2 is version 2.6.0

Hope that helps.

Marek

mp1963

Another strange error today, not seen this one before:

undefined method `valid?' for #Sketchup::OptionsProvider:0xecc34c8

/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1133:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:134:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:768:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):3713:in call'
(eval):3713

Hope this list of problems is of some help ?

thomthom

Can you reproduce it? If so how?

Because I cannot see how on earth that ever should happen. While iterating the model the plugin ran across an OptionsProvider object... Never ever should such thing be possible. I don't know if it's an SU glitch or if there is some plugin conflict somewhere that messes with the core classes.

I first need to know if it's a reproducible case.

mp1963

I will have a go at reproducing the error. I seem to think it happens after several consecutive runs of the cleanup script. Will get back to you as soon as it happens again.

mp1963

Ok I managed to produce this error:

undefined method `hidden?' for #Sketchup::Vertex:0xea1acbc

/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1142:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:134:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:768:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in `to_proc'

All I did was attempt to cleanup two separate models. I used the default cleanup settings. The only thing I changed was to tell cleanup to clean the model rather than selected. When cleaning the second model the error above appears.

mp1963

Attempting to repeat the cleanup process on a second model yields this error:

undefined method `current=' for #Sketchup::Face:0xdcbe564

/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:564:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):114:in call'
(eval):114

I have now removed all but the most necessary plugins from my Sketchup installation. Any suggestions as to what I can do next to try and help resolve these issues ?

mp1963

I don't restart Sketchup after these errors occur I get more and different error messages, like this one:

undefined method `hidden?' for #Sketchup::AttributeDictionary:0xdbb3c50

/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1142:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:134:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each_entity'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:768:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):110:in call'
(eval):110

Would you like me to try reinstalling Sketchup or could this be a problem with the Ruby installation for the Mac ? Why is noone else reporting errors like this or is the case that most Sketchup users are on windows and these errors don't happen ?

mp1963

I have now updated my version of Ruby to the latest (1.9.3) and these errors still occur. Just for your information.

thomthom

@mp1963 said:

Why is noone else reporting errors like this or is the case that most Sketchup users are on windows and these errors don't happen ?

It's strange that these errors should show themselves now. There are many OSX users. ...but could it be a Lion issue? Your profile information is up to date?

mp1963

Have updated my system specification to include the 10.7.3 update we got from Apple last week. Sadly I didn't know about your plugin prior to Lion so I can't comment its stability then but I agree it is most odd that other users are not reporting/seeing these issues. I am reasonably certain its not the way I build my models in Sketchup. The one I sent you a while ago was not odd in any way I don't think ?

Please let me know if there is anything I can help you track down what is going on here ?

thomthom

No, the model looked fine. But the errors are the most bizarre I've ever seen. They make no sense what so ever!

@mp1963 said:

undefined method `current=' for #Sketchup::Face:0xdcbe564

/Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:564:in `cleanup!'

Line 564 in the plugin is: model.materials.current = nil Which would imply that model.material are returning a face instead of the model's material list. It's crazy!

And the other errors says when when the script iterate the model entities it's getting vertices and attribute dictionaries... there is no way that should happen.

Sound like there's some wires getting crossed here - by the SketchUp core itself...

Could you try, for the sake of it, to reinstall SketchUp? Completely remove the old and try with just CleanUp? (I'm sorry about the awkwardness of doing that, but I really have no idea to what this could be. The old, "reset" and try again is the only thing I can think of.)

I might try to see if I can grab hold of a Googler and see if they know of any Lion issues.

I'm baffled...

mp1963

Will reinstall Sketchup later on today and let you know what happens.