[Plugin] CleanUp

Ecuadorian

Wow... no more lost faces (as happened with other cleanup scripts), and cleanup is top-notch.

Here it is applied only to the horizontal white borders:

You do realize the importance of this script in the history of SketchUp, do you? Thanks again!

thomthom

Good to see it working on other complex models. I only tried it against one complex one, large triangulated terrain with 80K+ faces. (Though that model had all the potential problems you could run into AFIK.)

Jim

Ack! it doesn't look at materials?

Oh, and thank you!

thomthom

@jim said:

Ack! it doesn't look at materials?

Oh, and thank you!

No, but that's a very good suggestion.

Ecuadorian did find some issues with some geometry, so I'll push an update when I've gotten around to look at it.

thomthom

Ecuadorian:
I had a look at your sample file. I see the issues. I think it's a tolerance issue. I'll have to investigate a little more to tune in the tolerance.

Ecuadorian

Thanks! I think I now remember what the problem might be, also. The model is scaled a lot.

thomthom

This is strange. When I compare the dot product of various faces, I find an overlap in the return value for faces where you can erase the connecting edge:


	# Not coplanar
	# 0.999999999898786
	# 0.999999999901467
	# 0.99999999992968
	# 0.99999999995352
	# 0.999999999959393
	# 0.999999999974808
	#
	# Coplanar
	# 0.999999999917881
	# 0.999999999918562
	# 0.999999999984962
	# 0.999999999999148
	# 0.999999999999408

thomthom

@ecuadorian said:

Thanks! I think I now remember what the problem might be, also. The model is scaled a lot.

I did notice that - but I exploded it and it still occurs...

Chris Fullmer

Could you take the edge, find its connected faces. Then get the object id for those faces, and get all their vertices positions. Then delete the edge if it is planar. Then test to see if those faces still exist. If they do, move on. If they do not, then rebuild them using their vertices' positions? Painful yes, but maybe useful?

Chris

thomthom

@chris fullmer said:

Could you take the edge, find its connected faces. Then get the object id for those faces, and get all their vertices positions. Then delete the edge if it is planar. Then test to see if those faces still exist. If they do, move on. If they do not, then rebuild them using their vertices' positions? Painful yes, but maybe useful?

Chris

I did that kind of stuff in my previous version, prior to 7.1 - wasn't stable. So many cases to take into account. Faces with inner holes etc...

thomthom

I think I might have misunderstood this whole DOT product from vectors... will have to look deeper into it.

Chris Fullmer

Can you hit ctrl-z in ruby?

remus

@thomthom said:

I think I might have misunderstood this whole DOT product from vectors... will have to look deeper into it.

What do you think is not working? from my quick browse of your script the dot product should do what you want.

thomthom

@chris fullmer said:

Can you hit ctrl-z in ruby?

Yea, http://code.google.com/intl/nb/apis/sketchup/docs/ourdoc/sketchup.html#undo
But that would ruin any kind of possibility to undo the whole erase coplanar operation.

thomthom

...could create a temp group and use that to replicate the two faces (when within a range where we can't be certain.)

but I'd still try to avoid that if I can calculate this.

honoluludesktop

Hi Thomas, I lost a texture from a face in a 61k faces model. BTW what happens when you have coplaner faces with different textures, or images placed on textured faces (say a run on a wood floor). Didn't read all the post, so sorry if already covered.

thomthom

@honoluludesktop said:

Hi Thomas, I lost a texture from a face in a 61k faces model. BTW what happens when you have coplaner faces with different textures, or images placed on textured faces (say a run on a wood floor).

At the moment it doesn't take into account materials. Only geometry.

Images? You mean an actual Image entity (It says "Image" in Entity Info when you select it?)

thomthom

@honoluludesktop said:

Well, I often import images (as images, not textures), and place them on textured faces.

They would be ignored.
However, I do plan on adding an option for it to respect the material of the geometry. Just got to sort out some other issue first.

honoluludesktop

Well, I often import images (as images, not textures), and place them on textured faces.

honoluludesktop

Opps, added image after your post.