[Plugin] Add Icons [for all SU files on mac]

greatoe

I pasted the code, hit return
ruby console return "True";
JcB::SetWindowSize::Change.set_2_square, return
ruby console return "True";
and SketchUp ask me if I want to save my current work;
I click "yes"
ruby console return the following:
Error: #<NoMethodError: undefined method attribute_dictionary' for nil:NilClass> /Users/zz/Library/Application Support/SketchUp 2015/SketchUp/Plugins/jbb_layers_panel/rb/observers.rb:189:in onContentsModified'

if I click "no"
ruby console return:
Error: #<TypeError: reference to deleted Attribute>
/Users/zz/Library/Application Support/SketchUp 2015/SketchUp/Plugins/jbb_layers_panel/rb/observers.rb:203:in each' /Users/zz/Library/Application Support/SketchUp 2015/SketchUp/Plugins/jbb_layers_panel/rb/observers.rb:203:in block in onContentsModified'
SketchUp:1:in `call'

then the window of my current work is closed, while SketchUp is still running;

then I click the SketchUp icon on the Dock, a blank/new SketchUp window pops up, which is square.

I press up arrow in ruby console then return
the new SketchUp window revert to previous size, but a little different with its position on screen.

driven

cheers for that comprehensive testing,

Is that the latest version of jbb_layers_panel that's causing the errors?

for some reason it's observers are being triggered by closing and re-opening the SU window...

If you temporarily disable it does this code run without issue?

In Preferences, do you have 'new windows' set to 'cascade'?

If so does after deselecting that does the top corner still move?

I do have a completely different 'new' way of changing the window width, but that also needs more testing...

john

greatoe

the latest version 1.0.2 and a previous version work same;
how to temporarily disable the observers?

yes 'new windows' are set to 'cascade', deselecting this solved the window moving problem

driven

@greatoe said:

the latest version 1.0.2 and a previous version work same;
how to temporarily disable the observers?

I was meaning the version of 'layer panels' it's throwing those errors, if you disable it then it's observers shouldn't run...

@unknownuser said:

yes 'new windows' are set to 'cascade', deselecting this solved the window moving problem

I can turn that on and off in code so I'll add it in...

I'd forgotten that dave had that problem on another version...

greatoe

sorry I didn't read your words carefully.

I removed jbb_layers_panel, no more error message in ruby console.

however the close/open window issue remains:
I paste the code and return
JcB::SetWindowSize::Change.set_2_square and return
SketchUp ask if I want to save my file
no matter yes or no the window is closed
I manually re-open the window, continue with up arrow return, window transform forward and backward works fine afterwards.

driven

@greatoe said:

SketchUp ask if I want to save my file
no matter yes or no the window is closed
I manually re-open the window, continue with up arrow return, window transform forward and backward works fine afterwards.

I've been adding a catch for that as well, so it waits for you to save...

got it working for 'Unsaved' just need to add some code for modified ones as well...

john

driven

here's a test version that hopefully deals with the retina and other v15 issues...

set_square and set_printer should both deal with unsaved models or changes, but you then need to re-select the option...
EDIT: removed test file
PM me if you can do any testing and I'll send you a rbz...
john

jojo9

luxurious way to add icons…nice one!

however, the batch command doesnt work for me…i get the loading image, but this process continues forever. Where looks your plugin for, example, "*.skp" files?
Else, thanks!

oh, i forget : im on Mac 10.7.5, and use Su13 make

driven

@jojo9 said:

luxurious way to add icons…nice one!

cheers, I got sick of waiting for native icons...
@unknownuser said:

however, the batch command doesnt work for me…i get the loading image, but this process continues forever.

this is down to me not using v2013 anymore, and not having the time to go back in time to fix it...
@unknownuser said:

Where looks your plugin for, example, "*.skp" files?

In batch mode, it should open a 'Finder' window that lets you look anywhere you want, it is best to target small collections, i.e. if I target 'Downloads' it will try process the 206 files without icons and if any are corrupt files it can crash SU, but I have also done folders with 500+ skps that I've created without any issues...
@unknownuser said:

oh, i forget : im on Mac 10.7.5, and use Su13 make

that is probably the issue, the single mode should work for any SU version, and some people can run batch mode in earlier versions, so it hard to figure out the problem...

I'll try to find some time to revisit...

john

sketchuh

like to donate thru paypal. your add icons plugin works. what is your paypal address. u can pm me. Thanks.

sketchuh

i have to resize the sketchup window size to a square , if i want the thumb nail to be square. otherwise, my thumnails are always with red bands. the square button doesn't work.

also, can you change the red color to white or grey? thanks

driven

Hi sketchuh,
are you still on SU v15 , which version of osx do you run and do you have a retina display?

I've been doing some more work on this, but it's not quite ready...

can I PM you some test files?

john

sketchuh

yes john!

I am using sketchup 2015 on macbook pro retina 2013. and using the latest os system.

sketchuh

actually, when chose the batch mode, almost all other sktechup files would have square thumb nails, only one that is opened has red bands if the viewport is not square.

driven

if you want to change the red to Finder off white, copy/paste this code into 'Ruby Console' and hit Return...
it should work without needing a restart of SU...

filename = Sketchup.find_support_file("jcb_Add_Icon/Add_icon_logic.rb", 'Plugins')
text = File.read(filename) 
content = text.gsub(/ FF0000 /, " e8e9e8 ")
File.open(filename, "w") { |file| file << content }

john

sketchuh

thanks, the red is changed.

just want to confirm do i have to resize the window to square in order to have the thumb nail square?

driven

@sketchuh said:

just want to confirm do i have to resize the window to square in order to have the thumb nail square?

Currently, yes, and I don't know why the 'make square' button only works for some people...

It may be because of Retina or system/SU language used...

I have another way of doing it automatically, which 'batch mode' uses, but need some time to add it in and test...

john

driven

Finally SketchUp has added it's own icons for mac with the release of v17...

not the same quality [imho] but it's native and I can finally stop updating this plugin....

john

greatoe

@driven said:

Finally SketchUp has added it's own icons for mac with the release of v17...

not the same quality [imho] but it's native and I can finally stop updating this plugin....

john

I've been using your plugin for years, thank you very much, John.

It's good that SketchUp can make native icon for mac (again) now but I still prefer yours, which has larger resolution. And I think that 'file' frame in the icons SketchUp produce is useless and screen-landscape-consuming.

greatoe

@driven said:

Finally SketchUp has added it's own icons for mac with the release of v17...

not the same quality [imho] but it's native and I can finally stop updating this plugin....

john

Hi driven,

This plug-in is not working on macOS 10.15 Catalina. Is there a chance that you would like to make a fix?