[Plugin] 3D Parametric Shapes - makes placeable components

johnwmcc

Thanks for reminding me - will do later this evening.

johnwmcc

Version number updated to 2.51 in both jwm_shapes_loader.rb and jwm_shapes.rb files, and the Plugin Store. Makes no difference to operation, but should now show correct version internally

Extractor

Hi John,

I can´t install the last version of the plugin (Sketchucation Plugin Store: v 2.51). The previous versions ran properly.

Here the “Load Errors”:
Error: #<NameError: uninitialized constant JWM::JWMShapes::Parametric>
C:/Users/Frangenberg/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/jwm_shapes/jwm_shapes.rb:99:in <module:JWMShapes>' C:/Users/Frangenberg/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/jwm_shapes/jwm_shapes.rb:11:in <top (required)>'
C:/Program Files/SketchUp/SketchUp 2015/Tools/extensions.rb:197:in require' C:/Program Files/SketchUp/SketchUp 2015/Tools/extensions.rb:197:in load'
C:/Users/Frangenberg/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/jwm_shapes_loader.rb:24:in register_extension' C:/Users/Frangenberg/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/jwm_shapes_loader.rb:24:in module:JWMShapes'
C:/Users/Frangenberg/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/jwm_shapes_loader.rb:12:in <module:JWM>' C:/Users/Frangenberg/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/jwm_shapes_loader.rb:11:in <top (required)>'

johnwmcc

Hmmm. I get the same error. Sorry all round. Not sure what's happened, as I though I had only changed some internal references.

Will investigate and update asap.

John McC

johnwmcc

Bug now fixed in v2.5.2 - I'd made a typo in parametric.rb in the Module name - sorry.

Works for me now.

RBZ file uploaded both to Plugin Store and to the first post in this thread.

TIG

I assume you forgot to 'Publish' it yet again...
I did it for for.
If you didn't want that you'll need to Un-Publish it !

johnwmcc

So sorry - I DID publish it at least once! But maybe not after my very last edit. Thanks again.

J

blajnov

@johnwmcc said:

Bug now fixed in v2.5.2 - I'd made a typo in parametric.rb in the Module name - sorry.

Works for me now.

RBZ file uploaded both to Plugin Store and to the first post in this thread.

Dear johnwmcc, in your build tool does not work sphere ...
I use SketchUp PRO 2015
PS: By the way, in SketchUp PRO 8, the same Problem

TIG

I have just tested it and the sphere-tool works correctly.
What values are you entering into the dialog for the sphere's radius and segments ?

What "doesn't work" ?

blajnov

@tig said:

I have just tested it and the sphere-tool works correctly.
What values are you entering into the dialog for the sphere's radius and segments ?

What "doesn't work" ?

Does not work with the default settings, as well as changing the radius and number of segments in a big way, nothing happens, ie the scope does not appear in the scene ...

Chisaina

Hello, I have a similar volume (sphere) will not appear on the stage

johnwmcc

I find I now get the same thing (not working) here - nothing is drawn.

Will investigate asap.

TIG

Using the default of 10mm [or anything else!] the error message is:

@unknownuser said:

Error: #<NameError: uninitialized constant JWM::JWMShapes::Sphere::PolygonMeshHelper>
C:/Users/TIG/sketchUcloud/plugins/jwm_shapes/jwm_shapes.rb:984:in draw_sphere' C:/Users/TIG/sketchUcloud/plugins/jwm_shapes/jwm_shapes.rb:956:in create_entities'
C:/Users/TIG/sketchUcloud/plugins/jwm_shapes/parametric.rb:49:in initialize' C:/Users/TIG/sketchUcloud/plugins/jwm_shapes/jwm_shapes.rb:946:in new'
C:/Users/TIG/sketchUcloud/plugins/jwm_shapes/jwm_shapes.rb:946:in create' C:/Users/TIG/sketchUcloud/plugins/jwm_shapes/jwm_shapes.rb:1731:in block in module:JWMShapes'
SketchUp:1:in `call'

This is weird as it worked for me before !
Looks like a missing module/class ?
I also get the error with Dome etc...

TIG

mesh.extend(PolygonMeshHelper)
should be
mesh.extend(JWM::Shapes::PolygonMeshHelper)
three times...

johnwmcc

I wonder, TIG, if you can help me understand what's gone wrong in trying to separate the code here from that in the older SU Shapes on the Extension Warehouse.

The current problem is a name error: I get this error for the Dome and Sphere tools now, which both try to call mesh_additions.rb and fail. The other shapes don't need mesh_additions.rb, so still work properly.

Error; #<NameError; uninitialized constant JWM;;JWMShapes;;Sphere;;PolygonMeshHelper>

My overall code structure for the Sphere tool goes as follows (Dome has just the same structure), and I don't really understand it (just copied from SU Shapes!).

file jwm_shapes.rb has:

module JWM;;JWMShapes
...
  class Sphere < Parametric
  ...
  end # class Sphere
...
end # module JWMShapes

file parametric.rb has:

module JWM;;JWMShapes
  class Parametric
  ...
  end # class Parametric
end #module JWM;;JWMShapes

file mesh_additions.rb has:

module JWM;;Shapes
...
  class PolygonMeshHelper
  ...
  end #class PolygonMeshHelper
...
end #module JWM;;Shapes

Apparently, instead of (as I expected) the Sphere class looking for

JWMShapes;;Shapes;;PolygonMeshHelper

it is looking instead for

JWM;;JWMShapes;;Sphere;;PolygonMeshHelper

What have I done wrong here, and how do I fix it? If you can help, I'll be most grateful

[Later] The original SU Shapes named the overall module CommunityExtensions instead of JWM, and the mesh_additions.rb code says

module CommunityExtensions;;Shapes
...
  module PolygonMeshHelper
  ...
  end # module PolygonMeshHelper
...
end #module CommunityExtensions;;Shapes

I.E., as well as the name change JWM<-->CommunityExtensions and JWM::JWMShapes<-->CommunityExtensions::Shapes, PolygonMeshHelper was a module, not a class.

Changing it back from class to module doesn't seem to fix the problem.

Looking at the above, I see that my mesh_additions.rb SHOULD say JWM::JWMShapes instead of JWM::Shapes

module JWM;;JWMShapes

, but changing that doesn't seem to fix things either.

Help please, if you can! I'm temporarily stuck, and thoroughly confused.

johnwmcc

I see you posted again while I was replying. Many thanks.

Will make the changes asap.

TIG

I made the three simple changes which I suggested earlier... and it works without errors.

You are getting yourself into a tangle...

Once you put a sub-module named within your all-encompassing 'JWM' module, then its name can be the same as similar names used in others' code...
The nesting separates them...
Calling them by your path JWM::... will avoid any that are poorly written by others and are 'global'...

So be consistent use 'JWM::Shapes', OR if you must 'JWM::JWMshapes' etc consistently...
Use Notepad++ with all affected files open and fine replace in all so they are internally consistent...
Perhaps draw out on a sheet of A4 the nested relationships of these modules/classes.
The full path I changed to works...

johnwmcc

Once again, TIG, thank you for cleaning up my muddle, and for explaining what's gone on.

I will make the changes on my original copy here too, and go back to just called the sub-modules by the same name as the SU Shapes ones - simply Shapes.

Have you updated the Plugin Store rbz file, or do I still need to fix the files here then upload them? And would it now be better to delete the attached file in the first post, and replace that by a link to the Plugin Store?

Must stop now for a while - will resume later tonight.

TIG

@johnwmcc said:

Once again, TIG, thank you for cleaning up my muddle, and for explaining what's gone on.

I will make the changes on my original copy here too, and go back to just called the sub-modules by the same name as the SU Shapes ones - simply Shapes.

Have you updated the Plugin Store rbz file, or do I still need to fix the files here then upload them? And would it now be better to delete the attached file in the first post, and replace that by a link to the Plugin Store?

Must stop now for a while - will resume later tonight.
Please update your own files / RBZ in the PluginStore.
But please remember to click on Publish afterwards
I would recommend that you just have the one RBZ in the PluginStore, and add a link to its entry inside 'download' tags.
Put that in the very first post: when I update a plugin I usually also add it into that announcement post - a one-click direct-link means that the reader doesn't have to find it again, either in the first-post or by looking within the PluginStore itself...
The proper linking URL is http://sketchucation.com/pluginstore?pln=jwm_shapes

johnwmcc

Plugin store updated to v2.5.3, and first post in this thread now links to it.

Downloaded and tested it here in SU2015.