[Plugin] CleanUp

AcesHigh · 7 Oct 2011, 23:29

why arent these coplanar faces (from two different GoogleEarth imported meshes) merged?

in this thread, I first tried to use the 2D Boolean plugin. To no use, as we can see here. There are still plenty of coplanar faces where the GoogleEarth imported meshes overlap.

thomthom · 8 Oct 2011, 07:48

@aceshigh said:

why arent these coplanar faces (from two different GoogleEarth imported meshes) merged?

Can you post the model?
Also, what are your settings? Remember that CleanUp has options to take into account face normals, material and UV mapping when merging.

Also, that image seem to illustrate faces occupying the same plane...?

AcesHigh · 8 Oct 2011, 11:58

@thomthom said:

@aceshigh said:

why arent these coplanar faces (from two different GoogleEarth imported meshes) merged?

Can you post the model?
Also, what are your settings? Remember that CleanUp has options to take into account face normals, material and UV mapping when merging.

Also, that image seem to illustrate faces occupying the same plane...?

no need to upload the model. It happens with any model, when importing several GoogleEarth meshes which overlap.

thomthom · 8 Oct 2011, 13:06

@aceshigh said:

@thomthom said:

@aceshigh said:

why arent these coplanar faces (from two different GoogleEarth imported meshes) merged?

Can you post the model?
Also, what are your settings? Remember that CleanUp has options to take into account face normals, material and UV mapping when merging.

Also, that image seem to illustrate faces occupying the same plane...?

no need to upload the model. It happens with any model, when importing several GoogleEarth meshes which overlap.

Well, I don't see the behaviour, so if I am to check this out I need something to work with.

And these meshes, do you merge them into one group?

AcesHigh · 8 Oct 2011, 17:39

@thomthom said:

@aceshigh said:

@thomthom said:

@aceshigh said:

why arent these coplanar faces (from two different GoogleEarth imported meshes) merged?

Can you post the model?
Also, what are your settings? Remember that CleanUp has options to take into account face normals, material and UV mapping when merging.

Also, that image seem to illustrate faces occupying the same plane...?

no need to upload the model. It happens with any model, when importing several GoogleEarth meshes which overlap.

Well, I don't see the behaviour, so if I am to check this out I need something to work with.

sorry ThomThom, it had happened in every experiment I did before, so I wrongly assumed it would happen in every one. But I did one try with two small pieces and nothing happened (although there were some lost textures in the process)

So I will upload a SKP file. Thanks for the patience and hard work.

@unknownuser said:

And these meshes, do you merge them into one group?

yup. Merge them into one group, then explode the meshes inside the group. Then CleanUp them. In the file I am sending you, not only some faces were lost when using CleanUp, as some coplanar faces were not merged, so you can see some texture flickering when rotating around.

experimento2.skp

thomthom · 8 Oct 2011, 18:01

Also, what are your settings?

thomthom · 8 Oct 2011, 18:05

That model is after CleanUp is run? You got the original?

AcesHigh · 8 Oct 2011, 18:10

@thomthom said:

Also, what are your settings?

what settings ThomThom? The ones from CleanUp³?

everything selected except Geometry to Layer 0, Merge Identical Materials (its two different materials, a bitmap for each imported mesh), so I saw no reason to use it) and Erase Stray Edges.

sorry, I didnt keep the original imported meshes. But I will try again with new imported meshes.

thomthom · 8 Oct 2011, 18:16

Looking at the one you sent, I selected everything and intersected it with itself a few times. CleanUp doesn't clean up faces that partially overlaps. Only faces that fully cover the exact same space as another. After intersecting and then cleaning there was no overlapping.

AcesHigh · 8 Oct 2011, 18:16

here... I copied the two meshes and joined them in a group, exploded them, and used Cleanup. No lost triangles this time, but there are plenty of overlapping triangles. (sometimes they dont appear when viewing in the textured mode, but when you used SHADED mode you will see the overlapping triangles...)

of course, the problem gets worse when you have to import even more mesh pieces, as sometimes you have over 3 meshes overlapping.

experimento3.skp

AcesHigh · 8 Oct 2011, 18:18

@thomthom said:

Looking at the one you sent, I selected everything and intersected it with itself a few times. CleanUp doesn't clean up faces that partially overlaps. Only faces that fully cover the exact same space as another. After intersecting and then cleaning there was no overlapping.

I will try that, thanks... however... how can I intersect if they are not solids?

ps: I am trying to solve, with CleanUp, about the same problem that made me ask for the "GoogleEarth Meshes boolean subtract" plugin at the topic http://forums.sketchucation.com/viewtopic.php?f=323&t=40555

thomthom · 8 Oct 2011, 18:22

@aceshigh said:

@thomthom said:

Looking at the one you sent, I selected everything and intersected it with itself a few times. CleanUp doesn't clean up faces that partially overlaps. Only faces that fully cover the exact same space as another. After intersecting and then cleaning there was no overlapping.

I will try that, thanks... however... how can I intersect if they are not solids?

ps: I am trying to solve, with CleanUp, about the same problem that made me ask for the "GoogleEarth Meshes boolean subtract" plugin at the topic http://forums.sketchucation.com/viewtopic.php?f=323&t=40555

Not intersecting with Solid Tools, but the regular intersect that's been in SU since, ever..? From the context menu, there is Intersect Faces menu item.

AcesHigh · 8 Oct 2011, 19:09

@thomthom said:

@aceshigh said:

@thomthom said:

Looking at the one you sent, I selected everything and intersected it with itself a few times. CleanUp doesn't clean up faces that partially overlaps. Only faces that fully cover the exact same space as another. After intersecting and then cleaning there was no overlapping.

I will try that, thanks... however... how can I intersect if they are not solids?

ps: I am trying to solve, with CleanUp, about the same problem that made me ask for the "GoogleEarth Meshes boolean subtract" plugin at the topic http://forums.sketchucation.com/viewtopic.php?f=323&t=40555

Not intersecting with Solid Tools, but the regular intersect that's been in SU since, ever..?

since ever, but I had never seen or used it before

anyway, however, intersected it with itself several times, and when I used cleanup³, several triangles were lost, and got some error messages

thomthom · 9 Oct 2011, 07:48

@aceshigh said:

and got some error messages

What where the error message?

AcesHigh · 9 Oct 2011, 15:28

@thomthom said:

@aceshigh said:

and got some error messages

What where the error message?

something along these lines (not exactly the same because I had to test again, with new Earth imported meshes, so different triangles disappeared, etc)

Results of Validity Check.

CEdge (4234) and CEdge (7926) connect the same 2 vertices - fixed
The plane equation for CFace (4767) is not valid - fixed

35 errors occurred. Please report the error and sample model to the author.

35 - Face merge resulted in lost geometry!

sumaster · 10 Oct 2011, 18:05

Dear Thomthom Sir,

here you are launch your new Cleanup (3.1.8) — 06 October 2011
• Whats new features you are added

and one problem can you solve in new version

I'm architectural student and import CAD drawing and lock that drawing in sketchup viewport
but when i play / start " Clean With Last Setting " he also cleanup viewport with lock group/component

See here ......

And thank you for this tool its very best for me or ever one ......

I'm very happy with this tool ......

thomthom · 11 Oct 2011, 14:09

The way CleanUp traverses the model it's tricky to know what is part of a locked group or not. But I'll put it down for investigation.

sumaster · 11 Oct 2011, 14:37

Yes thank you .....

derei · 11 Oct 2011, 14:44

@thomthom said:

The way CleanUp traverses the model it's tricky to know what is part of a locked group or not. But I'll put it down for investigation.

You can use ruby to check if is locked or not
http://code.google.com/apis/sketchup/docs/ourdoc/group.html#locked ?
http://code.google.com/apis/sketchup/docs/ourdoc/componentinstance.html#locked ?

thomthom · 11 Oct 2011, 15:12

@unknownuser said:

@thomthom said:

The way CleanUp traverses the model it's tricky to know what is part of a locked group or not. But I'll put it down for investigation.

You can use ruby to check if is locked or not
http://code.google.com/apis/sketchup/docs/ourdoc/group.html#locked ?
http://code.google.com/apis/sketchup/docs/ourdoc/componentinstance.html#locked ?

I know, but, I traverse the model by model.definitions.each - which means that I do not know if the parent for the instances I traverse are locked. I could be checking a sub-group of a locked group and .locked? will return false.