Entities.add_group bug?
-
Uff,a lot of work for "moving" a face.And still needs the material and back material and soften edges...
Almost easier to wait the Sketchup team to repair the Entities.add_group(other_entities) function@tig said:
How do YOU know [magically?] that e0=group1.entities[0] is a face?
The ruby console confirmed it.It is only for testing. -
@tig said:
face=nil group1.entities.each{|e|face=e if e.class==Sketchup::Face}
Can be written as:
face = group1.entities.find{|e|e.class==Sketchup::Face}
-
TIG: It's safe to group entities as long as they are in the same context, right? To move the face, why not group it, get it's definition, then place a new instance in the destination context and erase the old.
Avoiding having to manually recreate the faces with its loops and UV mapping etc.... -
@thomthom said:
To move the face, why not group it, get it's definition, then place a new instance in the destination context and erase the old.
Can you give the code sample,please(how to group it).I would like to test it.
-
It's working!!
I cannot believe it.I have a theory that nothing can work without testing.You are breaking this theory -
I always get uneasy when a code is run the first time without any errors...
-
It's only 100% safe to make a group directly with
ents.add_group(an_entities_array)
[or(an_entity)
]
if the 'ents' is themodel.active_entities
OR the same 'entities context'
Doing it across a mix of 'entities contexts' can cause Bugsplats ???
So then you normally make an empty group
group=ents.add_group()
and then add the entities to itsgroup.entities
; either by cloning raw geometry etc; or if it's a component, by using
instance2=group.entities.add_instance(instance.definition, instance.transformation)
or if it's a group, by using
group2=group.entities.add_instance(group.entities.parent, group.transformation)
If you are not immediately erasing the original 'group' then rungroup2.make_unique
on the new group because, otherwise they as as if they are components - changing one changing one changes the other - behavior not expected in groups which ought to only ever have one instance of their definition. -
If making a temp group of the face in situ works for you and you can then add an instance of that into another context and explode it and then erase the original face-group then that's good
... but if it splats you need to do it by 'cloning'
-
@thomthom said:
I always get uneasy when a code is run the first time without any errors...
Reading your code, the line
group.erase
makes me curious because the erase should be with the !.
So I discover that it was only half the code working.
But the result is ok.
So the working code is:def move_face(face, destination_entities ) source_entities = face.parent.entities entities = face.edges << face # I think you need to include all the edges related to the face group = source_entities.add_group( entities ) end
So the untested code theory remains
I will test it more,because of the Bugsplat fear. -
You need to add the
###... definition = group.entities.parent transformation = Geom::Transformation.new # Adjust to place where you want it. copy = destination_entities.add_instance( definition, transformation ) copy.explode # Ungroup the copied face group.erase**!** # Erase the original temp group
otherwise all your code does is move the face into a group that is in the in the same context the face was. I thought your aim was to move the face into another group ?
The methodmove_face( face, destination_entities )
takes the two arguments 'face' - the face to move; and 'destination_entities' - where you want it to end up - e.g.group2.entities
...
Thomthom's clever face>group,add_instance,explode,delete_original idea should work in this set of circumstances, without recourse to cloning...Note that this method 'moves' the face, and leaves it un-grouped - just as it was originally but now within another entities-context - if you want to copy the face into a group then the code needs tweaking - instead of deleting the original face [that's been grouped] withgroup.erase!
you usegroup.explode
to return the original face to its un-grouped state. -
<span class="syntaxdefault"><br />defĀ move_face</span><span class="syntaxkeyword">(</span><span class="syntaxdefault">Ā face</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">Ā destination_entitiesĀ </span><span class="syntaxkeyword">)<br /></span><span class="syntaxdefault">Ā Ā source_entitiesĀ </span><span class="syntaxkeyword">=</span><span class="syntaxdefault">Ā face</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">parent</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">entities<br />Ā Ā entitiesĀ </span><span class="syntaxkeyword">=</span><span class="syntaxdefault">Ā face</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">edgesĀ </span><span class="syntaxkeyword"><<</span><span class="syntaxdefault">Ā faceĀ </span><span class="syntaxcomment">#Ā IĀ thinkĀ youĀ needĀ toĀ includeĀ allĀ theĀ edgesĀ relatedĀ toĀ theĀ face<br /></span><span class="syntaxdefault">Ā Ā groupĀ </span><span class="syntaxkeyword">=</span><span class="syntaxdefault">Ā source_entities</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">add_group</span><span class="syntaxkeyword">(</span><span class="syntaxdefault">Ā entitiesĀ </span><span class="syntaxkeyword">)<br /></span><span class="syntaxdefault">Ā Ā definitionĀ </span><span class="syntaxkeyword">=</span><span class="syntaxdefault">Ā group</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">entities</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">parent<br />Ā Ā transformationĀ </span><span class="syntaxkeyword">=</span><span class="syntaxdefault">Ā Geom</span><span class="syntaxkeyword">;;</span><span class="syntaxdefault">Transformation</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">newĀ </span><span class="syntaxcomment">#Ā AdjustĀ toĀ placeĀ whereĀ youĀ wantĀ it.<br /></span><span class="syntaxdefault">Ā Ā copyĀ </span><span class="syntaxkeyword">=</span><span class="syntaxdefault">Ā destination_entities</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">add_instance</span><span class="syntaxkeyword">(</span><span class="syntaxdefault">Ā definition</span><span class="syntaxkeyword">,</span><span class="syntaxdefault">Ā transformationĀ </span><span class="syntaxkeyword">)<br /></span><span class="syntaxdefault">Ā Ā copy</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">explodeĀ </span><span class="syntaxcomment">#Ā UngroupĀ theĀ copiedĀ face<br /></span><span class="syntaxdefault">Ā Ā group</span><span class="syntaxkeyword">.</span><span class="syntaxdefault">erase</span><span class="syntaxkeyword">!</span><span class="syntaxdefault">Ā </span><span class="syntaxcomment">#Ā EraseĀ theĀ originalĀ tempĀ group<br /></span><span class="syntaxdefault">end<br /></span>
Note: completely un-tested. Just a theory
-
Grrr,it is only working if the group is edited (so in the same context).
Otherwise strange behaviour and Bugsplat anytime. -
As I suspected then...
Usingents.add_group(ent_array)
only works safely ifents==model.active_entities
So use my cloning tips...
Advertisement