[Plugin] FloorGenerator ( Updated 6-Apr-2017)

sdmitch

Sam I'm looking at your code here. Cant remember which version this is. So you may have changed this behavior.
But in a callback you have a dialog close ?

You have a select with an event onchange:

<select onChange='patternchanged(value)'>

The function then sends the callback

function patternchanged(value){
>    window.location='skp;PatternChanged@'+value;
> }

In the callback block you have a dlg.close. So everytime select change dialog closes..

@@dlg.add_action_callback("PatternChanged") {|d,p|
> 	@@opt=p; puts p
> 	if @@opt=="Reset" then 
> 						["Brick","Tile","Wood","Tweed","Hbone","BsktWv","HpScth","Hexgon","Octgon","Two2One" ,"IrPoly"].each{|o| 
>   Sketchup.write_default("FloorGenerator",o,nil)};@@opt="Tile";
>   end
>   @@dlg.close; @@dlg=nil; self.dialog
> }

I also see you have the command self.dialog trying to reopend the dialog ?
But it is set to nil before. Don't know if that messes things up..
Maybe a timing issue.

Edit: sorry meant to post this in the devlopper forum where you posted specific question. Copied and pasted wrong...

Yes I finally figured that all out. I just had to add a variable that I set to true if the PatternChanged and the window was closed and recreated. I deleted the post to the Developer forum as soon as I figured it out so as not to embarrass my self further.

jolran

Sam I'm looking at your code here. Cant remember which version this is. So you may have changed this behavior.
But in a callback you have a dialog close ?

You have a select with an event onchange:

<select onChange='patternchanged(value)'>

The function then sends the callback

function patternchanged(value){
   window.location='skp;PatternChanged@'+value;
}

In the callback block you have a dlg.close. So everytime select change dialog closes..

@@dlg.add_action_callback("PatternChanged") {|d,p|
	@@opt=p; puts p
	if @@opt=="Reset" then 
						["Brick","Tile","Wood","Tweed","Hbone","BsktWv","HpScth","Hexgon","Octgon","Two2One" ,"IrPoly"].each{|o| 
  Sketchup.write_default("FloorGenerator",o,nil)};@@opt="Tile";
  end
  @@dlg.close; @@dlg=nil; self.dialog
}

I also see you have the command self.dialog trying to reopend the dialog ?
But it is set to nil before. Don't know if that messes things up..
Maybe a timing issue ?

jolran

Ha ha ! Ah ok!

I thought I was getting high or something. One minute I thought I read about it in the developper section, then it was gone. So I removed my last sentence as well, just in case I was wrong

stagelight

Thank you for another great plugin !!
This is what I've been working on lately, with your script.

sdmitch

@stagelight said:

Thank you for another great plugin !!
This is what I've been working on lately, with your script.

It's a rather funny floor but a very nice bridge.

djrique

Thank you guy for that great plugin. I'm a brazilian and translated it for portuguese. Do you think that it's good?

sdmitch

@djrique said:

Thank you guy for that great plugin. I'm a brazilian and translated it for portuguese. Do you think that it's good?

Good by me.

djrique

Upload .Rb file PT-BR Language: https://drive.google.com/file/d/0BwqiSt9yjVQDVHZCM1JCOS1wb0U/edit?usp=sharing

i don´t know to create .rbz file...

THX.

sdmitch

@djrique said:

Upload .Rb file PT-BR Language: https://drive.google.com/file/d/0BwqiSt9yjVQDVHZCM1JCOS1wb0U/edit?usp=sharing

i don´t know to create .rbz file...

THX.

An .rbz file is just a .zip file with the extension changed to .rbz

Mistro11

Hope this render reflects my gratitude.

sdmitch

It's beautiful. Thanks for making me look so good.

sidewalk

Excellent plugin! A tool like this has been on my wishlist for years.

One suggestion: Is it possible to add an exterior clapboard/lap siding setting? The parameters could be very similar to the wood setting.

toto ete

great plugin! super work and thanks for sharing it!
keep up the wonderful work!

Pixero

Suddenly I get the same error as mentioned above.
When I change pattern the window closes.
I've re installed the latest version and tried it on two PCs.
Weird.

sdmitch

@pixero said:

Suddenly I get the same error as mentioned above.
When I change pattern the window closes.
I've re installed the latest version and tried it on two PCs.
Weird.

That makes no sense at all. Have you installed any new plugins lately? Maybe there is a conflict. Does the Ruby Console show any errors?

Pixero

Here is what the console reports:

Error; #<NoMethodError; undefined method `to_l' for nil;NilClass>
C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;93;in `dialog'
C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;67;in `initialize'
C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;34;in `new'
C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;34;in `block in <top (required)>'
-e;1;in `call'

As a side note, would it be possible to have a setting for bevel size?
Like if I want half or even a quarter of the size of the bevel.
And some min and max distance of the random imperfections?
I think both are a litte too big for most cases.

sdmitch

@pixero said:

Here is what the console reports:

Error; #<NoMethodError; undefined method `to_l' for nil;NilClass>
> C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;93;in `dialog'
> C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;67;in `initialize'
> C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;34;in `new'
> C;/Users/31jsa/AppData/Roaming/SketchUp/SketchUp 2014/SketchUp/Plugins/SDM_FloorGenerator_WD.rb;34;in `block in <top (required)>'
> -e;1;in `call'
>

As a side note, would it be possible to have a setting for bevel size?
Like if I want half or even a quarter of the size of the bevel.
And some min and max distance of the random imperfections?
I think both are a litte too big for most cases.

The error is occurring when the defaults are being read so use the "Reset" option first and hopefully that will clear up the problem.

I will consider your request as time permits.

Mra

I think there is a bug in the newest verision. On a rectangle it was complaining about non planar faces, even though this was off a box with sketchup box primitive.

Reverting back a version, I was then able to generate a wooden pattern on the same object.

sdmitch

@unknownuser said:

I think there is a bug in the newest verision. On a rectangle it was complaining about non planar faces, even though this was off a box with sketchup box primitive.

Reverting back a version, I was then able to generate a wooden pattern on the same object.

I have experienced the same problem with wood on vertical faces. I can't imagine why but will try to sort it out.

Thanks for the heads up

sdmitch

Problem has been fixed. Quality control and testing director has been severely punished.