[Plugin] TIG-Smart_offset

ccbiggs

Hey Tig,
I am getting the same thing Jeff has. But since Jeff actually knows what he is doing, he can do the ruby troubleshooting. Will stay tuned to see what you fellas figure out.
It works great on my windows machine at home.
Thanks Tig

Update
Jeff says his works. It does not work on my mac.
with nothing preselected TIG::Smart_offsetter.suitable?()

TIG::Smart_offsetter.suitable?()
false

with one edge preselected TIG::Smart_offsetter.suitable?()

TIG::Smart_offsetter.suitable?()
false

with one face preselected TIG::Smart_offsetter.suitable?()

TIG::Smart_offsetter.suitable?()
true

with lots of things [including some edges] preselected TIG::Smart_offsetter.suitable?()

TIG::Smart_offsetter.suitable?()
true

with one edge preselected TIG::Smart_offsetter.dialog()
TIG.Smart_offset:

PreSelect Face[s] !

with one face preselected TIG::Smart_offsetter.dialog()
Offset [+/-ve=out/

My drop down "Tools" Menu works with a face preselected. The toolbar does not.
Nothing works with just edges selected.
If you need me to check anything else, and I do not get right back to ya, I am not ignoring you I am just here there and everywhere today.

TIG

Here's v1.3 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
Removed 'suitable?' method, to suit MACs, more error traps etc.
Try this and report back...

ccbiggs

It works the same for me. With a face selected the drop down tools menu item will work but the single icon toolbar will not.

TIG

@ccbiggs said:

It works the same for me. With a face selected the drop down tools menu item will work but the single icon toolbar will not.
Which is weird... because they BOTH use 'cmd' and share the same enabled/grayed code...
To check that the toolbar WILL work somehow... can you please edit the file 'TIG-Smart_offset.rb' on your MAC with a plain text editor [BBedit???] and find the three lines starting at #117 reading:

		cmd.set_validation_proc{
			Sketchup.active_model.selection.grep(Sketchup;;Face)[0] ? MF_ENABLED ; MF_GRAYED
		}

and change them to read

		#cmd.set_validation_proc{
			#Sketchup.active_model.selection.grep(Sketchup;;Face)[0] ? MF_ENABLED ; MF_GRAYED
		#}

i.e. add a # in front of each of the three lines to disable them.
Now the tool's command should always be 'enabled' in the menu & the toolbar button, if you try to use it without a Face in the Selection you'll get an error messagebox...
Let me know how this goes...

Incidentally, BEFORE [& after] you make the changes... do you get the tool's context-menu item IF there's a Face in the Selection ?

jeff hammond

@tig said:

To check that the toolbar WILL work somehow... can you please edit the file 'TIG-Smart_offset.rb' on your MAC with a plain text editor [BBedit???] and find the three lines starting at #117 reading:

		cmd.set_validation_proc{
> 			Sketchup.active_model.selection.grep(Sketchup;;Face)[0] ? MF_ENABLED ; MF_GRAYED
> 		}

and change them to read

		#cmd.set_validation_proc{
> 			#Sketchup.active_model.selection.grep(Sketchup;;Face)[0] ? MF_ENABLED ; MF_GRAYED
> 		#}

i.e. add a # in front of each of the three lines to disable them.

that does the trick.. the toolbar is always active now and i'll just receive an error if i try to run the tool without an appropriate selection..

[context menu works also.. but it worked prior to disabling the above lines]

TIG

OK !
The current tool [v1.3] works just fine for PCs... but it baulks on a MAC with some of the enable/grayed code for the toolbar button - which is weird...

The editing of the three lines of code in the script to disable them with a leading #... as indicated in the preceding posts... will fix it for MAC users...

I'll see if I can get a version working properly for PC and MAC without this cludge !

In the meantime, please report any issues...

Merry Xmas
Apocalypse averted!
Phew!

simon le bon

Thank you for this one really "smart" dear TIG +++
We were used to the quirks of the native offset tool as a fatality. It is a surprise to realize that it was not the case

Merry Christmas to you too

Simon

driven

@tig said:

I'll see if I can get a version working properly for PC and MAC without this cludge !

I posted this on the first page and it will work on both?
set validation doesn't seem to work on macs on Toolbars

cmd2=UI;;Command.new('TIG.Smart_offset'){self.dialog()}
cmd2.small_icon=File.join(dir, 'TIG-Smart_offset.png')
cmd2.large_icon=File.join(dir, 'TIG-Smart_offset.png')
toolbar=UI;;Toolbar.new('TIG.Smart_offset')
toolbar.add_item(cmd2)

john

TIG

Here's v1.4 http://sketchucation.com/forums/viewtopic.php?p=446462#p446462
It now only applies toolbar enabled/grayed [validation] on PCs; on a MAC the toolbar button is always enabled, but when you attempt to use it without a suitable preselection there's an error-messagebox...
This now means PC and MAC users should have a quite similar usage

DareDevil

Thanks for this advanced tool ! Nice to solve round edge offset.

But I have a two requests :
First, (crossing post with Pilou ) I think when the offset cross itself, there is a chance it make a hole. Your Smart Offset fill all the shape. It will be cool if your toll can solve this case.

The second is a bonus setting to create a round offset like this :
I don't know if it's "easy" to make this kind of function, perhaps crossing your offset tool and your Chamfer tool from 2D Tools.

pilou

From Daredevil
Original
Smart_Offest
Normal result wished

TIG

DareDevil/Pilou

I had been following your discussions about this in the French forum...
I know what you are asking for, but it is very complicated to come up with an algorithm to remove the 'hole' - it's easy for us to 'see' what's to go and what's to stay, but in code it is very complicated to ensure that the unwanted parts are removed.
If anyone has any ideas [even seemingly silly ones?] I am open to suggestions...

On the 'rounded corner' matter... This effectively a 'multi-fillet' tool.
The main issue I see in you'd need to select just the edges to fillet and not a face, otherwise in the case you illustrated the already curved part would potentially get 'multi-filleted'...

That's x6 clicks to select the ones needed with a new tool - or x2 to select face & its-edges, then x2+Ctrl+Shift to remove the face and the unwanted arc [or +x1 click to make a fence, e.g. for an 'arc' made from exploded edges...] - say x4 or x5...
OR using the existing 2dFillet tool x2 per vertex = x10 clicks.
But are your few extra clicks worth my lost brain-cells needed to contrive this wonder ?

pilou

For the multi fillet
Surely not but don't forget the pleasure to find the solution!

numerobis

WOW!!! This is really helpful! Great! Thank you very much!!!
And Merry Christmas to you too!

takesh h

"Smart TIG" offsets indeed!

jeff hammond

@unknownuser said:

For the multi fillet
Surely not but don't forget the pleasure to find the solution!

that pleasure would be nothing compared to the pleasure experienced by figuring this one out

the inner pie was offset on both.. sketchup offset gives the result on the left.. the right one is how it should be.. (and besides.. TIG-Genius_offset.rb has a nice ring to it : )

rv1974

TIG, marry Xmas and thank you for this great present.
P.S. Could you take a look at attached?
P.P.S. a. It'd be neat if this tool was mode-less (I mean replicating the native SU behavior)
b. a number of offset option???

some segments offset wrong way

jolran

Thank you TIG and Merry Christmas!

This one is a difficult task.

JClements

Thank you, Santa TIG. Milk and cookies will await you Xmas morning.

Any chance of having:
1- a "Weld Offset" option button in the dialog
or
2- have the offset automatically welded if its source-edges were made from the circle, arch, polygon tools or previously "welded" edges?

Regards, John

matt.gordon320

Thanks TIG! I don't think I could have asked for a better Christmas/World not ending present!