[Plugin] CleanUp

thomthom

There is an "unwanted" feature in this plugin (I do not necessarily want to call it a "bug"); it erases coplanar edges also when that edge divides faces where the same material applied but positioned differently. See screenshots attached.

hmm... Yes - I see how this can be an issue. Will need to ponder on how to avoid this though.

@gaieus said:

Thanks for looking into this issue - this is the best ever cleanup script I have ever encountered. aybe abother wish - could there be a feature/setting to clean up only whatever is in context (like inside a goup) and/or in a certain selection?
Or maybe I missed something?

Yea - the UI is horrible.

Gaieus

Hm. Can I have another (older?) version?

thomthom

No - I seem to have extra menu items from working on v1.2.0 oopsie

Gaieus

I tried to lock such faces with positioned materials but the script erases lines in locked groups, too!

thomthom

@gaieus said:

I tried to lock such faces with positioned materials but the script erases lines in locked groups, too!

That's interesting. Another thing to note down.

thomthom

Armed with more info from Simone Nicolo I now have a better method for detecting coplanar faces - the same method Sketchup use. I think it's 100% reliable. No more messing about with tolerances.

Highly recommended update!

thomthom

@thomthom said:

Armed with more info from Simone Nicolo I now have a better method for detecting coplanar faces - the same method Sketchup use. I think it's 100% reliable. No more messing about with tolerances.

Highly recommended update!

Turns out it's not 100%. In one of my test model it still left some edges that could be erased.

Updated with some minor UI fixes.

EscapeArtist

"The selected attachment does not exist anymore"

Error when clicking for download.

thomthom

@escapeartist said:

"The selected attachment does not exist anymore"

Error when clicking for download.

You probably tried to download just as I uploaded a quick patch.

CadFather

Thanks Thom, this is good.

EscapeArtist

@thomthom said:

You probably tried to download just as I uploaded a quick patch.

Ah, timing is everything. Works just fine. Thanks!

MtnTrails

Thank you, Thom! Works just like I'd hoped. What a great time saver!

Gaieus

Hi Thom,

Thanks for the update. I'll definitely try it out (I managed to forget about two coplanar faces with differently positioned but the same texture again and screwed up my model - no big hassle though just a "doh" moment again...)

thomthom

@gaieus said:

Hi Thom,

Thanks for the update. I'll definitely try it out (I managed to forget about two coplanar faces with differently positioned but the same texture again and screwed up my model - no big hassle though just a "doh" moment again...)

Ah yes - I'm still not sure how to account for that. But it is possible ... somehow...

Rich O Brien

Hi Thom,

Thanks for the update, one of my favourite plugins.
Doesnt say much about my modelling ability!

thomthom

Important update in 1.2.2
Sorry for all these updates recently.
I think I found the root of why the last update wasn't 100%.

It now erases edges as they are processes, instead of in bulk later. This is because each face's plane equations must be re-evaluated after it's been merged. This might lead to slightly longer processing time - but I now hope that it truly is 100% watertight.

EarthMover

Thanks for the update. I use this puppy all the time!

Jim

Thanks - it is doing better job of removing edges. I am willing to trade a little extra time for a cleaner model.

I did get a reference to a deleted Edge error on this model (.stl import.) I haven't investigated the cause, but I've attached it in case you're curious.

Error: #<TypeError: reference to deleted Edge> C:\Program Files\Google\Google SketchUp 7\Plugins\tt_cleanup.rb:283:infaces'`

My fix:
283: next unless e.valid? and e.is_a?(Sketchup::Edge)

But is doesn't explain the cause.

moai.skp

thomthom

hm.. that is odd. I wonder why that happens. thanks for posting the model.

thomthom

Updated to account for the issue reported by Jim.

Though I still don't understand why I ever get a reference to a deleted edge...