• 登入
sketchucation logo sketchucation
  • 登入
⚠️ Libfredo 15.4b | Minor release with bugfixes and improvements Update

[code] ComponentDefinition-delete (another version!)

已排程 已置頂 已鎖定 已移動 Developers' Forum
22 貼文 5 Posters 4.0k 瀏覽 5 Watching
正在載入更多貼文
  • 從舊到新
  • 從新到舊
  • 最多點贊
回覆
  • 在新貼文中回覆
登入後回覆
此主題已被刪除。只有擁有主題管理權限的使用者可以查看。
  • A 離線
    AlexMozg
    最後由 編輯 2009年3月31日 下午10:16

    This script adds a new method for a Sketchup::ComponentDefinition class.
    component_definition.delete
    This is another version different from the version published previously.
    The method is implemented for Sketchup versions 5-7.
    In Sketchup version 7 provided the most complete functionality.
    Method is faster, because the method "purge_unused" is not used.
    Test and enjoy! 😄

    At the end of the file a small example of use.


    TIG version: http://www.sketchucation.com/forums/scf/viewtopic.php?f=180&t=17962


    AT-ComponentDefinition-delete.rb

    1 條回覆 最後回覆 回覆 引用 0
    • T 離線
      thomthom
      最後由 編輯 2009年3月31日 下午10:39

      Wow. Two days ago I was grumbling over the lack of such a method. Now they're all over the place. 😄
      👍

      Thomas Thomassen — SketchUp Monkey & Coding addict
      List of my plugins and link to the CookieWare fund

      1 條回覆 最後回覆 回覆 引用 0
      • E 離線
        Edson
        最後由 編輯 2009年4月1日 上午11:54

        guys, forgive my dumbness but what exactly does this script do????

        i suspect i am not alone in this. so far the presentation and discussion of this and the previous similar script was so technical that i bet very few forum members understood what it is about.

        thanks.

        edson mahfuz, architect| porto alegre • brasil
        http://www.mahfuz.arq.br

        1 條回覆 最後回覆 回覆 引用 0
        • T 離線
          thomthom
          最後由 編輯 2009年4月1日 上午11:57

          It's meant for scripters and not for end users.
          Maybe it should be tagged [code] instead?

          Thomas Thomassen — SketchUp Monkey & Coding addict
          List of my plugins and link to the CookieWare fund

          1 條回覆 最後回覆 回覆 引用 0
          • E 離線
            Edson
            最後由 編輯 2009年4月1日 下午12:14

            @thomthom said:

            It's meant for scripters and not for end users.
            Maybe it should be tagged [code] instead?

            it figures. and i agree about the tagging suggestion. thanks.

            edson mahfuz, architect| porto alegre • brasil
            http://www.mahfuz.arq.br

            1 條回覆 最後回覆 回覆 引用 0
            • T 離線
              TIG Moderator
              最後由 編輯 2009年4月1日 下午12:23

              Some 'plugins' are 'methods', which add extra functions onto existing tools.
              I'll use [ code ] for mine - good idea...

              While we have built-in things like "ComponentDefinition.entities" there is [was] no way of deleting a specific definition. This particular method "ComponentDefinition.delete" mimics what you can do in the component-browser's right-click context menu, and deletes a definition and its instances. It's main use is to tidy up in a script after you have made some temporary [and ultimately unused] definitions that would clog up the browser unless they are deleted. The built-in "Definitions.purge_unused" would do it, BUT that also removes other unrelated unused definitions that you might want later !

              You could use it thus: select a component instance, then in the Ruby script (or console)...

              SketchUp.active_model.selection[0].definition.delete
              

              [This finds the instance's definition and deletes it from the model data-base, and erases any other instances that were placed - please don't use it in the console except as an example since it's quicker to use the context-menu in the browser...]

              If you read the notes at the start of such scripts they should clarify what they do...

              This script - and for example its loosely related "ComponentInstance-add_entities.rb" [developed because in Ruby you could only 'add entities' to a ComponentDefinition before this was written] - get developed to sort out specific problems with other developers' scripts - however publishing here does allow others to see them - they might also have need of them or similar ideas...

              TIG

              1 條回覆 最後回覆 回覆 引用 0
              • T 離線
                TIG Moderator
                最後由 編輯 2009年4月1日 下午12:27

                Alex

                I first tried your method to erase the definition.instances and then erase all of the definition's entities, so the empty definition is gone from the browser.
                This works manually, as SketchUp removes an empty definition from the component-browser.
                However, when I used the ...entities_erase(...) method in a script it emptied the definition BUT it didn't remove it from the browser - if you then picked it in the browser = BugSplat !

                I can''t see any difference between your version and my early attempt - only slightly different syntax, but same result - HOWEVER yours works ! Since yours is better than mine - not needing convoluted purging - I'll withdraw mine and adjust my related tools...

                .

                TIG

                1 條回覆 最後回覆 回覆 引用 0
                • T 離線
                  thomthom
                  最後由 編輯 2009年4月1日 下午9:09

                  I think this method should delete any existing instances belonging to the definition as it doesn't remove the definition when there's instances around.

                  EDIT: hmm... this is odd. When I run it through the console on a fresh model: Sketchup.active_model.definitions[0].delete it deletes Sang and removes it from the Component Browser.

                  But when I implement it into my working plugin, the component remains in the browser and will bugsplat if I try to place it... hm...

                  Thomas Thomassen — SketchUp Monkey & Coding addict
                  List of my plugins and link to the CookieWare fund

                  1 條回覆 最後回覆 回覆 引用 0
                  • A 離線
                    AlexMozg
                    最後由 編輯 2009年4月1日 下午10:27

                    @thomthom said:

                    But when I implement it into my working plugin, the component remains in the browser and will bugsplat if I try to place it... hm...

                    Therefore I foresaw additional possibility of the use of this method.
                    Use this method with the argument false, if you do not want to begin a new operation and correct forming "undo".
                    Essence consists in correct determination of start [ start_operation ]
                    and end [ commit_operation ] of operation!
                    It most important, bugsplat is otherwise possible!

                    
                    def my_new_plugin
                       model = Sketchup.active_model
                       model.start_operation "New Operation"
                       definitions = model.definitions
                    #....................................
                    #....................................
                    #....................................
                       definitions[0].delete(false) if definitions.to_a[0]
                       definitions[1].delete(false) if definitions.to_a[1]
                       definitions[2].delete(false) if definitions.to_a[2]
                    #....................................
                    #....................................
                    #....................................
                       model.commit_operation
                    end
                    
                    

                    If I understood correctly...

                    P.S
                    When I tested, bugsplat repeated oneself too often... 😞
                    I maximally tried to foresee all possibilities of bugsplat appearance and prevent them.

                    By the way, my example at the end of file "AT-ComponentDefinition-delete.rb" it is possible to delete or comment out if he will not be used.

                    1 條回覆 最後回覆 回覆 引用 0
                    • T 離線
                      thomthom
                      最後由 編輯 2009年4月2日 上午6:27

                      I removed the example code. I also didn't use a start_operation on my own code.

                      Thomas Thomassen — SketchUp Monkey & Coding addict
                      List of my plugins and link to the CookieWare fund

                      1 條回覆 最後回覆 回覆 引用 0
                      • A 離線
                        AlexMozg
                        最後由 編輯 2009年4月2日 上午6:41

                        Bugsplat also can be at the use of method of "erase!" between "start_operation" and "commit_operation".

                        1 條回覆 最後回覆 回覆 引用 0
                        • T 離線
                          thomthom
                          最後由 編輯 2009年4月2日 上午6:42

                          Another thought: Not too sure if it's good that there's two differents methods available with the same name. What if one plugin implements one method and another plugin implements the other. Since the method integrates with the SU native class there's no way to avoid conflict.

                          Can we decide on one?

                          Thomas Thomassen — SketchUp Monkey & Coding addict
                          List of my plugins and link to the CookieWare fund

                          1 條回覆 最後回覆 回覆 引用 0
                          • A 離線
                            AlexMozg
                            最後由 編輯 2009年4月2日 上午6:58

                            You can use a not method (ComponentDefinition.delete), but idea:

                            definition.entities.erase_entities definition.entities.to_a
                            

                            between
                            model.start_operation ("")
                            and
                            model.commit_operation

                            Sometimes so simpler...

                            1 條回覆 最後回覆 回覆 引用 0
                            • T 離線
                              thomthom
                              最後由 編輯 2009年4月2日 上午7:30

                              @alexmozg said:

                              You can use a not method (ComponentDefinition.delete), but idea:

                              definition.entities.erase_entities definition.entities.to_a
                              

                              between
                              model.start_operation ("")
                              and
                              model.commit_operation

                              Sometimes so simpler...

                              So that's the core of it? The commit operation initiates SU to purge the empty definition? I couldn't really work out how your code worked. So I suppose that something in my code interferes with this?

                              Thomas Thomassen — SketchUp Monkey & Coding addict
                              List of my plugins and link to the CookieWare fund

                              1 條回覆 最後回覆 回覆 引用 0
                              • T 離線
                                TIG Moderator
                                最後由 編輯 2009年4月2日 上午8:39

                                @thomthom said:

                                Another thought: Not too sure if it's good that there's two different methods available with the same name. What if one plugin implements one method and another plugin implements the other. Since the method integrates with the SU native class there's no way to avoid conflict.

                                Can we decide on one?

                                I'll remove mine from the forum now...
                                As AlexM points out using the:

                                model.start_operation("Delete Definition")
                                  definition.entities.erase_entities(definition.entities.to_a)
                                model.commit_operation
                                

                                it has been discovered how to do what we want anyway without a new method at all...

                                TIG

                                1 條回覆 最後回覆 回覆 引用 0
                                • F 離線
                                  Frankn
                                  最後由 編輯 2014年2月14日 上午4:20

                                  @tig said:

                                  it has been discovered how to do what we want anyway without a new method at all...

                                  Sorry to bring back a very old post/topic but I'm trying to delete definitions and I tried using the code AlexMozg wrote but I'm having problems with it and to be honest I don't really understand how the code works so I'm not sure what's going wrong.

                                  The error I get is... Error: #<TypeError: reference to deleted ComponentDefinition>

                                  Is there another way to do this if not what should I be looking for in regards to the problem I'm having?

                                  Thanks.

                                  1 條回覆 最後回覆 回覆 引用 0
                                  • T 離線
                                    TIG Moderator
                                    最後由 編輯 2014年2月14日 下午12:21

                                    If you want to delete ALL definitions in a model [use with care!]
                                    A one-liner like:

                                    m=Sketchup.active_model;m.start_operation('!');m.definitions.each{|d|d.entities.clear!};m.commit_operation
                                    

                                    does it.

                                    BUT if you want to delete just the definitions of Selected component-instances [and of course the instances will vanish too] use:

                                    m=Sketchup.active_model;m.start_operation('!');ds=[];m.selection.grep(Sketchup;;ComponentInstance).each{|i|ds<<i.definition};ds.uniq.each{|d|d.entities.clear!};m.commit_operation
                                    

                                    this way you make an array of all affected definitions and process those just once each - otherwise, if you have two instances selected of the same definition, then the second instance processed has an invalid 'deleted definition' so it will fail etc...

                                    TIG

                                    1 條回覆 最後回覆 回覆 引用 0
                                    • F 離線
                                      Frankn
                                      最後由 編輯 2014年2月15日 上午3:25

                                      Thanks TIG,

                                      The second code is what I'm looking to do but I'm getting this error...
                                      Error: #<NoMethodError: undefined method `confirm_operation' for #Sketchup::Model:0x8e9a4b4>

                                      Also I tried selecting the definition I want to delete with this but it doesn't seem to work

                                      @model.selection.add(#<Sketchup;;ComponentDefinition;0xbcd77a0>)
                                      

                                      I forgot to mention that if I manually select the instance it does delete it and the parent from the components viewer but leaves the subcomponents.

                                      I'm still trying to figure out what your code does, this is a little over my pay grade! 😕

                                      1 條回覆 最後回覆 回覆 引用 0
                                      • F 離線
                                        Frankn
                                        最後由 編輯 2014年2月15日 上午4:51

                                        Ok so after a beer break I figured out why I couldn't select the instance... I was trying to select the definition! 😳

                                        When I comment out m.confirm_operation everything seems to work but obviously there's something wrong with the code or I wouldn't need to comment it out.

                                        1 條回覆 最後回覆 回覆 引用 0
                                        • F 離線
                                          Frankn
                                          最後由 編輯 2014年2月15日 上午6:48

                                          Here's something interesting/weird that's happening...

                                          After I delete the definition I iterate through model.definitions just to make sure everything was getting deleted but I found that the parent instance isn't getting deleted and the names of the subcomponents aren't getting deleted either... which causes the new component being created to be renamed with #1 at the end...

                                          Any idea why?

                                          1 條回覆 最後回覆 回覆 引用 0
                                          • 1
                                          • 2
                                          • 1 / 2
                                          • 第一個貼文
                                            最後的貼文
                                          Buy SketchPlus
                                          Buy SUbD
                                          Buy WrapR
                                          Buy eBook
                                          Buy Modelur
                                          Buy Vertex Tools
                                          Buy SketchCuisine
                                          Buy FormFonts

                                          Advertisement