sketchucation logo sketchucation
    • Login
    ℹ️ Licensed Extensions | FredoBatch, ElevationProfile, FredoSketch, LayOps, MatSim and Pic2Shape will require license from Sept 1st More Info

    Optimization Tips

    Scheduled Pinned Locked Moved Developers' Forum
    110 Posts 22 Posters 168.8k Views 22 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • C Offline
      cjthompson
      last edited by

      @cjthompson said:

      Has anyone looked into Enumerable.grep()? it seems pretty useful, but I don't know how fast it is.

      well, since no one seems to be listening... 😒
      I ran my own test (for: is using a for loop, grep: is using Enumerable.grep)
      speedTest for: entities - 0.016 grep: entities - 0.015 for: entities array - 0.0 grep: entities array - 0.016 for: range - 0.219 grep: range - 0.203 for: range array - 0.219 grep: range array - 0.218 for: strings - 0.469 grep: strings - 0.234 nil

      here is the code I used:

      def speedTest
      	entities = Sketchup.active_model.entities
      	entitiesArray = entities.to_a
      	range = 0..1000000
      	rangeArray = range.to_a
      	strings = range.collect{|number| number.to_s}
      	
      	## Entities
      	
      	results = []
      	start = Time.now
      	for ent in entities
      		if(ent.class == Sketchup;;Edge)
      			results << ent
      		end
      	end
      	puts "for; entities - " + (Time.now - start).to_s
      	
      	results = []
      	start = Time.now
      	results = entities.grep(Sketchup;;Edge)
      	puts "grep; entities - " + (Time.now - start).to_s
      	
      	## Entities array
      	
      	results = []
      	start = Time.now
      	for ent in entitiesArray
      		if(ent.class == Sketchup;;Edge)
      			results << ent
      		end
      	end
      	puts "for; entities array - " + (Time.now - start).to_s
      	
      	results = []
      	start = Time.now
      	results = entitiesArray.grep(Sketchup;;Edge)
      	puts "grep; entities array - " + (Time.now - start).to_s
      	
      	## Range
      	
      	results = []
      	start = Time.now
      	for num in range
      		if(num == 318256)
      			results << num
      		end
      	end
      	puts "for; range - " + (Time.now - start).to_s
      	
      	results = []
      	start = Time.now
      	results = range.grep(318256)
      	puts "grep; range - " + (Time.now - start).to_s
      	
      	## Range Array
      	
      	results = []
      	start = Time.now
      	for num in rangeArray
      		if(num == 318256)
      			results << num
      		end
      	end
      	puts "for; range array - " + (Time.now - start).to_s
      	
      	results = []
      	start = Time.now
      	results = rangeArray.grep(318256)
      	puts "grep; range array - " + (Time.now - start).to_s
      	
      	## Strings
      	
      	results = []
      	start = Time.now
      	for str in strings
      		if(str.match(/312\Z/))
      			results << str
      		end
      	end
      	puts "for; strings - " + (Time.now - start).to_s
      	
      	results = []
      	start = Time.now
      	results = range.grep(/312\Z/)
      	puts "grep; strings - " + (Time.now - start).to_s
      	
      end
      

      and the model I tested on:


      test1k.skp

      1 Reply Last reply Reply Quote 0
      • thomthomT Offline
        thomthom
        last edited by

        I also read that depending on the settings of the compiler the instruction set used to compute sqrt and it's performance vary greatly. One of the articles I read suggested that many compilers will use old set of instructions by default for greater compatibility.
        What do you do for your projects?

        Edit: one of the articles I read: http://assemblyrequired.crashworks.org/2009/10/16/timing-square-root/

        Thomas Thomassen β€” SketchUp Monkey & Coding addict
        List of my plugins and link to the CookieWare fund

        1 Reply Last reply Reply Quote 0
        • P Offline
          Pout
          last edited by

          concerning typename vs class:

          For, till now, unexplained reason when i change typename with class the results are different
          Script is a bit like this:

          x=entity.class (or entity.typename)
          if x=="Face"
          do something
          elsif x=="Group"
          do something
          elsif x=="ComponentInstance"
          do something
          else
          end
          

          When the type is "ComponentInstance" the results are not the same for class and typename.
          I need to check on this since the speed increase is huge

          1 Reply Last reply Reply Quote 0
          • thomthomT Offline
            thomthom
            last edited by

            .class returns a Class object - not a string.
            What causes the slow down is the string comparison - that's what you want to avoid.

            
            x=entity.class
            if x==Sketchup;;Face
              do something
            elsif x==Sketchup;;Group
              do something
            elsif x==Sketchup;;ComponentInstance
              do something
            else
            end
            
            

            or

            
            if entity.is_a?(Sketchup;;Face)
              do something
            elsif entity.is_a?(Sketchup;;Group)
              do something
            elsif entity.is_a?(Sketchup;;ComponentInstance)
              do something
            else
            end
            
            

            Update: fixed is_? to is_a?

            Thomas Thomassen β€” SketchUp Monkey & Coding addict
            List of my plugins and link to the CookieWare fund

            1 Reply Last reply Reply Quote 0
            • P Offline
              Pout
              last edited by

              I'll check and let you know. When i use 'class' the correct conditions are entered but the result differs.
              I'll keep you posted if it changes with your scripts.

              Thx

              1 Reply Last reply Reply Quote 0
              • P Offline
                Pout
                last edited by

                all works, speeds increase is fine πŸ˜„
                thx!

                1 Reply Last reply Reply Quote 0
                • thomthomT Offline
                  thomthom
                  last edited by

                  πŸ‘

                  Thomas Thomassen β€” SketchUp Monkey & Coding addict
                  List of my plugins and link to the CookieWare fund

                  1 Reply Last reply Reply Quote 0
                  • K Offline
                    kwalkerman
                    last edited by

                    One thing I have noticed is that some code runs much slower with the outliner window open. Is there a way to close the window at the start of certain code execution, and then re-open it at the end?

                    --
                    Karen

                    1 Reply Last reply Reply Quote 0
                    • Dan RathbunD Offline
                      Dan Rathbun
                      last edited by

                      @kwalkerman said:

                      One thing I have noticed is that some code runs much slower with the outliner window open. Is there a way to close the window at the start of certain code execution, and then re-open it at the end?

                      Maybe...
                      but have you tried using Model.start_operation ?

                      see also abort_operation and commit_operation

                      I'm not here much anymore.

                      1 Reply Last reply Reply Quote 0
                      • Dan RathbunD Offline
                        Dan Rathbun
                        last edited by

                        UI.show_inspector "Outliner"
                        toggles it.
                        Shows it if it's closed
                        Rolls it up if it's shown
                        Unrolls it if it's rolled up

                        There's no way with the API to tell (now) what state it is in.

                        I'm not here much anymore.

                        1 Reply Last reply Reply Quote 0
                        • TIGT Offline
                          TIG Moderator
                          last edited by

                          I think Jim made a Windows hack to toggle a rollup...

                          ### toggleWindows.rb - based on Jim's ideas - only for Windows...
                          ### 20090401 TIG
                          ### needs "win32api.so"
                          if [PLATFORM].grep(/mswin/)==[PLATFORM] and Sketchup.find_support_file("Win32API.so","Plugins/")
                          ### = a Windows machine
                            require 'Win32API.so'
                            def toggleRollUp(name)
                              findWindow = Win32API.new("user32.dll","FindWindow",['P','P'],'N')
                              pw=findWindow.call(0,name)
                              sendMessage = Win32API.new("user32.dll","SendMessage",['N','N','N','P'],'N')
                              sendMessage.call(pw,0x00a1,2,"")#WM_NCLBUTTONDOWN
                              sendMessage.call(pw,0x0202,0,"")#WM_LBUTTONUP
                            end
                            def isRolledUp(name)
                              findWindow = Win32API.new("user32.dll","FindWindow",['P','P'],'N')
                              getWindowRect= Win32API.new("user32.dll","GetWindowRect",['P','PP'],'N')
                              pw=findWindow.call(0,name)
                              data=Array.new.fill(0.chr,0..4*4).join
                              getWindowRect.call(pw,data);
                              rect=data.unpack("i*")
                              #if window height is less than 90 then the window is rolledup
                              return (rect[3]-rect[1])<90
                            end
                          end#if
                          

                          You add 'Outliner' to run it... test if rolled up, toggle roll up if not etc etc........

                          TIG

                          1 Reply Last reply Reply Quote 0
                          • Dan RathbunD Offline
                            Dan Rathbun
                            last edited by

                            its nice but...
                            The windows have other language names in the loacalized versions.
                            The code needs updating. It needs to search by ID instead.
                            (Or have arrays of the Inspector captions in all the local versions.)

                            It also should be in the SKX forum, either as a UI module extended method (which would be half done, as it's only Win32,) or a SKX::GUI::WIN method.. or something

                            I'm not here much anymore.

                            1 Reply Last reply Reply Quote 0
                            • TIGT Offline
                              TIG Moderator
                              last edited by

                              I only pass on Jim's hack... if you want to 'fix' it please do... It'd be better if the API had proper access to these anyway !

                              TIG

                              1 Reply Last reply Reply Quote 0
                              • K Offline
                                kwalkerman
                                last edited by

                                Dan, this is absolutely what I need. It is the updating of the UI that is slowing the calculation down. Having the outliner window open compounds the problem.

                                --
                                Karen

                                1 Reply Last reply Reply Quote 0
                                • thomthomT Offline
                                  thomthom
                                  last edited by

                                  @kwalkerman said:

                                  Dan, this is absolutely what I need. It is the updating of the UI that is slowing the calculation down. Having the outliner window open compounds the problem.

                                  --
                                  Karen

                                  You are using .start_operation with the disable_ui flag, right?

                                  Also, try to do as much as possible in bulk operations. Transform and erase in bulks. entities.erase_entities instead of entity.erase! etc.
                                  Cache calculation results - Ruby is horribly slow in crunching numbers.
                                  Often, methods that accepts Point3D objects can use Vertex objects as well - though the API docs doesn't mention this. If you are doing many iteration vertex.position will eat time. So try to feed the methods raw vertices instead.

                                  Thomas Thomassen β€” SketchUp Monkey & Coding addict
                                  List of my plugins and link to the CookieWare fund

                                  1 Reply Last reply Reply Quote 0
                                  • Dan RathbunD Offline
                                    Dan Rathbun
                                    last edited by

                                    @dan rathbun said:

                                    its nice but...
                                    The code needs updating. It needs to search by ID instead.
                                    (Or have arrays of the Inspector captions in all the local versions.)

                                    Ooops.. just checked. The Outliner does not have an ID.
                                    But Jim's system call 'may' work. The window object can have a different "name" than the text displayed on the caption bar.
                                    Someone running a non-English version could test it and let us know.

                                    I'm not here much anymore.

                                    1 Reply Last reply Reply Quote 0
                                    • Dan RathbunD Offline
                                      Dan Rathbun
                                      last edited by

                                      @dan rathbun said:

                                      @dan rathbun said:

                                      The code needs updating. ...
                                      (Or have arrays of the Inspector captions in all the local versions.)

                                      But Jim's system call 'may' work. The window object can have a different "name" than the text displayed on the caption bar.

                                      Someone running a non-English version could test it and let us know.

                                      Didier tested it and the results are both good and bad:
                                      see: Re: Anyone with non-english Sketchup?

                                      I'm not here much anymore.

                                      1 Reply Last reply Reply Quote 0
                                      • J Offline
                                        jessejames
                                        last edited by

                                        @thomthom said:

                                        What I found most interesting in those test was that Vertex is a valid argument where the manual claims only Point3d. And passing the Vertex is faster than Vertex.position.

                                        Well i think you'll find this is a commonality of the API and the Docs is the fact that "those" who are creating the API and the Docs ARE NOT "those" who use it on a daily basis! πŸ˜‰

                                        Always sleep with a loaded gun under your pillow!

                                        1 Reply Last reply Reply Quote 0
                                        • J Offline
                                          Jernej Vidmar
                                          last edited by

                                          Hi guys,

                                          I have just found out that converting String to Length directly is up to 13x slower in comparision to converting it to Float first and only then to Length...

                                          
                                          def string_to_length_conversion(iterations=100_000)
                                          	a=0
                                          	t1=Time.now.to_f
                                          	iterations.times do
                                          		# convert to Length directly
                                          		a = '5,0'.to_l
                                          	end
                                          	t2=Time.now.to_f
                                          	puts "Conversion to Length directly took #{t2-t1} sec, a=#{a}"
                                          
                                          	t1=Time.now.to_f
                                          	iterations.times do
                                          		# convert to Float, then apply units (meters in this case) and set to Length
                                          		a = '5,0'.to_f.m.to_l
                                          	end
                                          	t2=Time.now.to_f
                                          	puts "Conversion to Length via Float took #{t2-t1} sec, a=#{a}"
                                          end
                                          #Conversion to Length directly took 1.84500002861023 sec, a=5,00m
                                          #Conversion to Length via Float took 0.14300012588501 sec, a=5,00m
                                          
                                          
                                          1 Reply Last reply Reply Quote 0
                                          • thomthomT Offline
                                            thomthom
                                            last edited by

                                            @unknownuser said:

                                            I have just found out that converting String to Length directly is up to 13x slower in comparision to converting it to Float first and only then to Length...

                                            That is useful to know. But that assumes one has a string with only a numeral.
                                            String.to_l will allow you to covert strings such as '20m' and '20mm'. With out any length unit indication in the string it will assume the length is in the unit of the current model.

                                            Thomas Thomassen β€” SketchUp Monkey & Coding addict
                                            List of my plugins and link to the CookieWare fund

                                            1 Reply Last reply Reply Quote 0
                                            • 1
                                            • 2
                                            • 3
                                            • 4
                                            • 5
                                            • 6
                                            • 4 / 6
                                            • First post
                                              Last post
                                            Buy SketchPlus
                                            Buy SUbD
                                            Buy WrapR
                                            Buy eBook
                                            Buy Modelur
                                            Buy Vertex Tools
                                            Buy SketchCuisine
                                            Buy FormFonts

                                            Advertisement