[Plugin] Team Edit - synchronised modelling v0.1.5 (alpha)

TommyK

Team Edit 0.1 alpha released.

Krisidious

this sounds very interesting... I'll check it out.

Anton_S

Interesting!

There is an error when I select a group and make it a component:

onComponentPropertiesChanged get defiinition path in: Error: #<NameError: undefined local variable or methodversion' for #TeamEdit::TeamEditDefinitionsObserver:0x000000077ba2a8>
C:/Users/Anton/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/TeamEdit/core.rb:1280:in onComponentTypeChanged'

driven

congrats tommy,

Have you thought about adding file tagging to visually reflect status in 'Finder', or maybe custom icons?
both are possible on a mac and there 'may' be a cross platform way... the color band could reflect the files status...

PM me if you don't want to crowd out this thread...

john

TommyK

@anton_s said:

Interesting!

There is an error when I select a group and make it a component:

onComponentPropertiesChanged get defiinition path in: Error: #<NameError: undefined local variable or methodversion' for #TeamEdit::TeamEditDefinitionsObserver:0x000000077ba2a8>
C:/Users/Anton/AppData/Roaming/SketchUp/SketchUp 2015/SketchUp/Plugins/TeamEdit/core.rb:1280:in onComponentTypeChanged'

Thank you for the report. I have just fixed it. Please download v0.1.1 from the PluginStore (which also fixes other related bugs)

@driven said:

congrats tommy,

Have you thought about adding file tagging to visually reflect status in 'Finder', or maybe custom icons?
both are possible on a mac and there 'may' be a cross platform way...

I like the idea, john. I will put it on the future wishlist (for after v1.0, I think). I do want it to be cross-platform regardless. I hate it when I see a plugin that "only works on PC".

JQL

Tommy,

Excellent idea and a much needed feature.

I have some questions to pose before diving into testing though:

What happens when you rename a component?
Do you get duplicate definitions and duplicate materials when updating components?
What happens when we do have a crash (as you described: "if Sketchup crashes for any reason, some components may falsely tell the user that another user is currently editing in this context.")
Does the background change affect the current style or does it create a new style? (I wouldn't mind having it affecting the current style, though a new style might slow down my sketchup use) May we define the style used for warnings (this style warning is a VERY clever solution though it has its implications...)

TommyK

@jql said:

Tommy,
I have some questions to pose before diving into testing though:

What happens when you rename a component?

On the next save operation, the component is saved as a new skp file (it doesn't rename the existing skp file). For other users, they will reload this new skp file on their next save operation.

@jql said:

Do you get duplicate definitions and duplicate materials when updating components?

I haven't tested duplicate materials, but you do NOT get duplicate definitions (I made sure of this). Natively in Sketchup, I know that when components are loaded into a model and the name of the component exists already, a prefix (#1, #2 etc) is added to the newly imported component(s). This does not happen in this plugin.

@jql said:

What happens when we do have a crash (as you described: "if Sketchup crashes for any reason, some components may falsely tell the user that another user is currently editing in this context.")

I'll need to get a bit technical here. Team Edit works by reading/writing small .txt files in a directory called "Network_files", every time a component is edited. When you start to edit a component, a .txt file is written saying that that component is "pending changes", and it waits for you to save the model (and the component to disk). So if Sketchup crashes, the .txt file will still think that it is "pending changes" for the component. You can ignore the orange screen and edit the component, save, and the problem will eventually go away. I do need to work this issue out in a future release.

@jql said:

Does the background change affect the current style or does it create a new style? (I wouldn't mind having it affecting the current style, though a new style might slow down my sketchup use) May we define the style used for warnings (this style warning is a VERY clever solution though it has its implications...)

The background change only affects the style if your style is named "TeamEdit". It will ignore other styles. TeamEdit loads this new style by default, which can be changed to your pleasure. I did consider whether it should work on the current style, whatever its name is, but I got the impression in these forums ( http://sketchucation.com/forums/viewtopic.php?f=180%26amp;t=13666%26amp;start=90#p549744 ) that users might not appreciate changes to their style. I am open to your suggestion.

JQL

Tommy,

I'm confortable on the plugin changing the display style temporarly IF it doen't save/applies the changes. Maybe this could be an option on a plugin definition because I would mind to work on a TeamEdit style. I have all my models setup with styles that are saved on scenes and styles I set while working for faster display. This working style is applied using a plugin "Trog_Styles" (or similar name) and a shortcut.

I really like the idea that the background changes because I always set it to transparent on Layout wich wouldn't be affected by the color change.

However if we are working on a component that is indoors there's no way to see the background that visual indication would be lost. What about allowing us to set the style warning of our choice. I, for instance, would gladly have my style being changed to Red/Orange lines along with the background as it's way more important for me to be careful when editing than to be conservative on changes to the visual style. (Specially if this changes wouldn't be saved on model.)

driven

@tommy

have you got a dropbox model that people can test against???

we could all play with different bits and you 'overlord' it...

john

TommyK

@driven said:

@tommy

have you got a dropbox model that people can test against???

we could all play with different bits and you 'overlord' it...

john

Here you go:
https://www.dropbox.com/sh/kn7zbev4ypffolu/AADO0wm43jj1FgvFjgjBOP3Ia?dl=0

I can't find an option to allow anyone to edit the folder, so it wouldn't quite work in the same way. I will be happy for anyone to PM with their email, and I will invite you to the Dropbox folder.

TommyK

@jql said:

Tommy,

I'm confortable on the plugin changing the display style temporarly IF it doen't save/applies the changes. Maybe this could be an option on a plugin definition because I would mind to work on a TeamEdit style. I have all my models setup with styles that are saved on scenes and styles I set while working for faster display. This working style is applied using a plugin "Trog_Styles" (or similar name) and a shortcut.

I really like the idea that the background changes because I always set it to transparent on Layout wich wouldn't be affected by the color change.

However if we are working on a component that is indoors there's no way to see the background that visual indication would be lost. What about allowing us to set the style warning of our choice. I, for instance, would gladly have my style being changed to Red/Orange lines along with the background as it's way more important for me to be careful when editing than to be conservative on changes to the visual style. (Specially if this changes wouldn't be saved on model.)

I think you have some good points there, JQL. So good in fact, that it has been implemented in the latest release.

Team Edit update v0.1.3 with what JQL said

JQL

@tommyk said:

I think you have some good points there, JQL. So good in fact, that it has been implemented in the latest release.

Team Edit update v0.1.3 with what JQL said

Thanks Tommy!

Near2010

Hi Tommy,
Me and my team are very excited about this plugins, we also trying it, but it doesn't work as your explanation on usage. First, We have synchronize our files on google drive and it synchronized properly. When enabled team edit, component folder was created, but every time we save the component model, changes made by other users wont be reloaded on my main model. Is there any wrong action we take? We'll very appreciate if you could share the step how to use it properly.
Thanks

TommyK

@near2010 said:

Hi Tommy,
Me and my team are very excited about this plugins, we also trying it, but it doesn't work as your explanation on usage. First, We have synchronize our files on google drive and it synchronized properly. When enabled team edit, component folder was created, but every time we save the component model, changes made by other users wont be reloaded on my main model. Is there any wrong action we take? We'll very appreciate if you could share the step how to use it properly.
Thanks

I'm sorry to hear that, and thank you for trying the plugin out and reporting back.

Firstly, please confirm the following:

that the plugin is installed on all computers that are editing those components

Two possible things come to mind:

changes are reloaded on your main model when you save the main model.
I haven't tried it with Google Drive before, but it should work like Dropbox. With large components, it can take some time for the component files (.skp files) to be synced on Google Drive/Dropbox. There can be a situation where TeamEdit can't find the new component, in which case it assumes it hasn't been synced yet, and waits until the next save operation to have another go at reloading it.

If the above doesn't help, I would very much appreciate it if you could send me the folder called "Network Files" (within your "XXX_Components" folder. You can PM me. Also please let me know what platform you are on (PC/Mac, Win version, SU version etc).

TommyK

Team Edit updated to v0.1.4. It now works on PC!

(funny no one told me until now - thanks to Near 2010 for the report)

Near2010

Thanks Tommy, now it works on our PC
We'll do some test and give you some feedback if you don't mind

JQL

@tommyk said:

Team Edit updated to v0.1.4. It now works on PC!

(funny no one told me until now - thanks to Near 2010 for the report)

I feel a bit ashamed here, but I haven't tried Team Edit yet. I'm just in the middle of a project and can't change the procedure now. I guess a simple example would be interesting... As soon as I have some time I will try it as fully as I can.

TommyK

@jql said:

@tommyk said:

Team Edit updated to v0.1.4. It now works on PC!

(funny no one told me until now - thanks to Near 2010 for the report)

I feel a bit ashamed here, but I haven't tried Team Edit yet. I'm just in the middle of a project and can't change the procedure now. I guess a simple example would be interesting... As soon as I have some time I will try it as fully as I can.

Don't worry! Try it out at your pleasure. It shouldn't be used in a production environment yet anyway. Simply put, the more feedback I get, the more reliable it will get.