Float <-> String - Locale aware?

Dan Rathbun

@dan rathbun said:

REASON: Assignment.

Nah, not a reason. I'm not talking about writing a = 1,3 within the code. But user input/output.

Yes I understand, but the basic Ruby reason is what I said in my previous post.

I had to break for dinner, and was going to post again discussing overridding the methods String.to_f and Float.to_s, which can be done.
Something like this?


class String

  alias_method( ;old_to_f, ;to_f )

  def self.to_f( arg )
    return self.old_to_f( arg.sub(/[,]/,'.') )
  end

end #class

BTW, I remember another thread on this subject regarding the VCB.

thomthom

Converting comma to period for the strings before one call .to_f works. It is what I am doing at the moment. (But as a separate method. I never override any base classes in SU Ruby. I even avoid adding new methods.) But the problem is the other way around. When one wants to present a float formatted in the format of the user's locale.

thomthom

@dan rathbun said:

Yes I understand, but the basic Ruby reason is what I said in my previous post.

I don't see how multiple assignment has anything to do with parsing strings with commas?

Dan Rathbun

@thomthom said:

@dan rathbun said:

Yes I understand, but the basic Ruby reason is what I said in my previous post.

I don't see how multiple assignment has anything to do with parsing strings with commas?

It doesn't, I was speaking about how Ruby interprets Numeric literals to create Float objects. Basically the comma was already taken as an argument and assignment separator.

thomthom

Well yes, but using commas in Numeric literals is not the problem in question.
It's string interpretation and presentation.

Here's a terrible hacky way:

r = 1 / '1'.to_l; x = '1,23'.to_l * r; x.to_f

Returns 1.23 for the string '1,23' when the locale uses comma for decimal separation.

But I really would like to use a clean way of doing this.

thomthom

The spider bots are quick. As I try to google Ruby and locale ware Float <-> String conversion I get this thread at the top of the results.

thomthom

... I must be going mad. I dunno why I produced that previous hack when a simple replacement of comma to period works.
I meant to be tackling the other way around...

Ok - enough ramblings. Time to get some rest.

thomthom

No rest for the wicked.

decimal_separator = 1.2.to_l.to_s.match(/\d(\D)\d/)[1]
This returns the decimal separator.

1.23.to_s.tr!('.', decimal_separator)
And this outputs a float in the user's locale.

Hacky hacky hacky...

Now: how does one do this properly?

thomthom

@dan rathbun said:

We can see if the user is using metric, via:

Still doesn't say anything about the user's decimal separator though. Only their modelling units.
An user with English locale might use a metric template.

And one can set the decimal separator to anything in the system settings.

Dan Rathbun

@thomthom said:

Now: how does one do this properly?

The PROPER Ruby way is to either override a method, or add a new method to the base class. That's why I love Ruby. It's the Dynamic feature of the language.

Why is it that @Last/Google can override base classes (and do it very poorly/error prone, etc.) and I with 30+ years experience am not supposed to be allowed to?

Why does noone say anything when Rick Wilson overrides or adds to base classes or Sketchup classes?

The SKX project is/was a means of proposing/testing such new methods or base class overrides.

Dan Rathbun

@thomthom said:

decimal_separator = 1.2.to_l.to_s.match(/\d(\D)\d/)[1]
This returns the decimal separator.

1.23.to_s.tr!('.', decimal_separator)
And this outputs a float in the user's locale.

No, it returns a String representation of a Float, using the user's locale system decimal separator.
But .tr/.tr! will change ALL occurances of '.', whereas sub/sub! change only the first occurance.

picky, picky

thomthom

@dan rathbun said:

But .tr/.tr! will change ALL occurances of '.', whereas sub

Does it matter?

thomthom

@dan rathbun said:

@thomthom said:

Now: how does one do this properly?

The PROPER Ruby way is to either override a method, or add a new method to the base class. That's why I love Ruby. It's the Dynamic feature of the language.

Why is it that @Last/Google can override base classes (and do it very poorly/error prone, etc.) and I with 30+ years experience am not supposed to be allowed to?

Why does noone say anything when Rick Wilson overrides or adds to base classes or Sketchup classes?

The SKX project is/was a means of proposing/testing such new methods or base class overrides.

Regardless of who does it, overriding base class method in the SU environment is a no-no. One can not know how it will affect other scripts - they could be relying on the original behaviour.
I would love to override existing methods, but that only works if you have the sole control of the environment. And in SU Ruby, you don't.

The reason I avoid adding new methods is that one never knows if someone else also adds a method of the same name that does something different. Same problem as before.
Now, one could go about and prefix with your initial as the conventions are for root modules. But then again, say you create a a plugin that adds a method to a base class. It turns out to have a bug.
You fix that.
You then make another plugin with that fix.

But the a user could have your new plugin and the old bugged version of your first and it loads last overriding the method. Now you're stuck with the bugged version in both your plugins - because you don't have control over the environment your plugin lives on.

Now, this latter case is more of a problem for yourself, so if one want to do so then fine. But I avoid it.
But overriding base methods are still a no no.

I've seen Rick add to base classes. I've not seen him override base methods though.

@dan rathbun said:

Why is it that @Last/Google can override base classes (and do it very poorly/error prone, etc.) and I with 30+ years experience am not supposed to be allowed to?

Because they deploy the platform. They are the source.
You, me, everyone else got to try to live along side inside that environment without causing conflicts for each others.

@dan rathbun said:

The SKX project is/was a means of proposing/testing such new methods or base class overrides.

Yes - we where even talking with people from Google Sketchup if they thought some of it could cause conflicts.
Personally that project ended up being down-prioritised for other projects.

thomthom

Found a nice method:
http://code.google.com/apis/sketchup/docs/ourdoc/sketchup.html#format_degrees

It formats any numeral into a string using the user's locale with the model precision.

Example, Norwegian locale and 1 digit precision:
Sketchup.format_degrees(500.555)
Returns the string: "~ 500,6"

Now, if only I could find a method for the other way around...

Jim

It's OK to extend only specific instances with with some instance methods, and without modifying the base class.

Something like...


module Translatable
    def translate(lang)
        "Hi"
    end
end

str = "Hello"
str.extend(Translatable)
str.translate("en")

Dan Rathbun

@jim said:

It's OK to extend only specific instances with with some instance methods, and without modifying the base class.

Called creating a singleton method.

Dan Rathbun

@thomthom said:

Now, if only I could find a method for the other way around...

I don't think I can test the other way as my locale setting uses period as decimal point.

If your model units are metric, and your OS locale decimal separator is comma, what happens when you try to use the base class (SU extended) method String.to_l ?

Ex:
length = "5,43".to_l
(1) what does length then appear as in the console ?
(2) what does it appear as in an inputbox control ?
(3) what does it appear as in a webdialog ?

What happens when:
length = "5.43".to_l

cjthompson

Why won't "12,2".to_l.to_f work?

Dan Rathbun

@thomthom said:

Found a nice method:
...[snip]...
Example, Norwegian locale and 1 digit precision:
Sketchup.format_degrees(500.555)
Returns the string: "~ 500,6"

What happens when:
Sketchup.format_degrees(500,555)
Wouldn't you be specifying decimals in euro-format?
When I try it there is a conflict; Ruby sees the comma as an argument delimiter, and pukes up an argument (2 for 1) exception.

Dan Rathbun

@cjthompson said:

Why won't "12,2".to_l.to_f work?

I can't test that; it raises an:
<ArgumentError: (eval):0:into_l': Cannot convert "12,2" to Length>` because I think of my US-en locale settings.
TT will need to test it, with his euro settings.

Of course, "12.2".to_l.to_f works just fine for me (and anyone in the US.)

Float &lt;-&gt; String - Locale aware?

Float <-> String - Locale aware?