sketchucation logo sketchucation
    • Login
    💡 LightUp 7.1 | SketchUp's only real-time renderer that uses object-based rendering Download Trial

    [Plugin] CleanUp

    Scheduled Pinned Locked Moved Plugins
    974 Posts 217 Posters 786.9k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • brodieB
      brodie
      last edited by

      An issue I've had with the past couple version is with the plugin deleting faces. I don't recall having this issue with the first version. Do I have an incorrect setting checked or something?

      -Brodie

      steelblue http://www.steelbluellc.com

      1 Reply Last reply Reply Quote 0
      • thomthomT
        thomthom
        last edited by

        The Merge Faces features should be the most stable ever in this version (3.x).
        But maybe it's an issue with Erase Duplicate Faces. It's a very slow feature that can yield unpredictable results. It's why it is off by default and the tooltip has the warning.

        Ticking all the checkboxes doesn't mean the model gets cleaner - it just does different thing. So it's worth reading what they actually do.

        I don't know what settings you have Brodie, so it's hard for me to tell anything more than that. If you have settings and a sample model I can have a look at it.

        Thomas Thomassen — SketchUp Monkey & Coding addict
        List of my plugins and link to the CookieWare fund

        1 Reply Last reply Reply Quote 0
        • brodieB
          brodie
          last edited by

          Here's the model and a screenshot of the settings below.

          http://dl.dropbox.com/u/384281/Laser%20Printer.skp

          The number and location of faces which are deleted seems to have a certain random nature to it. Running the script, undoing the results, and running the script again a few times resulting in different results each time

          -Brodie

          Edit: the original model is from here and is free http://archive3d.net/?a=download&id=3dfc187e

          printer.JPG

          printer 2.JPG

          steelblue http://www.steelbluellc.com

          1 Reply Last reply Reply Quote 0
          • thomthomT
            thomthom
            last edited by

            Ok, looked at the model.

            The first thing I got when I opened the model was a warning:

            @unknownuser said:

            Results of Validity Check.

            The plane equation for CFace (51806) is not valid - fixed
            The plane equation for CFace (61254) is not valid - fixed
            The plane equation for CFace (145402) is not valid - fixed
            The plane equation for CFace (146979) is not valid - fixed
            The plane equation for CFace (149505) is not valid - fixed
            The plane equation for CFace (230859) is not valid - fixed
            The plane equation for CFace (297112) is not valid - fixed
            The plane equation for CFace (297293) is not valid - fixed
            The plane equation for CFace (299305) is not valid - fixed
            The plane equation for CFace (311352) is not valid - fixed
            The plane equation for CFace (316611) is not valid - fixed
            The plane equation for CFace (333176) is not valid - fixed
            The plane equation for CFace (333255) is not valid - fixed
            The plane equation for CFace (333707) is not valid - fixed
            The plane equation for CFace (395589) is not valid - fixed

            I did not run the test - SU did that manually.

            I then ran CleanUp with these settings:
            CleanUpSettings.png

            A key setting might be that I didn't tell it to Ignore Normals. (Not sure - I did not compare with other settings.)

            I then got a new validity check (because I'd asked for it. it's common to get error like this when the model already was producing errors.)

            @unknownuser said:

            Results of Validity Check.

            CEdge (62898) and CEdge (1380179) connect the same 2 vertices - fixed
            The plane equation for CFace (1044) is not valid - fixed
            The plane equation for CFace (1425) is not valid - fixed
            The plane equation for CFace (2564) is not valid - fixed
            The plane equation for CFace (2604) is not valid - fixed
            The plane equation for CFace (2954) is not valid - fixed
            The plane equation for CFace (3000) is not valid - fixed
            The plane equation for CFace (3827) is not valid - fixed
            The plane equation for CFace (5067) is not valid - fixed
            The plane equation for CFace (5382) is not valid - fixed
            The plane equation for CFace (5702) is not valid - fixed
            The plane equation for CFace (7542) is not valid - fixed
            The plane equation for CFace (92317) is not valid - fixed
            The plane equation for CFace (93266) is not valid - fixed
            The plane equation for CFace (108967) is not valid - fixed
            The plane equation for CFace (212162) is not valid - fixed
            The plane equation for CFace (212355) is not valid - fixed
            The plane equation for CFace (213151) is not valid - fixed
            The plane equation for CFace (213681) is not valid - fixed
            The plane equation for CFace (213868) is not valid - fixed
            The plane equation for CFace (246903) is not valid - fixed
            The plane equation for CFace (271394) is not valid - fixed
            The plane equation for CFace (293150) is not valid - fixed
            The plane equation for CFace (293557) is not valid - fixed
            The plane equation for CFace (484265) is not valid - fixed
            The plane equation for CFace (484587) is not valid - fixed
            The plane equation for CFace (491934) is not valid - fixed
            The plane equation for CFace (542762) is not valid - fixed
            The plane equation for CFace (543339) is not valid - fixed
            The plane equation for CFace (549098) is not valid - fixed
            The plane equation for CFace (549228) is not valid - fixed
            The plane equation for CFace (575761) is not valid - fixed
            The plane equation for CFace (576252) is not valid - fixed
            The plane equation for CFace (576379) is not valid - fixed
            The plane equation for CFace (577820) is not valid - fixed

            The printer model dropped from ~100K (!!! 😕 ) faces to "merely" 38K faces...

            No error messages about lost geometry.

            Thomas Thomassen — SketchUp Monkey & Coding addict
            List of my plugins and link to the CookieWare fund

            1 Reply Last reply Reply Quote 0
            • M
              mac1
              last edited by

              mosel clean.jpgWould like to suggest one item at a time be "cleaned". The results you get can be a function of the action and its sequence and the model may not be good to start with. I imported the printer to mesh lab ( 3ds) and note the things cleaned on the right side ( it corrected some of the bad faces to start) and the jpg shows the self intersecting faces. Deleting those can be destructive to the model and I did not do that. In the past I have had that problem and have not been able to figure out if it is MeshLab or SU.
              Just some thoughts

              1 Reply Last reply Reply Quote 0
              • M
                mac1
                last edited by

                clean layer text.jpg
                Layer text did not disply wee. Hope this is better.

                1 Reply Last reply Reply Quote 0
                • M
                  mp1963
                  last edited by

                  Installed the latest version of Cleanup and I am seeing these errors:

                  undefined method `hidden?' for #Sketchup::Vertex:0xe3d4fc4

                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1142:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:113:in each_entity'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each_entity'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:119:in each_entity' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each_entity' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:119:in each_entity'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/entities.rb:112:in each_entity'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:772:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):110:in call'
                  (eval):110

                  The model I am cleaning up is very simple and these errors seem to occur after completing one (sometimes two) previous cleanup operations.

                  I hope this information is of some use ?

                  I am also experiencing a lot of Sketchup Pro crashes, without any crash reports being generated.

                  I am using Sketchup Pro 8.0.11751 on Mac OS X 10.7.2. Hardware is a iMac 2.93Ghz Core 2 Duo with 8Gb of DDR3 RAM.

                  Thanks for the excellent plugin.

                  Kind regards,

                  Marek

                  1 Reply Last reply Reply Quote 0
                  • thomthomT
                    thomthom
                    last edited by

                    That is a very strange error! 😲
                    Somehow it iterates over a Vertex entity - I cannot see any reason for that... 😕

                    Can you post the model? Or send it to me privately if you don't want to publicly share?
                    Also, I need to know the exact settings you used. (A screenshot of the settings window)

                    And I assume you;re using the latest CleanUp? 3.1.9?
                    And the exact version of TT_Lib2?

                    Thomas Thomassen — SketchUp Monkey & Coding addict
                    List of my plugins and link to the CookieWare fund

                    1 Reply Last reply Reply Quote 0
                    • M
                      mp1963
                      last edited by

                      Have sent you a PM about this 💚

                      1 Reply Last reply Reply Quote 0
                      • thomthomT
                        thomthom
                        last edited by

                        I looked at the model. Could not reproduce it. But I used a PC. Will have to try on my Mac.
                        Exactly what version of SketchUp do you have? And TT_Lib2?

                        (btw - I did see that there where many small details - where edges where less than 1mm - which can cause issues with SU. But I'm not sure if that would cause such an error as the one you see...)

                        Thomas Thomassen — SketchUp Monkey & Coding addict
                        List of my plugins and link to the CookieWare fund

                        1 Reply Last reply Reply Quote 0
                        • M
                          mp1963
                          last edited by

                          Specifications of software and hardware...

                          I am using Sketchup Pro 8.0.11751 on Mac OS X 10.7.2. Hardware is a iMac 2.93Ghz Core 2 Duo with 8Gb of DDR3 RAM. Video card is an Nvidia GT130.

                          TT_Lib2 is version 2.6.0

                          Hope that helps.

                          Marek

                          1 Reply Last reply Reply Quote 0
                          • M
                            mp1963
                            last edited by

                            Another strange error today, not seen this one before:

                            undefined method `valid?' for #Sketchup::OptionsProvider:0xecc34c8

                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1133:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:134:in each_entity'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each_entity'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each_entity'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:768:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
                            /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):3713:in call'
                            (eval):3713

                            Hope this list of problems is of some help ?

                            1 Reply Last reply Reply Quote 0
                            • thomthomT
                              thomthom
                              last edited by

                              Can you reproduce it? If so how?

                              Because I cannot see how on earth that ever should happen. 😲 😕 While iterating the model the plugin ran across an OptionsProvider object... Never ever should such thing be possible. I don't know if it's an SU glitch or if there is some plugin conflict somewhere that messes with the core classes.

                              I first need to know if it's a reproducible case.

                              Thomas Thomassen — SketchUp Monkey & Coding addict
                              List of my plugins and link to the CookieWare fund

                              1 Reply Last reply Reply Quote 0
                              • M
                                mp1963
                                last edited by

                                I will have a go at reproducing the error. I seem to think it happens after several consecutive runs of the cleanup script. Will get back to you as soon as it happens again.

                                1 Reply Last reply Reply Quote 0
                                • M
                                  mp1963
                                  last edited by

                                  Ok I managed to produce this error:

                                  undefined method `hidden?' for #Sketchup::Vertex:0xea1acbc

                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1142:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:134:in each_entity'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each_entity'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each_entity'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:768:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
                                  /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in `to_proc'

                                  All I did was attempt to cleanup two separate models. I used the default cleanup settings. The only thing I changed was to tell cleanup to clean the model rather than selected. When cleaning the second model the error above appears.

                                  1 Reply Last reply Reply Quote 0
                                  • M
                                    mp1963
                                    last edited by

                                    Attempting to repeat the cleanup process on a second model yields this error:

                                    undefined method `current=' for #Sketchup::Face:0xdcbe564

                                    /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:564:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
                                    /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
                                    /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
                                    /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
                                    /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):114:in call'
                                    (eval):114

                                    I have now removed all but the most necessary plugins from my Sketchup installation. Any suggestions as to what I can do next to try and help resolve these issues ?

                                    1 Reply Last reply Reply Quote 0
                                    • M
                                      mp1963
                                      last edited by

                                      I don't restart Sketchup after these errors occur I get more and different error messages, like this one:

                                      undefined method `hidden?' for #Sketchup::AttributeDictionary:0xdbb3c50

                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1142:in erase_hidden' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:134:in each_entity'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:133:in each_entity'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/model.rb:130:in each_entity'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:768:in each_entity_in_scope' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:1130:in erase_hidden'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:568:in cleanup!' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/tt_cleanup.rb:488:in show_cleanup_ui'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in call' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:178:in event_inputbox_close'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in call'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in close' /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:159:in event_inputbox_accept'
                                      /Library/Application Support/Google SketchUp 8/SketchUp/Plugins/TT_Lib2/inputbox.rb:9:in to_proc' (eval):110:in call'
                                      (eval):110

                                      Would you like me to try reinstalling Sketchup or could this be a problem with the Ruby installation for the Mac ? Why is noone else reporting errors like this or is the case that most Sketchup users are on windows and these errors don't happen ?

                                      1 Reply Last reply Reply Quote 0
                                      • M
                                        mp1963
                                        last edited by

                                        I have now updated my version of Ruby to the latest (1.9.3) and these errors still occur. Just for your information.

                                        1 Reply Last reply Reply Quote 0
                                        • thomthomT
                                          thomthom
                                          last edited by

                                          @mp1963 said:

                                          Why is noone else reporting errors like this or is the case that most Sketchup users are on windows and these errors don't happen ?

                                          It's strange that these errors should show themselves now. There are many OSX users. ...but could it be a Lion issue? Your profile information is up to date?

                                          Thomas Thomassen — SketchUp Monkey & Coding addict
                                          List of my plugins and link to the CookieWare fund

                                          1 Reply Last reply Reply Quote 0
                                          • M
                                            mp1963
                                            last edited by

                                            Have updated my system specification to include the 10.7.3 update we got from Apple last week. Sadly I didn't know about your plugin prior to Lion so I can't comment its stability then but I agree it is most odd that other users are not reporting/seeing these issues. I am reasonably certain its not the way I build my models in Sketchup. The one I sent you a while ago was not odd in any way I don't think ?

                                            Please let me know if there is anything I can help you track down what is going on here ?

                                            1 Reply Last reply Reply Quote 0
                                            • 1
                                            • 2
                                            • 31
                                            • 32
                                            • 33
                                            • 34
                                            • 35
                                            • 48
                                            • 49
                                            • 33 / 49
                                            • First post
                                              Last post
                                            Buy SketchPlus
                                            Buy SUbD
                                            Buy WrapR
                                            Buy eBook
                                            Buy Modelur
                                            Buy Vertex Tools
                                            Buy SketchCuisine
                                            Buy FormFonts

                                            Advertisement