Fixing the Undo-stack (and others!)

[Joclo]

Hi again,

I've managed to fix the undo-stack, as well as implement a couple of other features (same colour across groups/components, reset all materials to default) but the Component section is still not working as intended on some models.

On simpler models it seems to work fine, however on larger models (like the one attached) it seems to get stuck. Any suggestions would be most appreciated! I've noticed when I take out the is_a?(Sketchup::ComponentInstance) section the rest of the script works fine and as intended.

Also, once this is sorted a better UI is the next on the list
-CJ

---

latest version

---

The model that's causing hangups

[TIG]

When you process a ComponentInstance its definition.entities is altered, you only need to do that once...
There might be several instances...
So set up an initial array before the iterated tests: @defns=[]
So when it's an instance the first thing you do it test if it's already been done...
This is cod-code - adjust it to your needs...
` next if @defns.include?(instance.definition)
@defns << instance.definition

process definition.entities`

That way each definition is only processed once...

[Joclo]

Thanks for highlighting this TIG, unfortunately this didn't fix the issue. The script hangs and doesn't update the faces until the next user action, then only updates one component definition. Does this yield any clues?

I'm going to sleep on it

-CJ

[TIG]

Any errors in the Ruby Console ?

[Joclo]

Hi TIG, I realised that I hadn't run it through the console straight after I finished yesterday. I've now run it through the console & found there's a problem in the self.softcheck method that gives a Error: #<NoMethodError: undefined method `material' for nil:NilClass> when run in some models.

I changed the condition from if @face_array[0] && @face_array[0].material == nil and got a Error: #<SystemStackError: stack level too deep>.. Ouch. I believe this is because of excessive recursion, the model comes back with smoothed surfaces half finished so I don't think there's an infinite loop in there. I presume this means I need to rewrite the code algorithmically?

  def self.softcheck(face)
    face.edges.each do |edge|
      if edge.soft?
      @face_array = edge.faces 
      @face_array.delete(face)
        if @face_array[0] && @face_array[0].material == nil
          @face_array[0].material = @colour_current
          self.softcheck(@face_array[0])
        end
      else next
      end
    end
  end

I'm guessing I'm not the first person to try and 'select' all faces in a softened surface, so if there's a good existing definition I could have a look at I'd be most obliged. Cheers

-CJ

[TIG]

As I recall thomthom wrote an example code method, to select all faces in a smoothed surface...
Here http://sketchucation.com/forums/viewtopic.php?p=365381#p365381 and others like Jim http://sketchucation.com/forums/viewtopic.php?p=453845#p453845

[Joclo]

It works

I had a good look at ThomThom's code and saw how he did it, very neat - going to have a good think about how to optimise it now as it should only iterate each surface once; if the softcheck returns an array faces in a surface I presume I could subtract this from the array of entities being coloured. Time to experiment!

In the meantime, here are the results:

-CJ

---

[Joclo]

And of course thank you hugely for your time and expertise TIG, I've thoroughly enjoyed my first foray into Ruby for Sketchup. Thanks again

-CJ

[tt_su]

@joclo said:

I changed the condition from if @face_array[0] && @face_array[0].material == nil and got a Error: #<SystemStackError: stack level too deep>.. Ouch. I believe this is because of excessive recursion, the model comes back with smoothed surfaces half finished so I don't think there's an infinite loop in there. I presume this means I need to rewrite the code algorithmically?

Recursive methods to traverse geometry is likely to cause stack overflow as you'll be recursing thousands of times. Geometry walkers need to "unroll" their loop to avoid this.

[Joclo]

Got it, thanks Thom. I realised that I could have optimised it to recurse fewer times, but at some point with increasingly complex surfaces it will run into a stack overflow again. I had a little read elsewhere and found that there are workarounds (ulimit and altering the interpreter, sounds like a bit of a dodgy hack to me..), but eventually it's always got an upper limit.

I very much like the idea of a Geometry walker traversing geometry, and ended up using a solution very similar to yours. Cheers!

-CJ