[Plugin] Components manager plugin

Oxer · 31 Jan 2014, 19:43

I sent you a PM with my answers, but the scrollbars no appear in the Options window.

inteloide · 31 Jan 2014, 22:39

Hello

Just post a plugins that solve push/pull issue (and maybe some other). It was a bug not so easy to find...

Oxer, I will post you a special version that tries to add scrollbar on Safari. About translation, could you tell me exactly an example of a translation not working ? I change in version 1.12.4 the option translation text to the English to avoid wrong coding because of new option texts structure.

Version 1.12.4 :
Corrected : Issue when using push/pull tool in a component.
Optimized : Simplified attribute date change in model to open only one time for each component.

Oxer · 1 Feb 2014, 01:34

With v1.12.4 on Mac the scrollbars continue missing and the translation works partially.

It works in:

Plugins Menu
Titles of the windows.
Tooltips of the items in the List.
Tooltip of the toolbar icon.
All the strings in the Filters window.
String: "List update at "
All pop-up windows.

The rest no.

inteloide · 1 Feb 2014, 10:19

@oxer said:

The rest no.

Ok this means that "options" are not translated. Are all options not translated ? (remember that in current Localization.rb file I let everything in English, to try it you have to change translation).

Also, for your window size issue, I added a option to save window size, which solve temporary your size issue.

V 1.13.0 :
Added : New option to save window size
Added : Show refreshing time in the window status bar
Corrected : Remove one unused global variable

Oxer · 3 Feb 2014, 13:45

Yes, all Options not translated. I changed the translation.
The "Save Window Size" option works fine but there is a great problem, when you call the plugin the first time all work fine, then you close the Component Manager window, the second time that you call the plugin, it appears the Component Manager window with the message: "Please refresh the list" but the buttons doesn't work, no Refresh List, no Link to file, nothing.

JQL · 5 Feb 2014, 22:59

Inteloide,

I tried it again today and the problems with push-pull and undo have disappeared, but now I'm seing it messing with Fredoscale and I also believe JointPushPull. I think it's because they perform changes to components and groups visually and interactively.

I think your plugin is making Fredo scale multiply a given value several times, until the mouse is clicked.

I also believe it's making JointPushPull crash.

May you have some conflicts with your observers and Fredo's?

inteloide · 6 Feb 2014, 18:17

@jql said:

May you have some conflicts with your observers and Fredo's?

Hello JQL,

I check a bit Fredo's plugin code, apparently nothing should make conflict...but I will ask Fredo if we can check this toegether.

Inteloide

JQL · 6 Feb 2014, 19:42

But did you see what happens? Do you want me to make a video or something?

inteloide · 15 Feb 2014, 20:27

Hello JQL,

Yes a little video would be helpful.

Inteloide

JQL · 16 Feb 2014, 00:02

Inteloide,

There you have the video. If component manager plugin is disabled FredoScale works normally.
It also works as usual on groups and sometimes on components with multiple instances.

The object being stretched by FredoScale Box Stretch to Target is a component.

Thanks again for all your effort,

JQL

FredoScale_Box_Stretch_to_Target_with_Component_Manager_v1.13.0_On.swf

thomthom · 19 Feb 2014, 09:00

Hi there

It has been brought to my attention that this plugin can conflict with other plugins. I just got a report from a customer that experienced SketchUp crashing when using Vertex Tools. After debugging it turned out that the crashing stopped once this plugin was disabled.

I looked at the source code and I identified several problems.

The main problem is that this plugin uses observers that modifies the model in the observer events. This causes a number of issues, for instances interrupting other tools and plugins. It breaks the currently running operation if you perform model changes in observer events. It's also prone to cause crashes in SketchUp - which is happening here.

How, there is a pattern one can use to make observers safer, it's demonstrated in a code example published on GitHub: https://github.com/SketchUp/sketchup-safe-observer-events

It also defines a bunch of methods outside of any module, which in effect defines them in Kernel - which means they become available to every object that exist - big potential for clashing with other plugins.
It's recommended to contain all methods in a top level module to avoid clashing with other plugins, as well as not using global variables. I've written an article that describes this in more detail:
http://www.thomthom.net/thoughts/2012/01/golden-rules-of-sketchup-plugin-development/

Also a checklist of key items to verify when publishing a plugin:
http://www.thomthom.net/thoughts/2013/02/sketchup-plugin-checklist/

On a side note, not rleated to clashing, but for the sake of performance; typename is very slow. using is_a? or kind_of? is many times faster.
http://www.thomthom.net/thoughts/2011/12/never-ever-use-typename/

It'd be good if you could address the issues that makes your plugin conflict with other plugins. Causing crashes is very unfortunate for the users as they may lose their work.

inteloide · 19 Feb 2014, 20:51

Hello Thomthom,

Thank you for your always useful remarks.
Actually I was working with JQL to solve conflict issues he had with other plugins.
The new version I just posted should solve the problem.

I corrected also some coding according your advice :
I wrapped my file BGSketchup.rb in a module but I kept the global variable because it's used for other plugins (maybe I can change this later). But the global variable has a special name.
For the other variables they are replaced with module variables as per your advice.

For observers, I proceed in a new way and I update entity attribute only when user is asking a specific action from the plugins (reload liste, save components, etc...) or when saving the model. Therefore it should be interferring other plugins.
(sorry, I didn't use your code....yet ;o)

Once you have made some testing with your plugins and it's running ok, I will update it in the pluginstore to inform all current users.

Thanks again for your help improving this plugin.

Inteloide

inteloide · 21 Feb 2014, 07:05

A bug appeared in my version 1.14.3 rbz file....
Anyone who download this version must download version 1.14.4 AND remove "BGSketchup_Robot.rb" file from their plugin directory...
Sorry for this error.

Inteloide

inteloide · 15 Mar 2014, 14:21

Hello !

What about last version of the plugins ? Does it works on your computer ?
If yes I will upload it in the pluginstore.
Thank you for your feedbacks !

Inteloide

ole · 15 Mar 2014, 20:48

Works wonderfully!! Very sophisticated Plugin. I love its power and friendliness.

It needed Lines 44 and 66 of file BGSketchup.rb changed to delete .chr in my U.S. version of SU8 on win7.

inteloide · 15 Mar 2014, 22:37

@ole said:

Works wonderfully!! Very sophisticated Plugin. I love its power and friendliness.

It needed Lines 44 and 66 of file BGSketchup.rb changed to delete .chr in my U.S. version of SU8 on win7.

Hello Ole,

I don't have SU8 installed anymore on my PC (I have SU2013 and SU2014), therefore I cannot see the error you have. Normally SU 2013 and SU 8 have the same level of ruby but...looks like no

Could you please send me the exact error you have (in ruby console) in order to solve it ? Because if I remove the .chr, for SU2013 it won't work. I maybe have to have 2 codes depending on SU version...

Thank for your feedback.
Inteloide

ole · 16 Mar 2014, 01:26

With version 1.14.4 downloaded from this thread, plugin doesn't crash but nothing happens. I'm still learning how it works.

Happens when saving or reloading by right-click.

inteloide · 16 Mar 2014, 09:22

@ole said:

With version 1.14.4 downloaded from this thread, plugin doesn't crash but nothing happens. I'm still learning how it works.

Hello Ole,

Just post version 1.14.5, which include your modification, in first post of this thread.

If you require any help to understand the plugin, you can ask me. Also you have the help file in first post and inside plugins : just click on "about" button and you have a link to the help file.

Regards
Inteloide

Oxer · 16 Mar 2014, 17:33

Hi Inteloide,
I have a quick test on Mac of the last version 1.14.5, for the moment all works fine except the previous problem with the translation, the Tooltips of the icons, Options of components and Options window aren't translated, see the image below

The rest of the translation (pop-up windows) works fine.

Here the complete new Spanish translation

Localization.rb.zip

inteloide · 22 Mar 2014, 14:00

Hello !

Please download last version that mainly introduces a javascript error (for SU 2014, javascript errors are not displayed anymore), corrects some bugs.

Oxer, this may raise some error message on Safari, which will help me to find your translation issue...

Inteloide