• Login
sketchucation logo sketchucation
  • Login
ℹ️ Licensed Extensions | FredoBatch, ElevationProfile, FredoSketch, LayOps, MatSim and Pic2Shape will require license from Sept 1st More Info

Optimization Tips

Scheduled Pinned Locked Moved Developers' Forum
110 Posts 22 Posters 168.8k Views 22 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • J Offline
    Jim
    last edited by 7 Apr 2010, 20:57

    @adamb said:

    @jim said:

    I guess to get back on topic, for loops are not faster then .each iterators. The performance must have to do with how the for loop variables are not loop scoped, as in each.

    "Your racing car is not faster than my Trabant, it just covers more ground in a shorter time than my car." πŸ˜„

    Heh? Oh. Yes, I see. 😳

    Would it be correct to say: An each loop can be as fast as a for loop if the loop variable has been initialized?

    Hi

    1 Reply Last reply Reply Quote 0
    • T Offline
      thomthom
      last edited by 7 Apr 2010, 21:02

      That would mean it's not the each loop itself that's slow - but the creation of variables.

      Thomas Thomassen β€” SketchUp Monkey & Coding addict
      List of my plugins and link to the CookieWare fund

      1 Reply Last reply Reply Quote 0
      • J Offline
        Jim
        last edited by 7 Apr 2010, 21:04

        Exactly.

        Hi

        1 Reply Last reply Reply Quote 0
        • T Offline
          thomthom
          last edited by 11 Apr 2010, 19:44

          Vertex.position is slow! Cache the result if you need to use the same Point3d multiple times.

          Point3d.distance also accepts Vertex objects in place of Point3d or Array.
          point1.distance(vertex2) is faster than point1.distance(vertex2.position).

          Link Preview Image
          Sketchup Vertex.position speed performance - ThomThom's Website

          favicon

          (www.thomthom.net)

          Thomas Thomassen β€” SketchUp Monkey & Coding addict
          List of my plugins and link to the CookieWare fund

          1 Reply Last reply Reply Quote 0
          • A Offline
            AdamB
            last edited by 13 Apr 2010, 08:32

            Its all interesting info you're digging up thomthom, but I wonder where you're going..

            Ruby is a scripting language that makes for very quick development, modern constructs and good readability. So you pay for that with execution performance. However, performance with a big P which may include how fast you can complete and deliver functionality may be better - but once again I do think you should play to Ruby's strength rather than perhaps bend it into something it isn't.

            By the time you've created local copies of state, rewritten everything using a compact form etc etc you end up with something that is less readable and probably more prone to bugs. And as you've discovered, there is a massive difference in performance between native code and Ruby - such a large gulf, you're never going to come even close to closing it.

            You should do heavy lifting with a C extension and GUI / API / semantic stuff with Ruby. Processing geometry topology with Ruby is, in general, not practical. Not that it can't be done..but that's not what I'm suggesting.

            Developer of LightUp Click for website

            1 Reply Last reply Reply Quote 0
            • T Offline
              thomthom
              last edited by 13 Apr 2010, 08:54

              @adamb said:

              Its all interesting info you're digging up thomthom, but I wonder where you're going..

              That was actually stuff I found out before I got around to do a C extension.
              Jumping from Ruby - or any other scripting language - C extensions is not an easy jump. If C isn't your cup of tea then it's worth knowing what saves time in Ruby. Most plugin writers here doesn't do C and have no interest in it either. Just making something that work - but still one can save noticeable time.

              What I found most interesting in those test was that Vertex is a valid argument where the manual claims only Point3d. And passing the Vertex is faster than Vertex.position.

              As for C extensions - it appear that there's a significant overhead of converting VALUEs to workable C types - so if you iterate only once over a set of data there isn't much to gain. Only if there's quite a bit more calculations.

              Thomas Thomassen β€” SketchUp Monkey & Coding addict
              List of my plugins and link to the CookieWare fund

              1 Reply Last reply Reply Quote 0
              • A Offline
                AdamB
                last edited by 13 Apr 2010, 10:54

                @thomthom said:

                As for C extensions - it appear that there's a significant overhead of converting VALUEs to workable C types - so if you iterate only once over a set of data there isn't much to gain. Only if there's quite a bit more calculations.

                Not really. You asked the wrong question, so you perhaps got an answer that has misled you.

                You asked about converting Ruby arrays to C etc. And everything I said stands. However, sounds like you actually want a C extension that operates upon the Ruby structures. If you have a situation where you are just wanting to twiddle existing Ruby data from C, it is well worth doing even for 1 pass because the fixed costs are pretty much zero.

                Developer of LightUp Click for website

                1 Reply Last reply Reply Quote 0
                • T Offline
                  thomthom
                  last edited by 13 Apr 2010, 11:40

                  I'm very green to this Ruby <-> C interaction - so its very likely I'm not doing thing the right way around.

                  @adamb said:

                  However, sounds like you actually want a C extension that operates upon the Ruby structures.

                  What I have done so far is to calculate the soft selection for my Vertex Edit. So for each vertex in the selection set I needed to find the closest closest distance to any of the vertices not selected. It was the distance method that was so slow.
                  I did some tests - created a dummy set of 3d data in C and calculated the soft selection for that. Very fast. But as soon as I made the source data set come from RUBY it became very slow. The C function was setting two sets of ruby arrays of vertices. Getting the X,Y,Z data for each vertex seemed to be very slow - converting Vertex to Point3d and then converting the X,Y,Z into C doubles.
                  For every vertex in the selection I was iterating the remaining set of vertices and converting them.
                  What I then did was to do a pre-pass of the non-selected vertices and create an C array of point3d structs. I then got a big speed increase. That's what lead me to the impression that converting Ruby VALUES to C types are expensive.

                  Thomas Thomassen β€” SketchUp Monkey & Coding addict
                  List of my plugins and link to the CookieWare fund

                  1 Reply Last reply Reply Quote 0
                  • A Offline
                    AdamB
                    last edited by 13 Apr 2010, 14:46

                    distance requires a square root of a scalar product. ie sqrt(A.B)

                    Keep in mind that in native "cpu" math, A.B is perhaps ~5 cycles and sqrt(X) is perhaps ~35 cycles. If you don't actually need the squareroot but just need to find the closest, then just compare A.B which should be significantly faster.

                    Developer of LightUp Click for website

                    1 Reply Last reply Reply Quote 0
                    • T Offline
                      thomthom
                      last edited by 13 Apr 2010, 15:16

                      @adamb said:

                      distance requires a square root of a scalar product. ie sqrt(A.B)

                      Keep in mind that in native "cpu" math, A.B is perhaps ~5 cycles and sqrt(X) is perhaps ~35 cycles. If you don't actually need the squareroot but just need to find the closest, then just compare A.B which should be significantly faster.

                      Yes - I was reading up on sqrt and found that to compare "longer" and "shorter" I didn't need sqrt. So I changed my code to only do the square root after I've found the shortest distance. That way it's called only once per vertex in Selection. (I needed the distance for some other calculations)

                      Thomas Thomassen β€” SketchUp Monkey & Coding addict
                      List of my plugins and link to the CookieWare fund

                      1 Reply Last reply Reply Quote 0
                      • C Offline
                        cjthompson
                        last edited by 13 Apr 2010, 15:50

                        @cjthompson said:

                        Has anyone looked into Enumerable.grep()? it seems pretty useful, but I don't know how fast it is.

                        well, since no one seems to be listening... 😒
                        I ran my own test (for: is using a for loop, grep: is using Enumerable.grep)
                        speedTest for: entities - 0.016 grep: entities - 0.015 for: entities array - 0.0 grep: entities array - 0.016 for: range - 0.219 grep: range - 0.203 for: range array - 0.219 grep: range array - 0.218 for: strings - 0.469 grep: strings - 0.234 nil

                        here is the code I used:

                        def speedTest
                        	entities = Sketchup.active_model.entities
                        	entitiesArray = entities.to_a
                        	range = 0..1000000
                        	rangeArray = range.to_a
                        	strings = range.collect{|number| number.to_s}
                        	
                        	## Entities
                        	
                        	results = []
                        	start = Time.now
                        	for ent in entities
                        		if(ent.class == Sketchup;;Edge)
                        			results << ent
                        		end
                        	end
                        	puts "for; entities - " + (Time.now - start).to_s
                        	
                        	results = []
                        	start = Time.now
                        	results = entities.grep(Sketchup;;Edge)
                        	puts "grep; entities - " + (Time.now - start).to_s
                        	
                        	## Entities array
                        	
                        	results = []
                        	start = Time.now
                        	for ent in entitiesArray
                        		if(ent.class == Sketchup;;Edge)
                        			results << ent
                        		end
                        	end
                        	puts "for; entities array - " + (Time.now - start).to_s
                        	
                        	results = []
                        	start = Time.now
                        	results = entitiesArray.grep(Sketchup;;Edge)
                        	puts "grep; entities array - " + (Time.now - start).to_s
                        	
                        	## Range
                        	
                        	results = []
                        	start = Time.now
                        	for num in range
                        		if(num == 318256)
                        			results << num
                        		end
                        	end
                        	puts "for; range - " + (Time.now - start).to_s
                        	
                        	results = []
                        	start = Time.now
                        	results = range.grep(318256)
                        	puts "grep; range - " + (Time.now - start).to_s
                        	
                        	## Range Array
                        	
                        	results = []
                        	start = Time.now
                        	for num in rangeArray
                        		if(num == 318256)
                        			results << num
                        		end
                        	end
                        	puts "for; range array - " + (Time.now - start).to_s
                        	
                        	results = []
                        	start = Time.now
                        	results = rangeArray.grep(318256)
                        	puts "grep; range array - " + (Time.now - start).to_s
                        	
                        	## Strings
                        	
                        	results = []
                        	start = Time.now
                        	for str in strings
                        		if(str.match(/312\Z/))
                        			results << str
                        		end
                        	end
                        	puts "for; strings - " + (Time.now - start).to_s
                        	
                        	results = []
                        	start = Time.now
                        	results = range.grep(/312\Z/)
                        	puts "grep; strings - " + (Time.now - start).to_s
                        	
                        end
                        

                        and the model I tested on:


                        test1k.skp

                        1 Reply Last reply Reply Quote 0
                        • T Offline
                          thomthom
                          last edited by 13 Apr 2010, 15:54

                          I also read that depending on the settings of the compiler the instruction set used to compute sqrt and it's performance vary greatly. One of the articles I read suggested that many compilers will use old set of instructions by default for greater compatibility.
                          What do you do for your projects?

                          Edit: one of the articles I read: http://assemblyrequired.crashworks.org/2009/10/16/timing-square-root/

                          Thomas Thomassen β€” SketchUp Monkey & Coding addict
                          List of my plugins and link to the CookieWare fund

                          1 Reply Last reply Reply Quote 0
                          • P Offline
                            Pout
                            last edited by 19 Apr 2010, 13:32

                            concerning typename vs class:

                            For, till now, unexplained reason when i change typename with class the results are different
                            Script is a bit like this:

                            x=entity.class (or entity.typename)
                            if x=="Face"
                            do something
                            elsif x=="Group"
                            do something
                            elsif x=="ComponentInstance"
                            do something
                            else
                            end
                            

                            When the type is "ComponentInstance" the results are not the same for class and typename.
                            I need to check on this since the speed increase is huge

                            1 Reply Last reply Reply Quote 0
                            • T Offline
                              thomthom
                              last edited by 19 Apr 2010, 13:52

                              .class returns a Class object - not a string.
                              What causes the slow down is the string comparison - that's what you want to avoid.

                              
                              x=entity.class
                              if x==Sketchup;;Face
                                do something
                              elsif x==Sketchup;;Group
                                do something
                              elsif x==Sketchup;;ComponentInstance
                                do something
                              else
                              end
                              
                              

                              or

                              
                              if entity.is_a?(Sketchup;;Face)
                                do something
                              elsif entity.is_a?(Sketchup;;Group)
                                do something
                              elsif entity.is_a?(Sketchup;;ComponentInstance)
                                do something
                              else
                              end
                              
                              

                              Update: fixed is_? to is_a?

                              Thomas Thomassen β€” SketchUp Monkey & Coding addict
                              List of my plugins and link to the CookieWare fund

                              1 Reply Last reply Reply Quote 0
                              • P Offline
                                Pout
                                last edited by 19 Apr 2010, 14:02

                                I'll check and let you know. When i use 'class' the correct conditions are entered but the result differs.
                                I'll keep you posted if it changes with your scripts.

                                Thx

                                1 Reply Last reply Reply Quote 0
                                • P Offline
                                  Pout
                                  last edited by 7 May 2010, 08:41

                                  all works, speeds increase is fine πŸ˜„
                                  thx!

                                  1 Reply Last reply Reply Quote 0
                                  • T Offline
                                    thomthom
                                    last edited by 7 May 2010, 08:50

                                    πŸ‘

                                    Thomas Thomassen β€” SketchUp Monkey & Coding addict
                                    List of my plugins and link to the CookieWare fund

                                    1 Reply Last reply Reply Quote 0
                                    • K Offline
                                      kwalkerman
                                      last edited by 15 Jul 2010, 05:29

                                      One thing I have noticed is that some code runs much slower with the outliner window open. Is there a way to close the window at the start of certain code execution, and then re-open it at the end?

                                      --
                                      Karen

                                      1 Reply Last reply Reply Quote 0
                                      • Dan RathbunD Offline
                                        Dan Rathbun
                                        last edited by 15 Jul 2010, 10:21

                                        @kwalkerman said:

                                        One thing I have noticed is that some code runs much slower with the outliner window open. Is there a way to close the window at the start of certain code execution, and then re-open it at the end?

                                        Maybe...
                                        but have you tried using Model.start_operation ?

                                        see also abort_operation and commit_operation

                                        I'm not here much anymore.

                                        1 Reply Last reply Reply Quote 0
                                        • Dan RathbunD Offline
                                          Dan Rathbun
                                          last edited by 15 Jul 2010, 10:26

                                          UI.show_inspector "Outliner"
                                          toggles it.
                                          Shows it if it's closed
                                          Rolls it up if it's shown
                                          Unrolls it if it's rolled up

                                          There's no way with the API to tell (now) what state it is in.

                                          I'm not here much anymore.

                                          1 Reply Last reply Reply Quote 0
                                          • 1
                                          • 2
                                          • 3
                                          • 4
                                          • 5
                                          • 6
                                          • 3 / 6
                                          • First post
                                            Last post
                                          Buy SketchPlus
                                          Buy SUbD
                                          Buy WrapR
                                          Buy eBook
                                          Buy Modelur
                                          Buy Vertex Tools
                                          Buy SketchCuisine
                                          Buy FormFonts

                                          Advertisement