Ruby right write

chrisglasier

Thanks Thom. Actually Jim wrote that and he should be asleep. I don't understand (File.join(File.dirname(__FILE__), subDir, file)) - why it has to be joined. Do I need to know. Is it relevant to writing?

Thanks

Chris

thomthom

The join method ensures that when you combine parts of a filename that it's compiled correctly, with forward slashes etc /. It return a fully compiled path to your file.

chrisglasier

Thanks again

chrisglasier

One other thing has come from this. I can write to the same file using Ruby or activeXObject in an .hta. The Ruby version adds an extra empty line which throws an "unterminated string constant" error when read. Any idea about what is going on?

Thanks


function coreRubyReq(callback, params) {
	window.location = "skp;" + callback + "@" + params.join(';');
}

function coreJsonSave(fileName, json) {
	var ForWriting, objFSO, objFile, txt;
	txt = JSON.stringify(json);
	if(config.SU === 1){
		coreRubyReq('save_json', [fileName, txt]);
	}
	else{
		ForWriting = 2;
		objFSO = new ActiveXObject("Scripting.FileSystemObject");
		objFile = objFSO.CreateTextFile(fileName, ForWriting);
		objFile.Write( txt );
		objFile.Close();
	}
}


@dlg.add_action_callback("save_json") { |d, a|
			p = a.split(";")
			subDir = "nset/Sketchup/"
			file = File.join(File.dirname(__FILE__), subDir, p[0])
			f = File.open(file, 'w')
			f.puts p[1].to_s
			f.close
		}

thomthom

hmm...

extra line? at the end? or for each line?

Could be that my example opened the file as binary.

#binary read
f = File.open(file, 'rb')

#normal read
f = File.open(file, 'r')

This the latter treats line breaks differently. (linebreaks are different from platform to platform)

chrisglasier

machine Jan 008.png

I left Jim's for the read and used yours for the write.

chrisglasier

Maybe if I pass it though a hidden input?? I should do that anyway - forgot!

thomthom

? to get rid of extra lines?

cjthompson

@chrisglasier said:


> @dlg.add_action_callback("save_json") { |d, a|
> 			p = a.split(";")
> 			subDir = "nset/Sketchup/"
> 			file = File.join(File.dirname(__FILE__), subDir, p[0])
> 			f = File.open(file, 'w')
> 			f.puts p[1].to_s
> 			f.close
> 		}
>

I think the problem is

f.puts p[1].to_s

Try using

f.write p[1].to_s

chrisglasier

Works ... thanks Chris

Chris

Jim

I think it's odd that the parser would be sensitive to a newline at the end of the file.