New API doc - typos and questions

scottlininger

We could ask Coen to have a strike-through BBC tag. [deleted] or something...
Or, put a big fat FIXED in bold green. Might be easier.

Jim, is there a way that I could be granted edit rights just to this thread? Then I could add a FIXED note inside the reports as I correct them?

thomthom

@unknownuser said:

I'm about to push an update with all of the recent changes above. This one puzzled me, though. The ToolsObserver examples work fine for me on the onOpen and onClose. Can you clarify what "dead as well" means?

Dead as in: I never see it trigger.

thomthom

ToolObservers? How are they related to onClose and onOpen?

remus

@unknownuser said:

Jim, is there a way that I could be granted edit rights just to this thread? Then I could add a FIXED note inside the reports as I correct them?

I'll ask gai if he can make you a mod for the ruby forum

scottlininger

@thomthom said:

ToolObservers? How are they related to onClose and onOpen?

I meant to say, InstanceObservers.

In any case, they fire fine for me.

Jim

@remus said:

@unknownuser said:

Jim, is there a way that I could be granted edit rights just to this thread? Then I could add a FIXED note inside the reports as I correct them?

I'll ask gai if he can make you a mod for the ruby forum

Scott, there's no way to give edit-rights on a single topic. So you get edit rights to the whole Ruby Forum.

If you have a list of changes, we can take care of marking them fixed. I'd hate to see you spend time doing it if you have more important work to do.

Gaieus

Hi Scott, I have sent you a PM, too, about it. The mods have also be informed to welcome you in the team.

thomthom

@unknownuser said:

@thomthom said:

ToolObservers? How are they related to onClose and onOpen?

I meant to say, InstanceObservers.

In any case, they fire fine for me.

Hmm... When I tried to implement it in my plugin the onClose never fired. I also tried Jim's observer test script: http://sketchuptips.blogspot.com/2008/03/plugin-oberver-tests.html - and that never fired either. Could you post a working sample where onClose fires? (The onOpen always works though.)

scottlininger

@thomthom said:

Could you post a working sample where onClose fires?

Give this a go... Could be that we're seeing a sneaky bug...

class MyInstanceObserver < Sketchup;;InstanceObserver
   def onOpen(instance)
     UI.messagebox("onOpen; " + instance.to_s)
   end

   def onClose(instance)
     UI.messagebox("onClose; " + instance.to_s)
   end
end

model = Sketchup.active_model
model.definitions[0].instances[0].add_observer(MyInstanceObserver.new)

thomthom

Nopes. Doesn't work.

Jim

Works for me...

thomthom

Scott just found out that it works if the script loads when SU loads. But if you put it a subfolder for instance, and then manually load it, it won't work.
Jim's Observer tests never fire the event in SU7. However, in SU6 it works fine.

Jim

Just wondering if you have Dynamic Components on, and what happens if you turn them off?

thomthom

@jim said:

Just wondering if you have Dynamic Components on, and what happens if you turn them off?

Well I'll be! After disabling DCs the onClose even works!

btw, the DefinitionObserver works in SU6. But not SU7. Noticed that when I tested this observer in SU6.

scottlininger

Self note: need to add an explanation of how add_face works in relation to which "side" of the face is inside vs. outside, and document the exception where faces drawn at z=0 are always drawn with inside facing upward.

-Scott Lininger

scottlininger

From Didier's post:

http://www.sketchucation.com/forums/scf/viewtopic.php?f=180&t=18488

Need to add an FAQ for getting to installation directory of SU, for folks trying to build installers (and find out a mac equivalent.)

avariant

BoundingBox.valid?

text says

status
    true if the bounding box is valid (not empty), false if it is not valid (empty)

but the code example has it exactly the opposite:

 bbox = Sketchup.active_model.bounds
 status = bbox.valid?
 if (status)
   # If true, bounding box is empty.
 else
   # If false, bounding box contains entities.
 end

Chris Fullmer

The introduction to RenderingOptions class states:

@unknownuser said:

The majority of the rendering information returned exists in the Model Info > Display section of SketchUp.

There is no longer a Model Info > Distplay section of SketchUp. I suppose it should say its in the styles inspector or something like that.

http://code.google.com/apis/sketchup/docs/ourdoc/renderingoptions.html#introduction

Also, the API doesn't list these:

DisplayQueWidth
DisplayDims
DisplaySketchAxes
DisplayText
DisplayWatermarks
DrawDepthQue
DrawLineEnds
DrawProfilesOnly
DrawUnderground
EdgeType
FogEndDist*- listed as FogEnd in the API*
FogStartDist - listed as FogStart in the API
HideConstructionGeometry
LineEndWidth
LockedColor
SectionTransparencyMode
ShowViewName

And the API lists these which don't appear to be valid:
DisplayFogEdges
FogDensity
FogEnd - appears to actually be FogEndDist
FogStart*- appears to actually be FogStartDist*
FogType

I tried to be thorough, but perhaps I missed something. It might not be bad to double check my work

Chris

Chris Fullmer

http://code.google.com/apis/sketchup/docs/ourdoc/tool.html#onReturn

the onReturn method is showing an example for onMouseLeave

Chris Fullmer

http://code.google.com/apis/sketchup/docs/ourdoc/view.html#zoom_extents

Does not give an example of view.zoom_extents. It gives an example of view.zoom