sketchucation logo sketchucation
    • Login
    ℹ️ Licensed Extensions | FredoBatch, ElevationProfile, FredoSketch, LayOps, MatSim and Pic2Shape will require license from Sept 1st More Info

    Multiple dialog scope issue on the PC

    Scheduled Pinned Locked Moved Developers' Forum
    24 Posts 4 Posters 374 Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • thomthomT Offline
      thomthom
      last edited by

      Back tot the side topic of best practices:
      It's generally considered best practice to separate content, layout and behaviour. That means all CSS in a .css file and all JS in a .js file.

      And I've never heard of void(0) as best practice. I find it often in Bad Practices lists:
      http://www.quirksmode.org/blog/archives/2005/06/three_javascrip_1.html#link3

      Link Preview Image
      "javascript:void(0);" vs "return false" vs "preventDefault()"

      When I want some link to not do anything but only respond to JavaScript actions what is the best way to avoid the link scrolling to the top edge of the page? I know several ways of doing it, they all

      favicon

      Stack Overflow (stackoverflow.com)

      Thomas Thomassen β€” SketchUp Monkey & Coding addict
      List of my plugins and link to the CookieWare fund

      1 Reply Last reply Reply Quote 0
      • H Offline
        honkinberry
        last edited by

        Both of those links that you sent merely say it is bad form to put javascript into the href, which is true.
        The javascript:void(0) is the recommended practice, indicating that the onclick handler is to take precedence.
        In fact, the whole point of it is so that it onclick handler doesn't have to return false.
        (See here: http://stackoverflow.com/questions/134845/href-attribute-for-javascript-links-or-javascriptvoid0)

        But good to know that was the issue!
        Many thanks for your tireless attention to detail on every conceivable issue.

        --J

        1 Reply Last reply Reply Quote 0
        • thomthomT Offline
          thomthom
          last edited by

          @honkinberry said:

          Both of those links that you sent merely say it is bad form to put javascript into the href, which is true.
          The javascript:void(0) is the recommended practice, indicating that the onclick handler is to take precedence.
          In fact, the whole point of it is so that it onclick handler doesn't have to return false.
          (See here: http://stackoverflow.com/questions/134845/href-attribute-for-javascript-links-or-javascriptvoid0)

          But when would you use void(0) in anything other than the HREF?

          I still agree with with the this answer:
          http://stackoverflow.com/a/134957/486990

          There's a lot of information floating around which is lingering around from the older days. When going through best practices guides of well known web designers it's always to avoid inline JS. Which then removes void(0) from the equation completely.

          @honkinberry said:

          But good to know that was the issue!
          Many thanks for your tireless attention to detail on every conceivable issue.

          No worries. I had some spare time while I was rendering. πŸ˜„
          And the WebDialog has been a source of so much oddity that I felt a strong inclination to check it out myself. I reckon it's still worth reporting, so if you're heading into Boulder then give them a nudge. πŸ˜„

          Thomas Thomassen β€” SketchUp Monkey & Coding addict
          List of my plugins and link to the CookieWare fund

          1 Reply Last reply Reply Quote 0
          • Dan RathbunD Offline
            Dan Rathbun
            last edited by

            @honkinberry said:

            The javascript:void(0) is the recommended practice, indicating that the onclick handler is to take precedence.

            I disagreed 3 years ago when we discussed this issue, and still do.

            Read my detailed explanation in this old thread: Webdialogs and Javascript void

            Any more discussion on this offtopic, can be done in that thread, if you wish.

            I'm not here much anymore.

            1 Reply Last reply Reply Quote 0
            • 1
            • 2
            • 2 / 2
            • First post
              Last post
            Buy SketchPlus
            Buy SUbD
            Buy WrapR
            Buy eBook
            Buy Modelur
            Buy Vertex Tools
            Buy SketchCuisine
            Buy FormFonts

            Advertisement